Linux-Devicetree Archive on lore.kernel.org
 help / color / Atom feed
From: David Lechner <david@lechnology.com>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 10/13] dt-bindings: iio: adc: ti,ads7950 binding conversion
Date: Wed, 12 Aug 2020 11:30:28 -0500
Message-ID: <5a4f6244-8840-e871-4a15-b63ad461be4a@lechnology.com> (raw)
In-Reply-To: <20200809111753.156236-11-jic23@kernel.org>

On 8/9/20 6:17 AM, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Simple conversion.  This binding already had the
> that is necessary, I'm happy to leave it as previously documented.

This commit message doesn't make sense to me. It should probably
just say "this converts the device tree bindings to yml" or so.

> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: David Lechner <david@lechnology.com>
> ---
>   .../bindings/iio/adc/ti,ads7950.yaml          | 64 +++++++++++++++++++
>   .../bindings/iio/adc/ti-ads7950.txt           | 23 -------
>   2 files changed, 64 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
> new file mode 100644
> index 000000000000..a759d9064718
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,ads7950.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ADS7950 and similar ADCs
> +
> +maintainers:
> +  - David Lechner <david@lechnology.com>
> +
> +description: |
> +  Family of 4-16 channel, 8-12 bit ADCs with SPI interface.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,ads7950
> +      - ti,ads7951
> +      - ti,ads7952
> +      - ti,ads7953
> +      - ti,ads7954
> +      - ti,ads7955
> +      - ti,ads7956
> +      - ti,ads7957
> +      - ti,ads7958
> +      - ti,ads7959
> +      - ti,ads7960
> +      - ti,ads7961
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-max-frequency: true

According to the datasheet, max frequency is 20MHz, so this can be:

spi-max-frequency:
   maximum: 20000000

> +
> +  vref-supply:
> +    description: Supply the 2.5V or 5V reference voltage

Should this say "Supplies ..."?

> +
> +  "#io-channel-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - vref-supply
> +  - "#io-channel-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "ti,ads7957";
> +            reg = <0>;
> +            vref-supply = <&refin_supply>;
> +            spi-max-frequency = <10000000>;
> +            #io-channel-cells = <1>;
> +        };
> +    };



  reply index

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-09 11:17 [PATCH 00/13] dt-bindings: yaml conversions of some simple ADC bindings Jonathan Cameron
2020-08-09 11:17 ` [PATCH 01/13] dt-bindings: iio: adc: microchip,mcp3201 yaml conversion Jonathan Cameron
2020-08-18  2:24   ` Rob Herring
2020-08-30 13:25     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 02/13] dt-bindings: trivial-devices: Add mcp342x ADCs and drop separate binding doc Jonathan Cameron
2020-08-18  2:27   ` Rob Herring
2020-08-29 17:48     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 03/13] dt-bindings: iio: adc: ti,adc108s102 yaml conversion Jonathan Cameron
2020-08-18  2:27   ` Rob Herring
2020-08-29 17:50     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 04/13] dt-bindings: iio: adc: lltc,ltc2497 " Jonathan Cameron
2020-08-18  2:28   ` Rob Herring
2020-08-29 17:50     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 05/13] dt-bindings: iio: adc: ti,adc161s626 " Jonathan Cameron
2020-08-11  3:35   ` Matt Ranostay
2020-08-18  2:28   ` Rob Herring
2020-08-29 17:51     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 06/13] dt-bindings: iio: adc: ti,adc0832 " Jonathan Cameron
2020-08-18  2:29   ` Rob Herring
2020-08-09 11:17 ` [PATCH 07/13] dt-bindings: iio: adc: ti,adc084s021 " Jonathan Cameron
2020-08-18  2:30   ` Rob Herring
2020-08-29 17:53     ` Jonathan Cameron
2020-10-27 15:28       ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 08/13] dt-bindings: iio: adc: ti,adc12138 " Jonathan Cameron
2020-08-12 16:29   ` Rob Herring
2020-08-16  9:06     ` Jonathan Cameron
2020-08-17 14:17   ` Rob Herring
2020-08-09 11:17 ` [PATCH 09/13] dt-bindings: iio: adc: ti,adc128s052 " Jonathan Cameron
2020-08-18  2:30   ` Rob Herring
2020-08-29 17:55     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 10/13] dt-bindings: iio: adc: ti,ads7950 binding conversion Jonathan Cameron
2020-08-12 16:30   ` David Lechner [this message]
2020-08-30 15:55     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 11/13] dt-bindings: iio: adc: ti,ads8344 yaml conversion Jonathan Cameron
2020-08-18  2:31   ` Rob Herring
2020-08-29 17:58     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 12/13] dt-bindings: iio: adc: tlc4541 - recover accidentally dropped binding doc Jonathan Cameron
2020-08-29 17:57   ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 13/13] dt-bindings: iio: adc: ti,tlc4541 binding conversion Jonathan Cameron
2020-08-10  0:42   ` Phil Reid
2020-08-18  2:32   ` Rob Herring
2020-08-29 17:59     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a4f6244-8840-e871-4a15-b63ad461be4a@lechnology.com \
    --to=david@lechnology.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Devicetree Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git
	git clone --mirror https://lore.kernel.org/linux-devicetree/1 linux-devicetree/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \
		devicetree@vger.kernel.org
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git