devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Konovalov <andrey.konovalov@linaro.org>
To: Ezequiel Garcia <ezequiel@collabora.com>,
	mchehab@kernel.org, robh+dt@kernel.org
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	peter.griffin@linaro.org, dave.stevenson@raspberrypi.com,
	sakari.ailus@linux.intel.com
Subject: Re: [PATCH v3 0/2] Add IMX219 CMOS image sensor support
Date: Sat, 11 Jan 2020 20:46:33 +0300	[thread overview]
Message-ID: <5ffcdaad-159b-795b-2029-f3009d0249cf@linaro.org> (raw)
In-Reply-To: <b1ce520494275ea2b9bd63af6ef12e9e8ac3c122.camel@collabora.com>

Hi Ezequiel,

On 11.01.2020 07:45, Ezequiel Garcia wrote:
> Hello Andrey,
> 
> Thanks for submitting a new version.
> 
> On Fri, 2020-01-10 at 23:09 +0300, Andrey Konovalov wrote:
>> This patchset adds support for IMX219 CMOS image sensor from Sony.
>> Sony IMX219 is an 8MPix, 1/4.0-inch CMOS active pixel digital image sensor
>> with an active array size of 3280H x 2464V. It is programmable through
>> I2C interface. Image data are sent through MIPI CSI-2, which can be configured
>> as either 2 or 4 data lanes, but this driver currently only supports 2 lanes.
>> The currently supported resolutions are 3280x2464 @ 15fps, 1920x1080 @ 30fps
>> (cropped FOV), and 1640x1232 (2x2 binned) @ 30fps.
>>
>> The driver has been tested with Raspberry Pi Camera Module v2 connected to
>> Raspberry Pi Zero W.
>>
>> Changes since v2 [1]:
>>
>> dt-bindings:
>>    - "clock-names" property removed
>>    - "xclr-gpios" property renamed to "reset-gpios"
>>    - the camera-clk mode moved out of sensor device node
>>    - "clock-lanes" property removed (the sensor doesn't support lane reordering)
>>    - "clock-noncontinuous" description made more clear (thanks Sakari)
>>    - "data-lanes" property reworked: it is now optional, and if it is not
>>      present the driver should assume four-lane operation. For two-lane
>>      operation (the only mode supported by the current driver) this property
>>      must be present and set to <1 2>
>>
>> imx219 sensor driver:
>>    - "xclr-gpios" property renamed to "reset-gpios", the corresponding
>>      struct gpio_desc field in the imx219 structure is renamed to reset_gpio
>>    - in the driver probe() a test to check that the number of CSI-2 data lanes
>>      is supported by the driver was added
>>    - devm_clk_get() is now called with NULL as the 2nd argument, as there is
>>      just single clock, and there is no need to use clock ID
>>    - error messages are added when the driver fails to get regulators, to init
>>      media entity pads, or to register sensor sub-device
>>
> 
> It seems you missed Sakari's review comments on v2,
> see https://patchwork.linuxtv.org/patch/60925/#114407

Hm.. Indeed. I missed Sakari's comments on the imx219.c v2 somehow.
I'll post an updated patchset shortly.

Thanks!
Andrey

> Thanks!
> Eze
> 
> 
> 

      reply	other threads:[~2020-01-11 17:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 20:09 [PATCH v3 0/2] Add IMX219 CMOS image sensor support Andrey Konovalov
2020-01-10 20:09 ` [PATCH v3 1/2] dt-bindings: media: i2c: Add IMX219 CMOS sensor binding Andrey Konovalov
2020-01-13 23:04   ` Rob Herring
2020-01-10 20:09 ` [PATCH v3 2/2] media: i2c: Add driver for Sony IMX219 sensor Andrey Konovalov
2020-01-11  4:45 ` [PATCH v3 0/2] Add IMX219 CMOS image sensor support Ezequiel Garcia
2020-01-11 17:46   ` Andrey Konovalov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ffcdaad-159b-795b-2029-f3009d0249cf@linaro.org \
    --to=andrey.konovalov@linaro.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@collabora.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).