From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Pingfan Liu <kernelfans@gmail.com>, <devicetree@vger.kernel.org>,
<linux-efi@vger.kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
Frank Rowand <frowand.list@gmail.com>,
Ard Biesheuvel <ardb@kernel.org>, Nick Terrell <terrelln@fb.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv3] efi: apply memblock cap after memblock_add()
Date: Wed, 22 Dec 2021 16:00:01 +0800 [thread overview]
Message-ID: <7060b244-03d3-e81f-f545-cf2d4fe5c2dd@huawei.com> (raw)
In-Reply-To: <20211215021348.8766-1-kernelfans@gmail.com>
On 2021/12/15 10:13, Pingfan Liu wrote:
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 18a2df431bfd..aa07ef5cab5f 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -972,7 +972,7 @@ static unsigned long chosen_node_offset = -FDT_ERR_NOTFOUND;
> * location from flat tree
> * @node: reference to node containing usable memory range location ('chosen')
> */
> -static void __init early_init_dt_check_for_usable_mem_range(void)
> +void __init early_init_dt_check_for_usable_mem_range(void)
Why do I see a parameter 'node'?
master:
drivers/of/fdt.c:976:static void __init early_init_dt_check_for_usable_mem_range(unsigned long node)
next:
drivers/of/fdt.c:980:static void __init early_init_dt_check_for_usable_mem_range(unsigned long node)
> {
> const __be32 *prop;
> int len;
> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
> index cf48983d3c86..ad09beb6d13c 100644
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -62,6 +62,7 @@ extern int early_init_dt_scan_chosen(unsigned long node, const char *uname,
> int depth, void *data);
> extern int early_init_dt_scan_memory(unsigned long node, const char *uname,
> int depth, void *data);
> +extern void early_init_dt_check_for_usable_mem_range(void);
> extern int early_init_dt_scan_chosen_stdout(void);
> extern void early_init_fdt_scan_reserved_mem(void);
> extern void early_init_fdt_reserve_self(void);
> @@ -86,6 +87,7 @@ extern void unflatten_and_copy_device_tree(void);
> extern void early_init_devtree(void *);
> extern void early_get_first_memblock_info(void *, phys_addr_t *);
> #else /* CONFIG_OF_EARLY_FLATTREE */
> +static inline void early_init_dt_check_for_usable_mem_range(void) {}
> static inline int early_init_dt_scan_chosen_stdout(void) { return -ENODEV; }
> static inline void early_init_fdt_scan_reserved_mem(void) {}
> static inline void early_init_fdt_reserve_self(void) {}
>
next prev parent reply other threads:[~2021-12-22 8:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 4:01 [PATCHv2 0/2] arm64: fdt: fix membock add/cap ordering Pingfan Liu
2021-12-14 4:01 ` [PATCHv2 1/2] of: fdt: Aggregate the processing of "linux,usable-memory-range" Pingfan Liu
2021-12-14 4:01 ` [PATCHv2 2/2] efi: apply memblock cap after memblock_add() Pingfan Liu
2021-12-14 14:55 ` Rob Herring
2021-12-15 2:04 ` Pingfan Liu
2021-12-15 2:13 ` [PATCHv3] " Pingfan Liu
2021-12-15 3:58 ` Leizhen (ThunderTown)
2021-12-15 5:29 ` Pingfan Liu
2021-12-15 6:53 ` Leizhen (ThunderTown)
2021-12-15 8:24 ` Pingfan Liu
2021-12-15 15:05 ` Rob Herring
2021-12-16 13:34 ` Leizhen (ThunderTown)
2021-12-17 15:08 ` Rob Herring
2021-12-17 15:25 ` Ard Biesheuvel
2021-12-21 15:17 ` Rob Herring
2021-12-22 8:00 ` Leizhen (ThunderTown) [this message]
2021-12-23 7:33 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7060b244-03d3-e81f-f545-cf2d4fe5c2dd@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=kernelfans@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rppt@kernel.org \
--cc=terrelln@fb.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).