From: Ard Biesheuvel <ardb@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Pingfan Liu <kernelfans@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
Zhen Lei <thunder.leizhen@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Frank Rowand <frowand.list@gmail.com>,
Nick Terrell <terrelln@fb.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv3] efi: apply memblock cap after memblock_add()
Date: Fri, 17 Dec 2021 16:25:36 +0100 [thread overview]
Message-ID: <CAMj1kXH07Q50Zf_=dJ8G1q7ngjKSO01usmQ25wouygmaV_+wnA@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqJQ4hiQ1eEYrnWax9oEDpwdh93pYo+sSV581R+F6F0ymA@mail.gmail.com>
On Fri, 17 Dec 2021 at 16:08, Rob Herring <robh+dt@kernel.org> wrote:
>
> On Tue, Dec 14, 2021 at 8:14 PM Pingfan Liu <kernelfans@gmail.com> wrote:
> >
> > On arm64, during kdump kernel saves vmcore, it runs into the following bug:
> > ...
> > [ 15.148919] usercopy: Kernel memory exposure attempt detected from SLUB object 'kmem_cache_node' (offset 0, size 4096)!
> > [ 15.159707] ------------[ cut here ]------------
> > [ 15.164311] kernel BUG at mm/usercopy.c:99!
> > [ 15.168482] Internal error: Oops - BUG: 0 [#1] SMP
> > [ 15.173261] Modules linked in: xfs libcrc32c crct10dif_ce ghash_ce sha2_ce sha256_arm64 sha1_ce sbsa_gwdt ast i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm drm nvme nvme_core xgene_hwmon i2c_designware_platform i2c_designware_core dm_mirror dm_region_hash dm_log dm_mod overlay squashfs zstd_decompress loop
> > [ 15.206186] CPU: 0 PID: 542 Comm: cp Not tainted 5.16.0-rc4 #1
> > [ 15.212006] Hardware name: GIGABYTE R272-P30-JG/MP32-AR0-JG, BIOS F12 (SCP: 1.5.20210426) 05/13/2021
> > [ 15.221125] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> > [ 15.228073] pc : usercopy_abort+0x9c/0xa0
> > [ 15.232074] lr : usercopy_abort+0x9c/0xa0
> > [ 15.236070] sp : ffff8000121abba0
> > [ 15.239371] x29: ffff8000121abbb0 x28: 0000000000003000 x27: 0000000000000000
> > [ 15.246494] x26: 0000000080000400 x25: 0000ffff885c7000 x24: 0000000000000000
> > [ 15.253617] x23: 000007ff80400000 x22: ffff07ff80401000 x21: 0000000000000001
> > [ 15.260739] x20: 0000000000001000 x19: ffff07ff80400000 x18: ffffffffffffffff
> > [ 15.267861] x17: 656a626f2042554c x16: 53206d6f72662064 x15: 6574636574656420
> > [ 15.274983] x14: 74706d6574746120 x13: 2129363930342065 x12: 7a6973202c302074
> > [ 15.282105] x11: ffffc8b041d1b148 x10: 00000000ffff8000 x9 : ffffc8b04012812c
> > [ 15.289228] x8 : 00000000ffff7fff x7 : ffffc8b041d1b148 x6 : 0000000000000000
> > [ 15.296349] x5 : 0000000000000000 x4 : 0000000000007fff x3 : 0000000000000000
> > [ 15.303471] x2 : 0000000000000000 x1 : ffff07ff8c064800 x0 : 000000000000006b
> > [ 15.310593] Call trace:
> > [ 15.313027] usercopy_abort+0x9c/0xa0
> > [ 15.316677] __check_heap_object+0xd4/0xf0
> > [ 15.320762] __check_object_size.part.0+0x160/0x1e0
> > [ 15.325628] __check_object_size+0x2c/0x40
> > [ 15.329711] copy_oldmem_page+0x7c/0x140
> > [ 15.333623] read_from_oldmem.part.0+0xfc/0x1c0
> > [ 15.338142] __read_vmcore.constprop.0+0x23c/0x350
> > [ 15.342920] read_vmcore+0x28/0x34
> > [ 15.346309] proc_reg_read+0xb4/0xf0
> > [ 15.349871] vfs_read+0xb8/0x1f0
> > [ 15.353088] ksys_read+0x74/0x100
> > [ 15.356390] __arm64_sys_read+0x28/0x34
> > ...
> >
> > This bug introduced by commit b261dba2fdb2 ("arm64: kdump: Remove custom
> > linux,usable-memory-range handling"), which moves
> > memblock_cap_memory_range() to fdt, but it breaches the rules that
> > memblock_cap_memory_range() should come after memblock_add() etc as said
> > in commit e888fa7bb882 ("memblock: Check memory add/cap ordering").
> >
> > As a consequence, the virtual address set up by copy_oldmem_page() does
> > not bail out from the test of virt_addr_valid() in check_heap_object(),
> > and finally hits the BUG_ON().
> >
> > Since memblock allocator has no idea about when the memblock is fully
> > populated, while efi_init() is aware, so tackling this issue by calling the
> > interface early_init_dt_check_for_usable_mem_range() exposed by of/fdt.
> >
> > Fixes: b261dba2fdb2 ("arm64: kdump: Remove custom linux,usable-memory-range handling")
> > Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Zhen Lei <thunder.leizhen@huawei.com>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Mike Rapoport <rppt@kernel.org>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Frank Rowand <frowand.list@gmail.com>
> > Cc: Ard Biesheuvel <ardb@kernel.org>
> > Cc: Nick Terrell <terrelln@fb.com>
> > Cc: linux-arm-kernel@lists.infradead.org
> > To: devicetree@vger.kernel.org
> > To: linux-efi@vger.kernel.org
> > ---
> > v2 -> v3:
> > use static inline stub to avoid #ifdef according to Rob's suggestion
> >
> > drivers/firmware/efi/efi-init.c | 5 +++++
> > drivers/of/fdt.c | 2 +-
> > include/linux/of_fdt.h | 2 ++
> > 3 files changed, 8 insertions(+), 1 deletion(-)
>
> Looks good to me. I'll apply and send to Linus once the EFI folks ack this.
>
Where needed in the series,
Acked-by: Ard Biesheuvel <ardb@kernel.org>
next prev parent reply other threads:[~2021-12-17 15:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 4:01 [PATCHv2 0/2] arm64: fdt: fix membock add/cap ordering Pingfan Liu
2021-12-14 4:01 ` [PATCHv2 1/2] of: fdt: Aggregate the processing of "linux,usable-memory-range" Pingfan Liu
2021-12-14 4:01 ` [PATCHv2 2/2] efi: apply memblock cap after memblock_add() Pingfan Liu
2021-12-14 14:55 ` Rob Herring
2021-12-15 2:04 ` Pingfan Liu
2021-12-15 2:13 ` [PATCHv3] " Pingfan Liu
2021-12-15 3:58 ` Leizhen (ThunderTown)
2021-12-15 5:29 ` Pingfan Liu
2021-12-15 6:53 ` Leizhen (ThunderTown)
2021-12-15 8:24 ` Pingfan Liu
2021-12-15 15:05 ` Rob Herring
2021-12-16 13:34 ` Leizhen (ThunderTown)
2021-12-17 15:08 ` Rob Herring
2021-12-17 15:25 ` Ard Biesheuvel [this message]
2021-12-21 15:17 ` Rob Herring
2021-12-22 8:00 ` Leizhen (ThunderTown)
2021-12-23 7:33 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXH07Q50Zf_=dJ8G1q7ngjKSO01usmQ25wouygmaV_+wnA@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=kernelfans@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rppt@kernel.org \
--cc=terrelln@fb.com \
--cc=thunder.leizhen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).