* [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz
@ 2020-07-06 8:37 Hsin-Yi Wang
2020-07-08 17:01 ` Matthias Brugger
0 siblings, 1 reply; 4+ messages in thread
From: Hsin-Yi Wang @ 2020-07-06 8:37 UTC (permalink / raw)
To: linux-mediatek
Cc: Rob Herring, Matthias Brugger, devicetree, linux-kernel,
Enric Balletbo i Serra, ikjn
Re measure capacity-dmips-mhz on elm and hana:
cpu 1: 9502 DMIPS @ 1703 Mhz
cpu 3: 16250 DMIPS @ 2106 Mhz
==> 740 : 1024
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 70b1ffcab7f0..5e046f9d48ce 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -167,7 +167,7 @@ cpu0: cpu@0 {
<&apmixedsys CLK_APMIXED_MAINPLL>;
clock-names = "cpu", "intermediate";
operating-points-v2 = <&cluster0_opp>;
- capacity-dmips-mhz = <526>;
+ capacity-dmips-mhz = <740>;
};
cpu1: cpu@1 {
@@ -182,7 +182,7 @@ cpu1: cpu@1 {
<&apmixedsys CLK_APMIXED_MAINPLL>;
clock-names = "cpu", "intermediate";
operating-points-v2 = <&cluster0_opp>;
- capacity-dmips-mhz = <526>;
+ capacity-dmips-mhz = <740>;
};
cpu2: cpu@100 {
--
2.27.0.212.ge8ba1cc988-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz
2020-07-06 8:37 [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz Hsin-Yi Wang
@ 2020-07-08 17:01 ` Matthias Brugger
2020-07-08 18:55 ` Hsin-Yi Wang
0 siblings, 1 reply; 4+ messages in thread
From: Matthias Brugger @ 2020-07-08 17:01 UTC (permalink / raw)
To: Hsin-Yi Wang, linux-mediatek
Cc: Rob Herring, devicetree, linux-kernel, Enric Balletbo i Serra, ikjn
On 06/07/2020 10:37, Hsin-Yi Wang wrote:
> Re measure capacity-dmips-mhz on elm and hana:
>
> cpu 1: 9502 DMIPS @ 1703 Mhz
> cpu 3: 16250 DMIPS @ 2106 Mhz
>
> ==> 740 : 1024
I have some trouble to match the commit message to the actual patch. Commit
message talks about cpu 1 but patch changes cpu0. Where are the values of the
other CPUs?
Regards,
Matthias
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 70b1ffcab7f0..5e046f9d48ce 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -167,7 +167,7 @@ cpu0: cpu@0 {
> <&apmixedsys CLK_APMIXED_MAINPLL>;
> clock-names = "cpu", "intermediate";
> operating-points-v2 = <&cluster0_opp>;
> - capacity-dmips-mhz = <526>;
> + capacity-dmips-mhz = <740>;
> };
>
> cpu1: cpu@1 {
> @@ -182,7 +182,7 @@ cpu1: cpu@1 {
> <&apmixedsys CLK_APMIXED_MAINPLL>;
> clock-names = "cpu", "intermediate";
> operating-points-v2 = <&cluster0_opp>;
> - capacity-dmips-mhz = <526>;
> + capacity-dmips-mhz = <740>;
> };
>
> cpu2: cpu@100 {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz
2020-07-08 17:01 ` Matthias Brugger
@ 2020-07-08 18:55 ` Hsin-Yi Wang
2020-07-10 13:34 ` Matthias Brugger
0 siblings, 1 reply; 4+ messages in thread
From: Hsin-Yi Wang @ 2020-07-08 18:55 UTC (permalink / raw)
To: Matthias Brugger
Cc: moderated list:ARM/Mediatek SoC support, Rob Herring,
Devicetree List, lkml, Enric Balletbo i Serra, Ikjoon Jang
On Thu, Jul 9, 2020 at 1:01 AM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>
> On 06/07/2020 10:37, Hsin-Yi Wang wrote:
> > Re measure capacity-dmips-mhz on elm and hana:
> >
> > cpu 1: 9502 DMIPS @ 1703 Mhz
> > cpu 3: 16250 DMIPS @ 2106 Mhz
> >
> > ==> 740 : 1024
>
> I have some trouble to match the commit message to the actual patch. Commit
> message talks about cpu 1 but patch changes cpu0. Where are the values of the
> other CPUs?
Small cpu on 8173 is cpu0 & cpu1, while big cpu is cpu2 & cpu3.
Small cpu: 9502 DMIPS @ 1703 Mhz
Big cpu: 16250 DMIPS @ 2106 Mhz
9502/1703 : 16250/2106 = 740 : 1024 (scale big cpu to 1024), and this patch
changes the small cpu value to 740.
>
> Regards,
> Matthias
>
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 70b1ffcab7f0..5e046f9d48ce 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -167,7 +167,7 @@ cpu0: cpu@0 {
> > <&apmixedsys CLK_APMIXED_MAINPLL>;
> > clock-names = "cpu", "intermediate";
> > operating-points-v2 = <&cluster0_opp>;
> > - capacity-dmips-mhz = <526>;
> > + capacity-dmips-mhz = <740>;
> > };
> >
> > cpu1: cpu@1 {
> > @@ -182,7 +182,7 @@ cpu1: cpu@1 {
> > <&apmixedsys CLK_APMIXED_MAINPLL>;
> > clock-names = "cpu", "intermediate";
> > operating-points-v2 = <&cluster0_opp>;
> > - capacity-dmips-mhz = <526>;
> > + capacity-dmips-mhz = <740>;
> > };
> >
> > cpu2: cpu@100 {
> >
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz
2020-07-08 18:55 ` Hsin-Yi Wang
@ 2020-07-10 13:34 ` Matthias Brugger
0 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2020-07-10 13:34 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: moderated list:ARM/Mediatek SoC support, Rob Herring,
Devicetree List, lkml, Enric Balletbo i Serra, Ikjoon Jang
On 08/07/2020 20:55, Hsin-Yi Wang wrote:
> On Thu, Jul 9, 2020 at 1:01 AM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>
>>
>>
>> On 06/07/2020 10:37, Hsin-Yi Wang wrote:
>>> Re measure capacity-dmips-mhz on elm and hana:
>>>
>>> cpu 1: 9502 DMIPS @ 1703 Mhz
>>> cpu 3: 16250 DMIPS @ 2106 Mhz
>>>
>>> ==> 740 : 1024
>>
>> I have some trouble to match the commit message to the actual patch. Commit
>> message talks about cpu 1 but patch changes cpu0. Where are the values of the
>> other CPUs?
>
> Small cpu on 8173 is cpu0 & cpu1, while big cpu is cpu2 & cpu3.
> Small cpu: 9502 DMIPS @ 1703 Mhz
> Big cpu: 16250 DMIPS @ 2106 Mhz
>
> 9502/1703 : 16250/2106 = 740 : 1024 (scale big cpu to 1024), and this patch
> changes the small cpu value to 740.
>
>
applied to v5.8-next/dts64
Thanks!
>
>>
>> Regards,
>> Matthias
>>
>>>
>>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index 70b1ffcab7f0..5e046f9d48ce 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -167,7 +167,7 @@ cpu0: cpu@0 {
>>> <&apmixedsys CLK_APMIXED_MAINPLL>;
>>> clock-names = "cpu", "intermediate";
>>> operating-points-v2 = <&cluster0_opp>;
>>> - capacity-dmips-mhz = <526>;
>>> + capacity-dmips-mhz = <740>;
>>> };
>>>
>>> cpu1: cpu@1 {
>>> @@ -182,7 +182,7 @@ cpu1: cpu@1 {
>>> <&apmixedsys CLK_APMIXED_MAINPLL>;
>>> clock-names = "cpu", "intermediate";
>>> operating-points-v2 = <&cluster0_opp>;
>>> - capacity-dmips-mhz = <526>;
>>> + capacity-dmips-mhz = <740>;
>>> };
>>>
>>> cpu2: cpu@100 {
>>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-10 13:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 8:37 [PATCH] arm64: dts: mt8173: Re-measure capacity-dmips-mhz Hsin-Yi Wang
2020-07-08 17:01 ` Matthias Brugger
2020-07-08 18:55 ` Hsin-Yi Wang
2020-07-10 13:34 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).