* [PATCH v2 0/2] arm64: dts: imx8mq: Add eLCDIF controller
@ 2019-11-25 14:50 Guido Günther
2019-11-25 14:50 ` [PATCH v2 1/2] dt-bindings: mxsfb: Add compatible for iMX8MQ Guido Günther
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Guido Günther @ 2019-11-25 14:50 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Lucas Stach, Anson Huang, Abel Vesa, Guido Günther,
Andrey Smirnov, Carlo Caione, Angus Ainslie (Purism),
devicetree, linux-arm-kernel, linux-kernel
With some minimal support on imx8mq we might as well add it to the DT
Changes from v1:
- Per review comments by Fabio Estevam
- Document compatible
- use lcd-controller instead of lcdif as node name
- Add Reviewed-by: from Fabio Estevam, thanks!
Guido Günther (2):
dt-bindings: mxsfb: Add compatible for iMX8MQ
arm64: dts: imx8mq: Add eLCDIF controller
.../devicetree/bindings/display/mxsfb.txt | 1 +
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 17 +++++++++++++++++
2 files changed, 18 insertions(+)
--
2.23.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] dt-bindings: mxsfb: Add compatible for iMX8MQ
2019-11-25 14:50 [PATCH v2 0/2] arm64: dts: imx8mq: Add eLCDIF controller Guido Günther
@ 2019-11-25 14:50 ` Guido Günther
2019-11-25 16:12 ` Fabio Estevam
2019-12-05 18:18 ` Rob Herring
2019-11-25 14:50 ` [PATCH v2 2/2] arm64: dts: imx8mq: Add eLCDIF controller Guido Günther
2019-12-09 7:13 ` [PATCH v2 0/2] " Shawn Guo
2 siblings, 2 replies; 6+ messages in thread
From: Guido Günther @ 2019-11-25 14:50 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Lucas Stach, Anson Huang, Abel Vesa, Guido Günther,
Andrey Smirnov, Carlo Caione, Angus Ainslie (Purism),
devicetree, linux-arm-kernel, linux-kernel
NXP's iMX8MQ has an LCDIF as well.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
Documentation/devicetree/bindings/display/mxsfb.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt
index 472e1ea6c591..c985871c46b3 100644
--- a/Documentation/devicetree/bindings/display/mxsfb.txt
+++ b/Documentation/devicetree/bindings/display/mxsfb.txt
@@ -6,6 +6,7 @@ Required properties:
- compatible: Should be "fsl,imx23-lcdif" for i.MX23.
Should be "fsl,imx28-lcdif" for i.MX28.
Should be "fsl,imx6sx-lcdif" for i.MX6SX.
+ Should be "fsl,imx8mq-lcdif" for i.MX8MQ.
- reg: Address and length of the register set for LCDIF
- interrupts: Should contain LCDIF interrupt
- clocks: A list of phandle + clock-specifier pairs, one for each
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] arm64: dts: imx8mq: Add eLCDIF controller
2019-11-25 14:50 [PATCH v2 0/2] arm64: dts: imx8mq: Add eLCDIF controller Guido Günther
2019-11-25 14:50 ` [PATCH v2 1/2] dt-bindings: mxsfb: Add compatible for iMX8MQ Guido Günther
@ 2019-11-25 14:50 ` Guido Günther
2019-12-09 7:13 ` [PATCH v2 0/2] " Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Guido Günther @ 2019-11-25 14:50 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Lucas Stach, Anson Huang, Abel Vesa, Guido Günther,
Andrey Smirnov, Carlo Caione, Angus Ainslie (Purism),
devicetree, linux-arm-kernel, linux-kernel
Add a node for the eLCDIF controller, "disabled" by default.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 7f9319452b58..1fadd2b126a9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -448,6 +448,23 @@
fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin";
};
+ lcdif: lcd-controller@30320000 {
+ compatible = "fsl,imx8mq-lcdif", "fsl,imx28-lcdif";
+ reg = <0x30320000 0x10000>;
+ interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MQ_CLK_LCDIF_PIXEL>;
+ clock-names = "pix";
+ assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
+ <&clk IMX8MQ_VIDEO_PLL1_BYPASS>,
+ <&clk IMX8MQ_CLK_LCDIF_PIXEL>,
+ <&clk IMX8MQ_VIDEO_PLL1>;
+ assigned-clock-parents = <&clk IMX8MQ_CLK_25M>,
+ <&clk IMX8MQ_VIDEO_PLL1>,
+ <&clk IMX8MQ_VIDEO_PLL1_OUT>;
+ assigned-clock-rates = <0>, <0>, <0>, <594000000>;
+ status = "disabled";
+ };
+
iomuxc: iomuxc@30330000 {
compatible = "fsl,imx8mq-iomuxc";
reg = <0x30330000 0x10000>;
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mxsfb: Add compatible for iMX8MQ
2019-11-25 14:50 ` [PATCH v2 1/2] dt-bindings: mxsfb: Add compatible for iMX8MQ Guido Günther
@ 2019-11-25 16:12 ` Fabio Estevam
2019-12-05 18:18 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-11-25 16:12 UTC (permalink / raw)
To: Guido Günther
Cc: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, NXP Linux Team, Lucas Stach,
Anson Huang, Abel Vesa, Andrey Smirnov, Carlo Caione,
Angus Ainslie (Purism),
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
On Mon, Nov 25, 2019 at 11:50 AM Guido Günther <agx@sigxcpu.org> wrote:
>
> NXP's iMX8MQ has an LCDIF as well.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mxsfb: Add compatible for iMX8MQ
2019-11-25 14:50 ` [PATCH v2 1/2] dt-bindings: mxsfb: Add compatible for iMX8MQ Guido Günther
2019-11-25 16:12 ` Fabio Estevam
@ 2019-12-05 18:18 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2019-12-05 18:18 UTC (permalink / raw)
To: Guido Günther
Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Lucas Stach, Anson Huang, Abel Vesa,
Guido Günther, Andrey Smirnov, Carlo Caione,
Angus Ainslie (Purism),
devicetree, linux-arm-kernel, linux-kernel
On Mon, 25 Nov 2019 15:50:06 +0100, =?UTF-8?q?Guido=20G=C3=BCnther?= wrote:
> NXP's iMX8MQ has an LCDIF as well.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> Documentation/devicetree/bindings/display/mxsfb.txt | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/2] arm64: dts: imx8mq: Add eLCDIF controller
2019-11-25 14:50 [PATCH v2 0/2] arm64: dts: imx8mq: Add eLCDIF controller Guido Günther
2019-11-25 14:50 ` [PATCH v2 1/2] dt-bindings: mxsfb: Add compatible for iMX8MQ Guido Günther
2019-11-25 14:50 ` [PATCH v2 2/2] arm64: dts: imx8mq: Add eLCDIF controller Guido Günther
@ 2019-12-09 7:13 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2019-12-09 7:13 UTC (permalink / raw)
To: Guido Günther
Cc: Rob Herring, Mark Rutland, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Lucas Stach, Anson Huang,
Abel Vesa, Andrey Smirnov, Carlo Caione, Angus Ainslie (Purism),
devicetree, linux-arm-kernel, linux-kernel
On Mon, Nov 25, 2019 at 03:50:05PM +0100, Guido Günther wrote:
> With some minimal support on imx8mq we might as well add it to the DT
>
> Changes from v1:
> - Per review comments by Fabio Estevam
> - Document compatible
> - use lcd-controller instead of lcdif as node name
> - Add Reviewed-by: from Fabio Estevam, thanks!
>
> Guido Günther (2):
> dt-bindings: mxsfb: Add compatible for iMX8MQ
> arm64: dts: imx8mq: Add eLCDIF controller
Applied both, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-09 7:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 14:50 [PATCH v2 0/2] arm64: dts: imx8mq: Add eLCDIF controller Guido Günther
2019-11-25 14:50 ` [PATCH v2 1/2] dt-bindings: mxsfb: Add compatible for iMX8MQ Guido Günther
2019-11-25 16:12 ` Fabio Estevam
2019-12-05 18:18 ` Rob Herring
2019-11-25 14:50 ` [PATCH v2 2/2] arm64: dts: imx8mq: Add eLCDIF controller Guido Günther
2019-12-09 7:13 ` [PATCH v2 0/2] " Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).