devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	agross@kernel.org, bjorn.andersson@linaro.org,
	jassisinghbrar@gmail.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries
Date: Thu, 30 Jun 2022 20:37:43 +0200	[thread overview]
Message-ID: <7824e14b-89fb-a816-441d-012d76def59a@linaro.org> (raw)
In-Reply-To: <20220630043536.3308546-2-bryan.odonoghue@linaro.org>

On 30/06/2022 06:35, Bryan O'Donoghue wrote:
> msm8916, msm8939, msm8953, msm8994 and qcs404 already declare or should
> declare syscon as they have drivers that use syscon inside of the apcs-kpss
> block.
> 
> grep apcs arch/arm64/boot/dts/qcom/* | grep syscon
> 
> Add in the additional syscon in the documentation for the above mentioned
> parts.

Subject should have prefix:
dt-bindings: mailbox: qcom,apcs-kpss-global:

> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../mailbox/qcom,apcs-kpss-global.yaml        | 44 ++++++++++---------
>  1 file changed, 24 insertions(+), 20 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> index 3b5ba7ecc19d9..f342494fd6108 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> @@ -15,26 +15,30 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,ipq6018-apcs-apps-global
> -      - qcom,ipq8074-apcs-apps-global
> -      - qcom,msm8916-apcs-kpss-global
> -      - qcom,msm8939-apcs-kpss-global
> -      - qcom,msm8953-apcs-kpss-global
> -      - qcom,msm8976-apcs-kpss-global
> -      - qcom,msm8994-apcs-kpss-global
> -      - qcom,msm8996-apcs-hmss-global
> -      - qcom,msm8998-apcs-hmss-global
> -      - qcom,qcm2290-apcs-hmss-global
> -      - qcom,qcs404-apcs-apps-global
> -      - qcom,sc7180-apss-shared
> -      - qcom,sc8180x-apss-shared
> -      - qcom,sdm660-apcs-hmss-global
> -      - qcom,sdm845-apss-shared
> -      - qcom,sm6125-apcs-hmss-global
> -      - qcom,sm6115-apcs-hmss-global
> -      - qcom,sm8150-apss-shared
> -
> +    oneOf:
> +      - items:
> +          - enum:
> +              - qcom,ipq6018-apcs-apps-global
> +              - qcom,ipq8074-apcs-apps-global
> +              - qcom,msm8976-apcs-kpss-global
> +              - qcom,msm8996-apcs-hmss-global
> +              - qcom,msm8998-apcs-hmss-global
> +              - qcom,qcm2290-apcs-hmss-global
> +              - qcom,sc7180-apss-shared
> +              - qcom,sc8180x-apss-shared
> +              - qcom,sdm660-apcs-hmss-global
> +              - qcom,sdm845-apss-shared
> +              - qcom,sm6125-apcs-hmss-global
> +              - qcom,sm6115-apcs-hmss-global
> +              - qcom,sm8150-apss-shared

These are not items, but one item, so enum directly under oneOf.

> +      - items:
> +          - enum:
> +              - qcom,msm8916-apcs-kpss-global
> +              - qcom,msm8939-apcs-kpss-global
> +              - qcom,msm8953-apcs-kpss-global
> +              - qcom,msm8994-apcs-kpss-global
> +              - qcom,qcs404-apcs-apps-global
> +          - const: syscon
>    reg:
>      maxItems: 1
>  


Best regards,
Krzysztof

  parent reply	other threads:[~2022-06-30 18:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30  4:35 [PATCH 0/2] Two apcs-kpss-global.yaml fixes Bryan O'Donoghue
2022-06-30  4:35 ` [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries Bryan O'Donoghue
2022-06-30 13:44   ` Rob Herring
2022-06-30 13:51     ` Bryan O'Donoghue
2022-06-30 18:37   ` Krzysztof Kozlowski [this message]
2022-06-30  4:35 ` [PATCH 2/2] dt-bindings: mailbox: qcom: Add clock-output-names Bryan O'Donoghue
2022-06-30 13:44   ` Rob Herring
2022-06-30 18:38   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7824e14b-89fb-a816-441d-012d76def59a@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).