devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] add Meson8/Meson8b serial core clock handling
@ 2017-10-28 12:34 Martin Blumenstingl
       [not found] ` <20171028123430.7796-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Martin Blumenstingl @ 2017-10-28 12:34 UTC (permalink / raw)
  To: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	khilman-rdvid1DuHRBWk0Htik3J/w, carlo-KA+7E9HrN00dnm+yROfE0A
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	narmstrong-rdvid1DuHRBWk0Htik3J/w,
	hgkr.klein-Re5JQEeQqe8AvxtiuMwx3w, Martin Blumenstingl

This patchset adds the tty/serial core clock handling to the UARTs
on Meson8 and Meson8b.

Basically this is the Meson8 and Meson8b version of a patchset from
Helmut Klein and Neil Armstrong, who implemented this for Meson GX
(see [0]). Back then I asked Neil to drop Meson8b from his patchset
because I was working on the Meson8 clock controller at that time.

This also removes the last users that rely on the "amlogic,meson-uart"
binding. Removing that binding from the meson_uart driver is not part
of this series though.


[0] http://lists.infradead.org/pipermail/linux-amlogic/2017-June/004173.html

Martin Blumenstingl (2):
  ARM: dts: meson8: use stable UART bindings with correct gate clock
  ARM: dts: meson8b: use stable UART bindings with correct gate clock

 arch/arm/boot/dts/meson8.dtsi  | 16 ++++++++++++----
 arch/arm/boot/dts/meson8b.dtsi | 16 ++++++++++++----
 2 files changed, 24 insertions(+), 8 deletions(-)

-- 
2.14.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] ARM: dts: meson8: use stable UART bindings with correct gate clock
       [not found] ` <20171028123430.7796-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
@ 2017-10-28 12:34   ` Martin Blumenstingl
  2017-10-28 12:34   ` [PATCH 2/2] ARM: dts: meson8b: " Martin Blumenstingl
  2017-10-31 10:20   ` [PATCH 0/2] add Meson8/Meson8b serial core clock handling Jerome Brunet
  2 siblings, 0 replies; 5+ messages in thread
From: Martin Blumenstingl @ 2017-10-28 12:34 UTC (permalink / raw)
  To: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	khilman-rdvid1DuHRBWk0Htik3J/w, carlo-KA+7E9HrN00dnm+yROfE0A
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	narmstrong-rdvid1DuHRBWk0Htik3J/w,
	hgkr.klein-Re5JQEeQqe8AvxtiuMwx3w, Martin Blumenstingl

Switch to the stable UART bindings and add the correct gate clocks
to the non-AO UART nodes.
This fixes the non-AO UARTs if the bootloader didn't un-gate the clocks.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
---
 arch/arm/boot/dts/meson8.dtsi | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
index 661287806ead..eb3f8161eef0 100644
--- a/arch/arm/boot/dts/meson8.dtsi
+++ b/arch/arm/boot/dts/meson8.dtsi
@@ -337,19 +337,27 @@
 };
 
 &uart_AO {
-	clocks = <&clkc CLKID_CLK81>;
+	compatible = "amlogic,meson8-uart", "amlogic,meson-uart";
+	clocks = <&clkc CLKID_XTAL>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
+	clock-names = "xtal", "pclk", "baud";
 };
 
 &uart_A {
-	clocks = <&clkc CLKID_CLK81>;
+	compatible = "amlogic,meson8-uart", "amlogic,meson-uart";
+	clocks = <&clkc CLKID_XTAL>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>;
+	clock-names = "xtal", "pclk", "baud";
 };
 
 &uart_B {
-	clocks = <&clkc CLKID_CLK81>;
+	compatible = "amlogic,meson8-uart", "amlogic,meson-uart";
+	clocks = <&clkc CLKID_XTAL>, <&clkc CLKID_UART1>, <&clkc CLKID_CLK81>;
+	clock-names = "xtal", "pclk", "baud";
 };
 
 &uart_C {
-	clocks = <&clkc CLKID_CLK81>;
+	compatible = "amlogic,meson8-uart", "amlogic,meson-uart";
+	clocks = <&clkc CLKID_XTAL>, <&clkc CLKID_UART2>, <&clkc CLKID_CLK81>;
+	clock-names = "xtal", "pclk", "baud";
 };
 
 &usb0 {
-- 
2.14.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ARM: dts: meson8b: use stable UART bindings with correct gate clock
       [not found] ` <20171028123430.7796-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
  2017-10-28 12:34   ` [PATCH 1/2] ARM: dts: meson8: use stable UART bindings with correct gate clock Martin Blumenstingl
@ 2017-10-28 12:34   ` Martin Blumenstingl
  2017-10-31 10:20   ` [PATCH 0/2] add Meson8/Meson8b serial core clock handling Jerome Brunet
  2 siblings, 0 replies; 5+ messages in thread
From: Martin Blumenstingl @ 2017-10-28 12:34 UTC (permalink / raw)
  To: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	khilman-rdvid1DuHRBWk0Htik3J/w, carlo-KA+7E9HrN00dnm+yROfE0A
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	narmstrong-rdvid1DuHRBWk0Htik3J/w,
	hgkr.klein-Re5JQEeQqe8AvxtiuMwx3w, Martin Blumenstingl

Switch to the stable UART bindings and add the correct gate clocks
to the non-AO UART nodes.
This fixes the non-AO UARTs if the bootloader didn't un-gate the clocks.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
---
 arch/arm/boot/dts/meson8b.dtsi | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
index 15ed84441d8d..070a28ec293f 100644
--- a/arch/arm/boot/dts/meson8b.dtsi
+++ b/arch/arm/boot/dts/meson8b.dtsi
@@ -242,19 +242,27 @@
 };
 
 &uart_AO {
-	clocks = <&clkc CLKID_CLK81>;
+	compatible = "amlogic,meson8b-uart", "amlogic,meson-uart";
+	clocks = <&clkc CLKID_XTAL>, <&clkc CLKID_CLK81>, <&clkc CLKID_CLK81>;
+	clock-names = "xtal", "pclk", "baud";
 };
 
 &uart_A {
-	clocks = <&clkc CLKID_CLK81>;
+	compatible = "amlogic,meson8b-uart", "amlogic,meson-uart";
+	clocks = <&clkc CLKID_XTAL>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>;
+	clock-names = "xtal", "pclk", "baud";
 };
 
 &uart_B {
-	clocks = <&clkc CLKID_CLK81>;
+	compatible = "amlogic,meson8b-uart", "amlogic,meson-uart";
+	clocks = <&clkc CLKID_XTAL>, <&clkc CLKID_UART1>, <&clkc CLKID_CLK81>;
+	clock-names = "xtal", "pclk", "baud";
 };
 
 &uart_C {
-	clocks = <&clkc CLKID_CLK81>;
+	compatible = "amlogic,meson8b-uart", "amlogic,meson-uart";
+	clocks = <&clkc CLKID_XTAL>, <&clkc CLKID_UART2>, <&clkc CLKID_CLK81>;
+	clock-names = "xtal", "pclk", "baud";
 };
 
 &usb0 {
-- 
2.14.3

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] add Meson8/Meson8b serial core clock handling
       [not found] ` <20171028123430.7796-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
  2017-10-28 12:34   ` [PATCH 1/2] ARM: dts: meson8: use stable UART bindings with correct gate clock Martin Blumenstingl
  2017-10-28 12:34   ` [PATCH 2/2] ARM: dts: meson8b: " Martin Blumenstingl
@ 2017-10-31 10:20   ` Jerome Brunet
       [not found]     ` <1509445230.13838.26.camel-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
  2 siblings, 1 reply; 5+ messages in thread
From: Jerome Brunet @ 2017-10-31 10:20 UTC (permalink / raw)
  To: Martin Blumenstingl,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	khilman-rdvid1DuHRBWk0Htik3J/w, carlo-KA+7E9HrN00dnm+yROfE0A
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	hgkr.klein-Re5JQEeQqe8AvxtiuMwx3w,
	narmstrong-rdvid1DuHRBWk0Htik3J/w

On Sat, 2017-10-28 at 14:34 +0200, Martin Blumenstingl wrote:
> This patchset adds the tty/serial core clock handling to the UARTs
> on Meson8 and Meson8b.
> 
> Basically this is the Meson8 and Meson8b version of a patchset from
> Helmut Klein and Neil Armstrong, who implemented this for Meson GX
> (see [0]). Back then I asked Neil to drop Meson8b from his patchset
> because I was working on the Meson8 clock controller at that time.
> 
> This also removes the last users that rely on the "amlogic,meson-uart"
> binding. Removing that binding from the meson_uart driver is not part
> of this series though.
> 
> 
> [0] http://lists.infradead.org/pipermail/linux-amlogic/2017-June/004173.html
> 

Acked-by: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

> Martin Blumenstingl (2):
>   ARM: dts: meson8: use stable UART bindings with correct gate clock
>   ARM: dts: meson8b: use stable UART bindings with correct gate clock
> 
>  arch/arm/boot/dts/meson8.dtsi  | 16 ++++++++++++----
>  arch/arm/boot/dts/meson8b.dtsi | 16 ++++++++++++----
>  2 files changed, 24 insertions(+), 8 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] add Meson8/Meson8b serial core clock handling
       [not found]     ` <1509445230.13838.26.camel-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
@ 2017-12-06 19:36       ` Kevin Hilman
  0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2017-12-06 19:36 UTC (permalink / raw)
  To: Jerome Brunet
  Cc: Martin Blumenstingl,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	carlo-KA+7E9HrN00dnm+yROfE0A, devicetree-u79uwXL29TY76Z2rM5mHXA,
	hgkr.klein-Re5JQEeQqe8AvxtiuMwx3w,
	narmstrong-rdvid1DuHRBWk0Htik3J/w

Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> writes:

> On Sat, 2017-10-28 at 14:34 +0200, Martin Blumenstingl wrote:
>> This patchset adds the tty/serial core clock handling to the UARTs
>> on Meson8 and Meson8b.
>> 
>> Basically this is the Meson8 and Meson8b version of a patchset from
>> Helmut Klein and Neil Armstrong, who implemented this for Meson GX
>> (see [0]). Back then I asked Neil to drop Meson8b from his patchset
>> because I was working on the Meson8 clock controller at that time.
>> 
>> This also removes the last users that rely on the "amlogic,meson-uart"
>> binding. Removing that binding from the meson_uart driver is not part
>> of this series though.
>> 
>> 
>> [0] http://lists.infradead.org/pipermail/linux-amlogic/2017-June/004173.html
>> 
>
> Acked-by: Jerome Brunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

Applied to v4.16/dt with Jerome's ack.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-12-06 19:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-28 12:34 [PATCH 0/2] add Meson8/Meson8b serial core clock handling Martin Blumenstingl
     [not found] ` <20171028123430.7796-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2017-10-28 12:34   ` [PATCH 1/2] ARM: dts: meson8: use stable UART bindings with correct gate clock Martin Blumenstingl
2017-10-28 12:34   ` [PATCH 2/2] ARM: dts: meson8b: " Martin Blumenstingl
2017-10-31 10:20   ` [PATCH 0/2] add Meson8/Meson8b serial core clock handling Jerome Brunet
     [not found]     ` <1509445230.13838.26.camel-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-12-06 19:36       ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).