devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/4] Add basic support for Mediatek MT8173 SoC
@ 2014-12-17 14:17 Eddie Huang
  2014-12-17 14:17 ` [PATCH v2 1/4] Document: DT: Add bindings for mediatek MT8173 Soc Platform Eddie Huang
                   ` (4 more replies)
  0 siblings, 5 replies; 16+ messages in thread
From: Eddie Huang @ 2014-12-17 14:17 UTC (permalink / raw)
  To: Matthias Brugger, Rob Herring, Jason Cooper
  Cc: Mark Rutland, devicetree, srv_heupstream, Pawel Moll,
	Ian Campbell, Catalin Marinas, Mark Brown, Will Deacon,
	linux-kernel, Robert Richter, Sascha Hauer, Kumar Gala,
	Olof Johansson, Joe.C, Thomas Gleixner, Eddie Huang,
	linux-arm-kernel

MT8173 is a SoC based on 64bit ARMv8 architecture. It contains 2 CA53 + 2 CA57 cores. MT8173 share many HW IP with MT8135 and other MT65xx series. This patchset was tested on MT8173 engineer sample, and boot to shell ok.

This series contains document bindings, device tree, defconfig, and one sysirq modification for MT8173.

Changes in v2:

1. Modify mt8173.dtsi and mt8173-evb.dts according to Mark Rutland's comment, change cpu-maps, psci, clock, GIC properties.
2. Modify irq-mtk-sysirq.c according to Arnd Bergmann's comment to calculate irq number from reg range.

This series is based on 3.18, and Joe's MT8135 basic support patch [1] and sysirq patch [2]

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/296093.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/310335.html

Eddie Huang (3):
  Document: DT: Add bindings for mediatek MT8173 Soc Platform
  arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and
    Makefile
  arm64: mediatek: Add MT8173 SoC Kconfig and defconfig

Yingjoe Chen (1):
  irqchip: mtk-sysirq: Get irq number from register resource size

 Documentation/devicetree/bindings/arm/mediatek.txt |   4 +
 arch/arm64/Kconfig                                 |   6 +
 arch/arm64/boot/dts/Makefile                       |   1 +
 arch/arm64/boot/dts/mt8173-evb.dts                 |  34 +++++
 arch/arm64/boot/dts/mt8173.dtsi                    | 152 +++++++++++++++++++++
 arch/arm64/configs/defconfig                       |   2 +
 drivers/irqchip/irq-mtk-sysirq.c                   |  18 ++-
 7 files changed, 210 insertions(+), 7 deletions(-)
 create mode 100644 arch/arm64/boot/dts/mt8173-evb.dts
 create mode 100644 arch/arm64/boot/dts/mt8173.dtsi

--
1.8.1.1.dirty

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH v2 1/4] Document: DT: Add bindings for mediatek MT8173 Soc Platform
  2014-12-17 14:17 [PATCH v2 0/4] Add basic support for Mediatek MT8173 SoC Eddie Huang
@ 2014-12-17 14:17 ` Eddie Huang
  2014-12-17 14:17 ` [PATCH v2 2/4] irqchip: mtk-sysirq: Get irq number from register resource size Eddie Huang
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 16+ messages in thread
From: Eddie Huang @ 2014-12-17 14:17 UTC (permalink / raw)
  To: Matthias Brugger, Rob Herring, Jason Cooper
  Cc: Mark Rutland, devicetree, srv_heupstream, Pawel Moll,
	Ian Campbell, Catalin Marinas, Mark Brown, Will Deacon,
	linux-kernel, Robert Richter, Sascha Hauer, Kumar Gala,
	Olof Johansson, Joe.C, Thomas Gleixner, Eddie Huang,
	linux-arm-kernel

Add the devicetree binding document for mediatek MT8173 SoC.
This is a 64-bit four core Soc.
And mt8173-evb is a evaluation board based on mt8173.

Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
---
 Documentation/devicetree/bindings/arm/mediatek.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek.txt b/Documentation/devicetree/bindings/arm/mediatek.txt
index 1ca713e..622c5d9 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.txt
+++ b/Documentation/devicetree/bindings/arm/mediatek.txt
@@ -8,6 +8,7 @@ compatible: Must contain one of
    "mediatek,mt6589"
    "mediatek,mt8127"
    "mediatek,mt8135"
+   "mediatek,mt8173"
 
 
 Supported boards:
@@ -21,3 +22,6 @@ Supported boards:
 - MTK mt8135 tablet EVB:
     Required root node properties:
       - compatible = "mediatek,mt8135-evbp1", "mediatek,mt8135";
+- MTK mt8173 tablet EVB:
+    Required root node properties:
+      - compatible = "mediatek,mt8173-evb", "mediatek,mt8173";
-- 
1.8.1.1.dirty

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2 2/4] irqchip: mtk-sysirq: Get irq number from register resource size
  2014-12-17 14:17 [PATCH v2 0/4] Add basic support for Mediatek MT8173 SoC Eddie Huang
  2014-12-17 14:17 ` [PATCH v2 1/4] Document: DT: Add bindings for mediatek MT8173 Soc Platform Eddie Huang
@ 2014-12-17 14:17 ` Eddie Huang
  2014-12-17 14:17 ` [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile Eddie Huang
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 16+ messages in thread
From: Eddie Huang @ 2014-12-17 14:17 UTC (permalink / raw)
  To: Matthias Brugger, Rob Herring, Jason Cooper
  Cc: Mark Rutland, devicetree, srv_heupstream, Pawel Moll,
	Ian Campbell, Catalin Marinas, Mark Brown, Will Deacon,
	linux-kernel, Robert Richter, Sascha Hauer, Kumar Gala,
	Olof Johansson, Joe.C, Thomas Gleixner, Eddie Huang,
	linux-arm-kernel

From: Yingjoe Chen <yingjoe.chen@mediatek.com>

Originally mtk-sysirq hardcoded supported irq number to 224. This
was fine since all SoCs before support the same number of irqs for
intpol.

However MT8173 intpol support 32 more irq pins, changes to get
irq number from register resource size to suppor MT8173 properly.

Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
---
 drivers/irqchip/irq-mtk-sysirq.c | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c
index 0b0d2c0..fadd865 100644
--- a/drivers/irqchip/irq-mtk-sysirq.c
+++ b/drivers/irqchip/irq-mtk-sysirq.c
@@ -23,8 +23,6 @@
 
 #include "irqchip.h"
 
-#define MT6577_SYS_INTPOL_NUM	(224)
-
 struct mtk_sysirq_chip_data {
 	spinlock_t lock;
 	void __iomem *intpol_base;
@@ -124,7 +122,8 @@ static int __init mtk_sysirq_of_init(struct device_node *node,
 {
 	struct irq_domain *domain, *domain_parent;
 	struct mtk_sysirq_chip_data *chip_data;
-	int ret = 0;
+	struct resource res;
+	int ret, size, intpol_num;
 
 	domain_parent = irq_find_host(parent);
 	if (!domain_parent) {
@@ -132,19 +131,24 @@ static int __init mtk_sysirq_of_init(struct device_node *node,
 		return -EINVAL;
 	}
 
+	ret = of_address_to_resource(node, 0, &res);
+	if (ret)
+		return ret;
+
 	chip_data = kzalloc(sizeof(*chip_data), GFP_KERNEL);
 	if (!chip_data)
 		return -ENOMEM;
 
-	chip_data->intpol_base = of_io_request_and_map(node, 0, "intpol");
-	if (IS_ERR(chip_data->intpol_base)) {
+	size = resource_size(&res);
+	intpol_num = size * 8;
+	chip_data->intpol_base = ioremap(res.start, size);
+	if (!chip_data->intpol_base) {
 		pr_err("mtk_sysirq: unable to map sysirq register\n");
 		ret = PTR_ERR(chip_data->intpol_base);
 		goto out_free;
 	}
 
-	domain = irq_domain_add_hierarchy(domain_parent, 0,
-					  MT6577_SYS_INTPOL_NUM, node,
+	domain = irq_domain_add_hierarchy(domain_parent, 0, intpol_num, node,
 					  &sysirq_domain_ops, chip_data);
 	if (!domain) {
 		ret = -ENOMEM;
-- 
1.8.1.1.dirty

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile
  2014-12-17 14:17 [PATCH v2 0/4] Add basic support for Mediatek MT8173 SoC Eddie Huang
  2014-12-17 14:17 ` [PATCH v2 1/4] Document: DT: Add bindings for mediatek MT8173 Soc Platform Eddie Huang
  2014-12-17 14:17 ` [PATCH v2 2/4] irqchip: mtk-sysirq: Get irq number from register resource size Eddie Huang
@ 2014-12-17 14:17 ` Eddie Huang
       [not found]   ` <1418825853-10934-4-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
  2014-12-17 14:17 ` [PATCH v2 4/4] arm64: mediatek: Add MT8173 SoC Kconfig and defconfig Eddie Huang
       [not found] ` <1418825853-10934-1-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
  4 siblings, 1 reply; 16+ messages in thread
From: Eddie Huang @ 2014-12-17 14:17 UTC (permalink / raw)
  To: Matthias Brugger, Rob Herring, Jason Cooper
  Cc: Mark Rutland, devicetree, srv_heupstream, Pawel Moll,
	Ian Campbell, Catalin Marinas, Mark Brown, Will Deacon,
	linux-kernel, Robert Richter, Sascha Hauer, Kumar Gala,
	Olof Johansson, Joe.C, Thomas Gleixner, Eddie Huang,
	linux-arm-kernel

Add device tree support for MT8173 SoC and evaluation board based on it.

Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
---
 arch/arm64/boot/dts/Makefile       |   1 +
 arch/arm64/boot/dts/mt8173-evb.dts |  34 +++++++++
 arch/arm64/boot/dts/mt8173.dtsi    | 152 +++++++++++++++++++++++++++++++++++++
 3 files changed, 187 insertions(+)
 create mode 100644 arch/arm64/boot/dts/mt8173-evb.dts
 create mode 100644 arch/arm64/boot/dts/mt8173.dtsi

diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile
index f8001a6..db7661e 100644
--- a/arch/arm64/boot/dts/Makefile
+++ b/arch/arm64/boot/dts/Makefile
@@ -1,3 +1,4 @@
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
 dtb-$(CONFIG_ARCH_THUNDER) += thunder-88xx.dtb
 dtb-$(CONFIG_ARCH_VEXPRESS) += rtsm_ve-aemv8a.dtb foundation-v8.dtb
 dtb-$(CONFIG_ARCH_XGENE) += apm-mustang.dtb
diff --git a/arch/arm64/boot/dts/mt8173-evb.dts b/arch/arm64/boot/dts/mt8173-evb.dts
new file mode 100644
index 0000000..b8b2621
--- /dev/null
+++ b/arch/arm64/boot/dts/mt8173-evb.dts
@@ -0,0 +1,34 @@
+/*
+ * Copyright (c) 2014 MediaTek Inc.
+ * Author: Eddie Huang <eddie.huang@mediatek.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/dts-v1/;
+#include "mt8173.dtsi"
+
+/ {
+	model = "mediatek,mt8173-evb";
+
+	aliases {
+		serial0 = &uart0;
+		serial1 = &uart1;
+		serial2 = &uart2;
+		serial3 = &uart3;
+	};
+
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0 0x40000000 0 0x80000000>;
+	};
+
+	chosen { };
+};
diff --git a/arch/arm64/boot/dts/mt8173.dtsi b/arch/arm64/boot/dts/mt8173.dtsi
new file mode 100644
index 0000000..41c1441
--- /dev/null
+++ b/arch/arm64/boot/dts/mt8173.dtsi
@@ -0,0 +1,152 @@
+/*
+ * Copyright (c) 2014 MediaTek Inc.
+ * Author: Eddie Huang <eddie.huang@mediatek.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/ {
+	compatible = "mediatek,mt8173";
+	interrupt-parent = <&sysirq>;
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu-map {
+			cluster0 {
+				core0 {
+					cpu = <&cpu0>;
+				};
+				core1 {
+					cpu = <&cpu1>;
+				};
+			};
+
+			cluster1 {
+				core0 {
+					cpu = <&cpu2>;
+				};
+				core1 {
+					cpu = <&cpu3>;
+				};
+			};
+		};
+
+		cpu0: cpu@0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			reg = <0x000>;
+		};
+
+		cpu1: cpu@1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a53";
+			reg = <0x001>;
+			enable-method = "psci";
+		};
+
+		cpu2: cpu@2 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a57";
+			reg = <0x100>;
+			enable-method = "psci";
+		};
+
+		cpu3: cpu@3 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a57";
+			reg = <0x101>;
+			enable-method = "psci";
+		};
+	};
+
+	psci {
+		compatible = "arm,psci";
+		method = "smc";
+		cpu_suspend   = <0x84000001>;
+		cpu_off	      = <0x84000002>;
+		cpu_on	      = <0x84000003>;
+		affinity_info = <0x84000004>;
+	};
+
+	uart_clk: dummy26m {
+		compatible = "fixed-clock";
+		clock-frequency = <26000000>;
+		#clock-cells = <0>;
+	};
+
+	timer {
+		compatible = "arm,armv8-timer";
+		interrupt-parent = <&gic>;
+		interrupts = <1 13 0xf08>,
+			     <1 14 0xf08>,
+			     <1 11 0xf08>,
+			     <1 10 0xf08>;
+	};
+
+	soc {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		compatible = "simple-bus";
+		ranges;
+
+		sysirq: intpol-controller@10200620 {
+			compatible = "mediatek,mt8173-sysirq", "mediatek,mt6577-sysirq";
+			interrupt-controller;
+			#interrupt-cells = <3>;
+			interrupt-parent = <&gic>;
+			reg = <0 0x10200620 0 0x20>;
+		};
+
+		gic: interrupt-controller@10220000 {
+			compatible = "arm,gic-400";
+			#interrupt-cells = <3>;
+			interrupt-parent = <&gic>;
+			interrupt-controller;
+			reg = <0 0x10221000 0 0x1000>,
+			      <0 0x10222000 0 0x1000>,
+			      <0 0x10224000 0 0x2000>,
+			      <0 0x10226000 0 0x2000>;
+			interrupts = <1 9 0xf04>;
+		};
+
+		uart0: serial@11002000 {
+			compatible = "mediatek,mt8173-uart","mediatek,mt6577-uart";
+			reg = <0 0x11002000 0 0x400>;
+			interrupts = <0 83 8>;
+			clocks = <&uart_clk>;
+		};
+
+		uart1: serial@11003000 {
+			compatible = "mediatek,mt8173-uart","mediatek,mt6577-uart";
+			reg = <0 0x11003000 0 0x400>;
+			interrupts = <0 84 8>;
+			clocks = <&uart_clk>;
+		};
+
+		uart2: serial@11004000 {
+			compatible = "mediatek,mt8173-uart","mediatek,mt6577-uart";
+			reg = <0 0x11004000 0 0x400>;
+			interrupts = <0 85 8>;
+			clocks = <&uart_clk>;
+		};
+
+		uart3: serial@11005000 {
+			compatible = "mediatek,mt8173-uart","mediatek,mt6577-uart";
+			reg = <0 0x11005000 0 0x400>;
+			interrupts = <0 86 8>;
+			clocks = <&uart_clk>;
+		};
+	};
+
+};
+
-- 
1.8.1.1.dirty

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH v2 4/4] arm64: mediatek: Add MT8173 SoC Kconfig and defconfig
  2014-12-17 14:17 [PATCH v2 0/4] Add basic support for Mediatek MT8173 SoC Eddie Huang
                   ` (2 preceding siblings ...)
  2014-12-17 14:17 ` [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile Eddie Huang
@ 2014-12-17 14:17 ` Eddie Huang
       [not found] ` <1418825853-10934-1-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
  4 siblings, 0 replies; 16+ messages in thread
From: Eddie Huang @ 2014-12-17 14:17 UTC (permalink / raw)
  To: Matthias Brugger, Rob Herring, Jason Cooper
  Cc: Mark Rutland, devicetree, srv_heupstream, Pawel Moll,
	Ian Campbell, Catalin Marinas, Mark Brown, Will Deacon,
	linux-kernel, Robert Richter, Sascha Hauer, Kumar Gala,
	Olof Johansson, Joe.C, Thomas Gleixner, Eddie Huang,
	linux-arm-kernel

Add MT8173 arm64 Kconfig and defconfig files

Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
---
 arch/arm64/Kconfig           | 6 ++++++
 arch/arm64/configs/defconfig | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 9532f8d..85fd1ca 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -142,6 +142,12 @@ source "kernel/Kconfig.freezer"
 
 menu "Platform selection"
 
+config ARCH_MEDIATEK
+	bool "Mediatek MT65xx & MT81xx ARMv8 SoC"
+	select ARM_GIC
+	help
+	  Support for Mediatek MT65xx & MT81xx ARMv8 SoCs
+
 config ARCH_THUNDER
 	bool "Cavium Inc. Thunder SoC Family"
 	help
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index dd301be..ed84d21 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -32,6 +32,7 @@ CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
 # CONFIG_BLK_DEV_BSG is not set
 # CONFIG_IOSCHED_DEADLINE is not set
+CONFIG_ARCH_MEDIATEK=y
 CONFIG_ARCH_THUNDER=y
 CONFIG_ARCH_VEXPRESS=y
 CONFIG_ARCH_XGENE=y
@@ -87,6 +88,7 @@ CONFIG_SERIO_AMBAKMI=y
 CONFIG_LEGACY_PTY_COUNT=16
 CONFIG_SERIAL_8250=y
 CONFIG_SERIAL_8250_CONSOLE=y
+CONFIG_SERIAL_8250_MT6577=y
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
 CONFIG_SERIAL_OF_PLATFORM=y
-- 
1.8.1.1.dirty

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile
       [not found]   ` <1418825853-10934-4-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2014-12-17 14:33     ` Mark Rutland
  2014-12-17 15:01       ` Marc Zyngier
  2014-12-23  7:30       ` Eddie Huang
  0 siblings, 2 replies; 16+ messages in thread
From: Mark Rutland @ 2014-12-17 14:33 UTC (permalink / raw)
  To: Eddie Huang, marc.zyngier-5wv7dgnIgG8
  Cc: Matthias Brugger, Rob Herring, Jason Cooper,
	srv_heupstream-NuS5LvNUpcJWk0Htik3J/w, Pawel Moll, Ian Campbell,
	Kumar Gala, Catalin Marinas, Will Deacon, Thomas Gleixner,
	Olof Johansson, Joe.C, Robert Richter, Mark Brown,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Sascha Hauer

On Wed, Dec 17, 2014 at 02:17:32PM +0000, Eddie Huang wrote:
> Add device tree support for MT8173 SoC and evaluation board based on it.
> 
> Signed-off-by: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
>  arch/arm64/boot/dts/Makefile       |   1 +
>  arch/arm64/boot/dts/mt8173-evb.dts |  34 +++++++++
>  arch/arm64/boot/dts/mt8173.dtsi    | 152 +++++++++++++++++++++++++++++++++++++
>  3 files changed, 187 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mt8173-evb.dts
>  create mode 100644 arch/arm64/boot/dts/mt8173.dtsi
> 
> diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile
> index f8001a6..db7661e 100644
> --- a/arch/arm64/boot/dts/Makefile
> +++ b/arch/arm64/boot/dts/Makefile
> @@ -1,3 +1,4 @@
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
>  dtb-$(CONFIG_ARCH_THUNDER) += thunder-88xx.dtb
>  dtb-$(CONFIG_ARCH_VEXPRESS) += rtsm_ve-aemv8a.dtb foundation-v8.dtb
>  dtb-$(CONFIG_ARCH_XGENE) += apm-mustang.dtb
> diff --git a/arch/arm64/boot/dts/mt8173-evb.dts b/arch/arm64/boot/dts/mt8173-evb.dts
> new file mode 100644
> index 0000000..b8b2621
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mt8173-evb.dts
> @@ -0,0 +1,34 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +/dts-v1/;
> +#include "mt8173.dtsi"
> +
> +/ {
> +	model = "mediatek,mt8173-evb";
> +
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +		serial3 = &uart3;
> +	};
> +
> +	memory@40000000 {
> +		device_type = "memory";
> +		reg = <0 0x40000000 0 0x80000000>;
> +	};
> +
> +	chosen { };
> +};
> diff --git a/arch/arm64/boot/dts/mt8173.dtsi b/arch/arm64/boot/dts/mt8173.dtsi
> new file mode 100644
> index 0000000..41c1441
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mt8173.dtsi
> @@ -0,0 +1,152 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +/ {
> +	compatible = "mediatek,mt8173";
> +	interrupt-parent = <&sysirq>;
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	cpus {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		cpu-map {
> +			cluster0 {
> +				core0 {
> +					cpu = <&cpu0>;
> +				};
> +				core1 {
> +					cpu = <&cpu1>;
> +				};
> +			};
> +
> +			cluster1 {
> +				core0 {
> +					cpu = <&cpu2>;
> +				};
> +				core1 {
> +					cpu = <&cpu3>;
> +				};
> +			};
> +		};
> +
> +		cpu0: cpu@0 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a53";
> +			reg = <0x000>;
> +		};
> +
> +		cpu1: cpu@1 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a53";
> +			reg = <0x001>;
> +			enable-method = "psci";
> +		};
> +
> +		cpu2: cpu@2 {

The unit-address should be 100 rather than 2, matching the reg property.
This should be 'cpu@100'.

> +			device_type = "cpu";
> +			compatible = "arm,cortex-a57";
> +			reg = <0x100>;
> +			enable-method = "psci";
> +		};
> +
> +		cpu3: cpu@3 {

Similarly this should be 'cpu@101'.

> +			device_type = "cpu";
> +			compatible = "arm,cortex-a57";
> +			reg = <0x101>;
> +			enable-method = "psci";
> +		};
> +	};
> +
> +	psci {
> +		compatible = "arm,psci";
> +		method = "smc";
> +		cpu_suspend   = <0x84000001>;
> +		cpu_off	      = <0x84000002>;
> +		cpu_on	      = <0x84000003>;
> +		affinity_info = <0x84000004>;
> +	};

There is no AFFINITY_INFO function prior to PSCI 0.2, and
'affinity_info' does not exist in the "arm,psci" binding.

I take it hotplug has been tested for all but CPU0?

> +
> +	uart_clk: dummy26m {
> +		compatible = "fixed-clock";
> +		clock-frequency = <26000000>;
> +		#clock-cells = <0>;
> +	};
> +
> +	timer {
> +		compatible = "arm,armv8-timer";
> +		interrupt-parent = <&gic>;
> +		interrupts = <1 13 0xf08>,
> +			     <1 14 0xf08>,
> +			     <1 11 0xf08>,
> +			     <1 10 0xf08>;
> +	};
> +
> +	soc {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		compatible = "simple-bus";
> +		ranges;
> +
> +		sysirq: intpol-controller@10200620 {
> +			compatible = "mediatek,mt8173-sysirq", "mediatek,mt6577-sysirq";
> +			interrupt-controller;
> +			#interrupt-cells = <3>;
> +			interrupt-parent = <&gic>;
> +			reg = <0 0x10200620 0 0x20>;
> +		};
> +
> +		gic: interrupt-controller@10220000 {
> +			compatible = "arm,gic-400";
> +			#interrupt-cells = <3>;
> +			interrupt-parent = <&gic>;
> +			interrupt-controller;
> +			reg = <0 0x10221000 0 0x1000>,
> +			      <0 0x10222000 0 0x1000>,
> +			      <0 0x10224000 0 0x2000>,
> +			      <0 0x10226000 0 0x2000>;
> +			interrupts = <1 9 0xf04>;
> +		};

I don't think these reg entries are quite right; GICC should be 8k long.

Marc?

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 0/4] Add basic support for Mediatek MT8173 SoC
       [not found] ` <1418825853-10934-1-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2014-12-17 14:35   ` Arnd Bergmann
  0 siblings, 0 replies; 16+ messages in thread
From: Arnd Bergmann @ 2014-12-17 14:35 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: Eddie Huang, Matthias Brugger, Rob Herring, Jason Cooper,
	Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA,
	srv_heupstream-NuS5LvNUpcJWk0Htik3J/w, Pawel Moll, Ian Campbell,
	Catalin Marinas, Mark Brown, Will Deacon,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Robert Richter,
	Sascha Hauer, Kumar Gala, Olof Johansson, Joe.C, Thomas Gleixner

On Wednesday 17 December 2014 22:17:29 Eddie Huang wrote:
> MT8173 is a SoC based on 64bit ARMv8 architecture. It contains 2 CA53 + 2 CA57 cores. MT8173 share many HW IP with MT8135 and other MT65xx series. This patchset was tested on MT8173 engineer sample, and boot to shell ok.
> 
> This series contains document bindings, device tree, defconfig, and one sysirq modification for MT8173.
> 
> Changes in v2:
> 
> 1. Modify mt8173.dtsi and mt8173-evb.dts according to Mark Rutland's comment, change cpu-maps, psci, clock, GIC properties.
> 2. Modify irq-mtk-sysirq.c according to Arnd Bergmann's comment to calculate irq number from reg range.
> 
> 

Looks good to me,

Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>

In the 3.19 merge window, we had a few problems with new arm64 platforms,
as it wasn't entirely clear to us who is a maintainer and whether patches
were sent for review or inclusion. I see no problem including your series
in 3.20, but we probably need to figure out the best process for making
sure we don't miss it.

For now, I'd suggest we do this the same way as the arm32 patches, and
you send them to Matthias for inclusion in his tree, who will then
send a pull request for an arm64 branch.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile
  2014-12-17 14:33     ` Mark Rutland
@ 2014-12-17 15:01       ` Marc Zyngier
       [not found]         ` <54919AC9.2090306-5wv7dgnIgG8@public.gmane.org>
  2014-12-23  7:30       ` Eddie Huang
  1 sibling, 1 reply; 16+ messages in thread
From: Marc Zyngier @ 2014-12-17 15:01 UTC (permalink / raw)
  To: Mark Rutland, Eddie Huang
  Cc: Matthias Brugger, Rob Herring, Jason Cooper,
	srv_heupstream-NuS5LvNUpcJWk0Htik3J/w, Pawel Moll, Ian Campbell,
	Kumar Gala, Catalin Marinas, Will Deacon, Thomas Gleixner,
	Olof Johansson, Joe.C, Robert Richter, Mark Brown,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Sascha Hauer

On 17/12/14 14:33, Mark Rutland wrote:
> On Wed, Dec 17, 2014 at 02:17:32PM +0000, Eddie Huang wrote:
>> Add device tree support for MT8173 SoC and evaluation board based on it.
>>
>> Signed-off-by: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>> ---
>>  arch/arm64/boot/dts/Makefile       |   1 +
>>  arch/arm64/boot/dts/mt8173-evb.dts |  34 +++++++++
>>  arch/arm64/boot/dts/mt8173.dtsi    | 152 +++++++++++++++++++++++++++++++++++++
>>  3 files changed, 187 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/mt8173-evb.dts
>>  create mode 100644 arch/arm64/boot/dts/mt8173.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile
>> index f8001a6..db7661e 100644
>> --- a/arch/arm64/boot/dts/Makefile
>> +++ b/arch/arm64/boot/dts/Makefile
>> @@ -1,3 +1,4 @@
>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
>>  dtb-$(CONFIG_ARCH_THUNDER) += thunder-88xx.dtb
>>  dtb-$(CONFIG_ARCH_VEXPRESS) += rtsm_ve-aemv8a.dtb foundation-v8.dtb
>>  dtb-$(CONFIG_ARCH_XGENE) += apm-mustang.dtb
>> diff --git a/arch/arm64/boot/dts/mt8173-evb.dts b/arch/arm64/boot/dts/mt8173-evb.dts
>> new file mode 100644
>> index 0000000..b8b2621
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/mt8173-evb.dts
>> @@ -0,0 +1,34 @@
>> +/*
>> + * Copyright (c) 2014 MediaTek Inc.
>> + * Author: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +/dts-v1/;
>> +#include "mt8173.dtsi"
>> +
>> +/ {
>> +	model = "mediatek,mt8173-evb";
>> +
>> +	aliases {
>> +		serial0 = &uart0;
>> +		serial1 = &uart1;
>> +		serial2 = &uart2;
>> +		serial3 = &uart3;
>> +	};
>> +
>> +	memory@40000000 {
>> +		device_type = "memory";
>> +		reg = <0 0x40000000 0 0x80000000>;
>> +	};
>> +
>> +	chosen { };
>> +};
>> diff --git a/arch/arm64/boot/dts/mt8173.dtsi b/arch/arm64/boot/dts/mt8173.dtsi
>> new file mode 100644
>> index 0000000..41c1441
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/mt8173.dtsi
>> @@ -0,0 +1,152 @@
>> +/*
>> + * Copyright (c) 2014 MediaTek Inc.
>> + * Author: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +/ {
>> +	compatible = "mediatek,mt8173";
>> +	interrupt-parent = <&sysirq>;
>> +	#address-cells = <2>;
>> +	#size-cells = <2>;
>> +
>> +	cpus {
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		cpu-map {
>> +			cluster0 {
>> +				core0 {
>> +					cpu = <&cpu0>;
>> +				};
>> +				core1 {
>> +					cpu = <&cpu1>;
>> +				};
>> +			};
>> +
>> +			cluster1 {
>> +				core0 {
>> +					cpu = <&cpu2>;
>> +				};
>> +				core1 {
>> +					cpu = <&cpu3>;
>> +				};
>> +			};
>> +		};
>> +
>> +		cpu0: cpu@0 {
>> +			device_type = "cpu";
>> +			compatible = "arm,cortex-a53";
>> +			reg = <0x000>;
>> +		};
>> +
>> +		cpu1: cpu@1 {
>> +			device_type = "cpu";
>> +			compatible = "arm,cortex-a53";
>> +			reg = <0x001>;
>> +			enable-method = "psci";
>> +		};
>> +
>> +		cpu2: cpu@2 {
> 
> The unit-address should be 100 rather than 2, matching the reg property.
> This should be 'cpu@100'.
> 
>> +			device_type = "cpu";
>> +			compatible = "arm,cortex-a57";
>> +			reg = <0x100>;
>> +			enable-method = "psci";
>> +		};
>> +
>> +		cpu3: cpu@3 {
> 
> Similarly this should be 'cpu@101'.
> 
>> +			device_type = "cpu";
>> +			compatible = "arm,cortex-a57";
>> +			reg = <0x101>;
>> +			enable-method = "psci";
>> +		};
>> +	};
>> +
>> +	psci {
>> +		compatible = "arm,psci";
>> +		method = "smc";
>> +		cpu_suspend   = <0x84000001>;
>> +		cpu_off	      = <0x84000002>;
>> +		cpu_on	      = <0x84000003>;
>> +		affinity_info = <0x84000004>;
>> +	};
> 
> There is no AFFINITY_INFO function prior to PSCI 0.2, and
> 'affinity_info' does not exist in the "arm,psci" binding.
> 
> I take it hotplug has been tested for all but CPU0?
> 
>> +
>> +	uart_clk: dummy26m {
>> +		compatible = "fixed-clock";
>> +		clock-frequency = <26000000>;
>> +		#clock-cells = <0>;
>> +	};
>> +
>> +	timer {
>> +		compatible = "arm,armv8-timer";
>> +		interrupt-parent = <&gic>;
>> +		interrupts = <1 13 0xf08>,
>> +			     <1 14 0xf08>,
>> +			     <1 11 0xf08>,
>> +			     <1 10 0xf08>;
>> +	};
>> +
>> +	soc {
>> +		#address-cells = <2>;
>> +		#size-cells = <2>;
>> +		compatible = "simple-bus";
>> +		ranges;
>> +
>> +		sysirq: intpol-controller@10200620 {
>> +			compatible = "mediatek,mt8173-sysirq", "mediatek,mt6577-sysirq";
>> +			interrupt-controller;
>> +			#interrupt-cells = <3>;
>> +			interrupt-parent = <&gic>;
>> +			reg = <0 0x10200620 0 0x20>;
>> +		};
>> +
>> +		gic: interrupt-controller@10220000 {
>> +			compatible = "arm,gic-400";
>> +			#interrupt-cells = <3>;
>> +			interrupt-parent = <&gic>;
>> +			interrupt-controller;
>> +			reg = <0 0x10221000 0 0x1000>,
>> +			      <0 0x10222000 0 0x1000>,
>> +			      <0 0x10224000 0 0x2000>,
>> +			      <0 0x10226000 0 0x2000>;
>> +			interrupts = <1 9 0xf04>;
>> +		};
> 
> I don't think these reg entries are quite right; GICC should be 8k long.
> 
> Marc?

Indeed, as described in the documentation:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html

Also it is worth noticing that given how GICV is placed, it will never
work with 64K pages and virtualization. Pretty sad.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile
       [not found]         ` <54919AC9.2090306-5wv7dgnIgG8@public.gmane.org>
@ 2014-12-20 20:07           ` Arnd Bergmann
  2014-12-20 22:54             ` Peter Maydell
  2014-12-22  9:07             ` Marc Zyngier
  0 siblings, 2 replies; 16+ messages in thread
From: Arnd Bergmann @ 2014-12-20 20:07 UTC (permalink / raw)
  To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: Marc Zyngier, Mark Rutland, Eddie Huang,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Jason Cooper, Pawel Moll,
	Ian Campbell, Catalin Marinas, Olof Johansson, Will Deacon,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Robert Richter,
	srv_heupstream-NuS5LvNUpcJWk0Htik3J/w, Rob Herring, Sascha Hauer,
	Kumar Gala, Matthias Brugger, Joe.C, Thomas Gleixner, Mark Brown

On Wednesday 17 December 2014 15:01:29 Marc Zyngier wrote:
> 
> Indeed, as described in the documentation:
> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html
> 
> Also it is worth noticing that given how GICV is placed, it will never
> work with 64K pages and virtualization. Pretty sad.

Does this mean no VGIC support on this platform so you have to emulate it
in order to run virtual machines with 64K pages, or does it mean that
it's impossible to use that way because you can't emulate it?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile
  2014-12-20 20:07           ` Arnd Bergmann
@ 2014-12-20 22:54             ` Peter Maydell
  2014-12-22  9:07             ` Marc Zyngier
  1 sibling, 0 replies; 16+ messages in thread
From: Peter Maydell @ 2014-12-20 22:54 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: arm-mail-list, Mark Rutland, devicetree, Jason Cooper,
	Pawel Moll, Ian Campbell, Marc Zyngier, Catalin Marinas,
	Mark Brown, Will Deacon, linux-kernel, Robert Richter,
	srv_heupstream, Rob Herring, Matthias Brugger, Sascha Hauer,
	Kumar Gala, Olof Johansson, Joe.C, Thomas Gleixner, Eddie Huang

On 20 December 2014 at 20:07, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 17 December 2014 15:01:29 Marc Zyngier wrote:
>> Also it is worth noticing that given how GICV is placed, it will never
>> work with 64K pages and virtualization. Pretty sad.
>
> Does this mean no VGIC support on this platform so you have to emulate it
> in order to run virtual machines with 64K pages, or does it mean that
> it's impossible to use that way because you can't emulate it?

Currently having the guest use the generic timer requires an
in-kernel GIC, because we don't provide an ABI for having the
kernel say "here is a generic timer interrupt for the userspace
emulated GIC". And at least for QEMU userspace the "virt" board
doesn't provide any other kind of timer, so you'd need to add one
if you wanted to use a userspace GIC. So for practical purposes
"out-of-kernel GIC" is not a supported config for KVM+QEMU.

-- PMM

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile
  2014-12-20 20:07           ` Arnd Bergmann
  2014-12-20 22:54             ` Peter Maydell
@ 2014-12-22  9:07             ` Marc Zyngier
  2014-12-23  8:02               ` Eddie Huang
  1 sibling, 1 reply; 16+ messages in thread
From: Marc Zyngier @ 2014-12-22  9:07 UTC (permalink / raw)
  To: Arnd Bergmann, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
  Cc: Mark Rutland, Eddie Huang, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Jason Cooper, Pawel Moll, Ian Campbell, Catalin Marinas,
	Olof Johansson, Will Deacon, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	Robert Richter, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w,
	Rob Herring, Sascha Hauer, Kumar Gala, Matthias Brugger, Joe.C,
	Thomas Gleixner, Mark Brown

On 20/12/14 20:07, Arnd Bergmann wrote:
> On Wednesday 17 December 2014 15:01:29 Marc Zyngier wrote:
>>
>> Indeed, as described in the documentation:
>> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html
>>
>> Also it is worth noticing that given how GICV is placed, it will never
>> work with 64K pages and virtualization. Pretty sad.
> 
> Does this mean no VGIC support on this platform so you have to emulate it
> in order to run virtual machines with 64K pages, or does it mean that
> it's impossible to use that way because you can't emulate it?

As Peter said, this is not a configuration we're willing to support:
- we don't have a API to tell userspace emulation about interrupts
generated by the generic timers
- we could move the whole GIC emulation into the kernel (at the moment,
only the distributor is there), but that would be a complete nightmare

It really looks like a case of "let's drop a bunch of 64bit cores into
an existing SoC". Shame people can't read integration guidelines...

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile
  2014-12-17 14:33     ` Mark Rutland
  2014-12-17 15:01       ` Marc Zyngier
@ 2014-12-23  7:30       ` Eddie Huang
  1 sibling, 0 replies; 16+ messages in thread
From: Eddie Huang @ 2014-12-23  7:30 UTC (permalink / raw)
  To: Mark Rutland
  Cc: devicetree, Jason Cooper, Pawel Moll, Ian Campbell, marc.zyngier,
	Catalin Marinas, Olof Johansson, Will Deacon, linux-kernel,
	Robert Richter, srv_heupstream, Rob Herring, Sascha Hauer,
	Kumar Gala, Matthias Brugger, Joe.C, Thomas Gleixner, Mark Brown,
	linux-arm-kernel

On Wed, 2014-12-17 at 14:33 +0000, Mark Rutland wrote:
> On Wed, Dec 17, 2014 at 02:17:32PM +0000, Eddie Huang wrote:
> > Add device tree support for MT8173 SoC and evaluation board based on it.
> > 
> > Signed-off-by: Eddie Huang <eddie.huang@mediatek.com>
> > ---
> >  arch/arm64/boot/dts/Makefile       |   1 +
> >  arch/arm64/boot/dts/mt8173-evb.dts |  34 +++++++++
> >  arch/arm64/boot/dts/mt8173.dtsi    | 152 +++++++++++++++++++++++++++++++++++++
> >  3 files changed, 187 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/mt8173-evb.dts
> >  create mode 100644 arch/arm64/boot/dts/mt8173.dtsi
> > 
> > +	psci {
> > +		compatible = "arm,psci";
> > +		method = "smc";
> > +		cpu_suspend   = <0x84000001>;
> > +		cpu_off	      = <0x84000002>;
> > +		cpu_on	      = <0x84000003>;
> > +		affinity_info = <0x84000004>;
> > +	};
> 
> There is no AFFINITY_INFO function prior to PSCI 0.2, and
> 'affinity_info' does not exist in the "arm,psci" binding.
> 
> I take it hotplug has been tested for all but CPU0?
> 

Yes, hotplug is ok except CPU0

> > +
> > +		gic: interrupt-controller@10220000 {
> > +			compatible = "arm,gic-400";
> > +			#interrupt-cells = <3>;
> > +			interrupt-parent = <&gic>;
> > +			interrupt-controller;
> > +			reg = <0 0x10221000 0 0x1000>,
> > +			      <0 0x10222000 0 0x1000>,
> > +			      <0 0x10224000 0 0x2000>,
> > +			      <0 0x10226000 0 0x2000>;
> > +			interrupts = <1 9 0xf04>;
> > +		};
> 
> I don't think these reg entries are quite right; GICC should be 8k long.
> 
> Marc?
> 
> Thanks,
> Mark.

Yes, GICC should be 8K long.

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile
  2014-12-22  9:07             ` Marc Zyngier
@ 2014-12-23  8:02               ` Eddie Huang
  2014-12-23  8:43                 ` Marc Zyngier
  0 siblings, 1 reply; 16+ messages in thread
From: Eddie Huang @ 2014-12-23  8:02 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Mark Rutland, devicetree, Arnd Bergmann, Pawel Moll,
	Ian Campbell, Catalin Marinas, Mark Brown, Will Deacon,
	linux-kernel, yh.chen, Robert Richter, srv_heupstream,
	Rob Herring, Matthias Brugger, Sascha Hauer, Kumar Gala,
	Olof Johansson, Joe.C, Thomas Gleixner, linux-arm-kernel,
	Jason Cooper

Hi,

On Mon, 2014-12-22 at 09:07 +0000, Marc Zyngier wrote:
> On 20/12/14 20:07, Arnd Bergmann wrote:
> > On Wednesday 17 December 2014 15:01:29 Marc Zyngier wrote:
> >>
> >> Indeed, as described in the documentation:
> >> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html
> >>
> >> Also it is worth noticing that given how GICV is placed, it will never
> >> work with 64K pages and virtualization. Pretty sad.
> > 
> > Does this mean no VGIC support on this platform so you have to emulate it
> > in order to run virtual machines with 64K pages, or does it mean that
> > it's impossible to use that way because you can't emulate it?
> 
> As Peter said, this is not a configuration we're willing to support:
> - we don't have a API to tell userspace emulation about interrupts
> generated by the generic timers
> - we could move the whole GIC emulation into the kernel (at the moment,
> only the distributor is there), but that would be a complete nightmare
> 
> It really looks like a case of "let's drop a bunch of 64bit cores into
> an existing SoC". Shame people can't read integration guidelines...
> 
> 	M.

MT8173 use GIC-400. We check GIC-400 TRM that VGIC address is not 64KB
alignment. but GIC-500 (GICv3) VGIC base address is. We also check
3.19-rc1 arm64 device tree, amd-seattle-soc.dtsi VGIC is 64KB alignment,
but arm juno.dts is not, they are both GIC-400. So we are a little
confused, and still try to figure out what is the correct address.
Neverthless, MT8173 SoC already use 0x10224000 and 0x10225000 as VGIC
base address.

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile
  2014-12-23  8:02               ` Eddie Huang
@ 2014-12-23  8:43                 ` Marc Zyngier
       [not found]                   ` <72aa7f4069a000c6e39c53e328015aa3-PqNocJHN/zZWj0EZb7rXcA@public.gmane.org>
  0 siblings, 1 reply; 16+ messages in thread
From: Marc Zyngier @ 2014-12-23  8:43 UTC (permalink / raw)
  To: Eddie Huang
  Cc: Mark Rutland, devicetree, Arnd Bergmann, Pawel Moll,
	Ian Campbell, Olof Johansson, Catalin Marinas, Mark Brown,
	Will Deacon, linux-kernel, Robert Richter, srv_heupstream,
	Rob Herring, Sascha Hauer, Kumar Gala, Matthias Brugger, Joe.C,
	Thomas Gleixner, Jason Cooper, linux-arm-kernel, yh.chen

Hi Eddie,

On 2014-12-23 08:02, Eddie Huang wrote:
> Hi,
>
> On Mon, 2014-12-22 at 09:07 +0000, Marc Zyngier wrote:
>> On 20/12/14 20:07, Arnd Bergmann wrote:
>> > On Wednesday 17 December 2014 15:01:29 Marc Zyngier wrote:
>> >>
>> >> Indeed, as described in the documentation:
>> >> 
>> http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html
>> >>
>> >> Also it is worth noticing that given how GICV is placed, it will 
>> never
>> >> work with 64K pages and virtualization. Pretty sad.
>> >
>> > Does this mean no VGIC support on this platform so you have to 
>> emulate it
>> > in order to run virtual machines with 64K pages, or does it mean 
>> that
>> > it's impossible to use that way because you can't emulate it?
>>
>> As Peter said, this is not a configuration we're willing to support:
>> - we don't have a API to tell userspace emulation about interrupts
>> generated by the generic timers
>> - we could move the whole GIC emulation into the kernel (at the 
>> moment,
>> only the distributor is there), but that would be a complete 
>> nightmare
>>
>> It really looks like a case of "let's drop a bunch of 64bit cores 
>> into
>> an existing SoC". Shame people can't read integration guidelines...
>>
>> 	M.
>
> MT8173 use GIC-400. We check GIC-400 TRM that VGIC address is not 
> 64KB
> alignment. but GIC-500 (GICv3) VGIC base address is. We also check
> 3.19-rc1 arm64 device tree, amd-seattle-soc.dtsi VGIC is 64KB 
> alignment,
> but arm juno.dts is not, they are both GIC-400. So we are a little
> confused, and still try to figure out what is the correct address.

I'm afraid you're missing the point.

It is not a matter of alignment, but a matter of having put the GICV
region in the same 64K page as the rest of the GIC. Which means that
if the hypervisor (KVM or Xen) wants to map the GICV region inside the
guest, it will also be forced to give it access to GICC, GICD, and 
GICH.

Goodbye isolation, see your hypervisor going down at the first buggy 
guest,
not to mention all kind of other nice hacks...

I could understand the need to tightly pack everything on a 32bit 
system,
but doing so on a 64bit system without consideration of the page size
is a bit of a bummer.

> Neverthless, MT8173 SoC already use 0x10224000 and 0x10225000 as VGIC
> base address.

Then its fate is sealed virtualization wise.

Thanks,

         M.
-- 
Fast, cheap, reliable. Pick two.

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and  evaluation board dts and Makefile
       [not found]                   ` <72aa7f4069a000c6e39c53e328015aa3-PqNocJHN/zZWj0EZb7rXcA@public.gmane.org>
@ 2014-12-23 21:07                     ` Arnd Bergmann
  2014-12-24  8:47                       ` Marc Zyngier
  0 siblings, 1 reply; 16+ messages in thread
From: Arnd Bergmann @ 2014-12-23 21:07 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Eddie Huang, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Pawel Moll, Ian Campbell, Catalin Marinas, Mark Brown,
	Will Deacon, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	yh.chen-NuS5LvNUpcJWk0Htik3J/w, Robert Richter,
	srv_heupstream-NuS5LvNUpcJWk0Htik3J/w, Rob Herring,
	Matthias Brugger, Sascha Hauer, Kumar Gala, Olof Johansson,
	Joe.C, Thomas Gleixner,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jason Cooper

On Tuesday 23 December 2014 08:43:55 Marc Zyngier wrote:
> 
> > Neverthless, MT8173 SoC already use 0x10224000 and 0x10225000 as VGIC
> > base address.
> 
> Then its fate is sealed virtualization wise.

It should still work with 4kb pages on the host, right? Would that still
allow you to have 64kb pages on the guest, or does the guest page size
have to be smaller or equal to the host?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and  evaluation board dts and Makefile
  2014-12-23 21:07                     ` Arnd Bergmann
@ 2014-12-24  8:47                       ` Marc Zyngier
  0 siblings, 0 replies; 16+ messages in thread
From: Marc Zyngier @ 2014-12-24  8:47 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Mark Rutland, devicetree, srv_heupstream, Pawel Moll,
	Ian Campbell, Catalin Marinas, Mark Brown, Will Deacon,
	linux-kernel, Robert Richter, Olof Johansson, Rob Herring,
	Sascha Hauer, Kumar Gala, Matthias Brugger, Joe.C,
	Thomas Gleixner, Eddie Huang, Jason Cooper, linux-arm-kernel,
	yh.chen

On 2014-12-23 21:07, Arnd Bergmann wrote:
> On Tuesday 23 December 2014 08:43:55 Marc Zyngier wrote:
>>
>> > Neverthless, MT8173 SoC already use 0x10224000 and 0x10225000 as 
>> VGIC
>> > base address.
>>
>> Then its fate is sealed virtualization wise.
>
> It should still work with 4kb pages on the host, right? Would that 
> still
> allow you to have 64kb pages on the guest, or does the guest page 
> size
> have to be smaller or equal to the host?

Of course, it will still work with 4kB pages, and the guest can still 
use
whatever page size it wants, including 64kB. Not very good from a 
performance
point of view, but it will work.

My main worry is that we're already starting to see more and more 
platforms
having divergent requirements in their MM setup, and distributions are 
going
to struggle to provide a full-featured single kernel image, specially 
as some
feel the need to push 64kB pages down to everybody's throat.

Thanks,

         M.
-- 
Fast, cheap, reliable. Pick two.

^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2014-12-24  8:47 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-17 14:17 [PATCH v2 0/4] Add basic support for Mediatek MT8173 SoC Eddie Huang
2014-12-17 14:17 ` [PATCH v2 1/4] Document: DT: Add bindings for mediatek MT8173 Soc Platform Eddie Huang
2014-12-17 14:17 ` [PATCH v2 2/4] irqchip: mtk-sysirq: Get irq number from register resource size Eddie Huang
2014-12-17 14:17 ` [PATCH v2 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile Eddie Huang
     [not found]   ` <1418825853-10934-4-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2014-12-17 14:33     ` Mark Rutland
2014-12-17 15:01       ` Marc Zyngier
     [not found]         ` <54919AC9.2090306-5wv7dgnIgG8@public.gmane.org>
2014-12-20 20:07           ` Arnd Bergmann
2014-12-20 22:54             ` Peter Maydell
2014-12-22  9:07             ` Marc Zyngier
2014-12-23  8:02               ` Eddie Huang
2014-12-23  8:43                 ` Marc Zyngier
     [not found]                   ` <72aa7f4069a000c6e39c53e328015aa3-PqNocJHN/zZWj0EZb7rXcA@public.gmane.org>
2014-12-23 21:07                     ` Arnd Bergmann
2014-12-24  8:47                       ` Marc Zyngier
2014-12-23  7:30       ` Eddie Huang
2014-12-17 14:17 ` [PATCH v2 4/4] arm64: mediatek: Add MT8173 SoC Kconfig and defconfig Eddie Huang
     [not found] ` <1418825853-10934-1-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2014-12-17 14:35   ` [PATCH v2 0/4] Add basic support for Mediatek MT8173 SoC Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).