* [PATCH v5] arm64: dts: imx8mq-phanbell: Add gpio-fan/thermal support
@ 2020-03-03 0:52 Vitor Massaru Iha
2020-03-03 0:59 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Vitor Massaru Iha @ 2020-03-03 0:52 UTC (permalink / raw)
To: devicetree, linux-arm-kernel
Cc: robh+dt, mark.rutland, shawnguo, s.hauer, festevam,
marco.franchi, linux-imx, lkcamp
It was based on Google Source Code for Coral Edge TPU Mendel release:
https://coral.googlesource.com/linux-imx/
It was tested on Coral Dev Board using this command:
sudo stress --cpu 4 --timeout 3600
Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
v2:
* Fix underscore in property name;
* Add pinctrl entry for gpio-fan;
* Removes undocumented property;
v3:
* Fix subject pattern;
* Fix order of pinctrl entries;
* Fix MX8MQ_IOMUXC_NAND_CLE_GPIO3_IO5 flags;
* Typo pattern (from "gpiofanp" to "gpiofangrp");
* Fix tabs on MX8MQ_IOMUXC_NAND_CLE_GPIO3_IO5 line;
v4:
* Fix cpu_thermal order;
v5:
* Add missing Reviewed-by;
BR,
Vitor
---
.../boot/dts/freescale/imx8mq-phanbell.dts | 64 +++++++++++++++++++
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-
2 files changed, 65 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts b/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts
index 3f2a489a4ad8..f1fce2b1b5c8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts
@@ -35,6 +35,16 @@
gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
enable-active-high;
};
+
+ fan: gpio-fan {
+ compatible = "gpio-fan";
+ gpio-fan,speed-map = <0 0 8600 1>;
+ gpios = <&gpio3 5 GPIO_ACTIVE_HIGH>;
+ #cooling-cells = <2>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_gpio_fan>;
+ status = "okay";
+ };
};
&A53_0 {
@@ -53,6 +63,53 @@
cpu-supply = <&buck2>;
};
+&cpu_thermal {
+ trips {
+ cpu_alert0: trip0 {
+ temperature = <75000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ cpu_alert1: trip1 {
+ temperature = <80000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ cpu_crit0: trip3 {
+ temperature = <90000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+
+ fan_toggle0: trip4 {
+ temperature = <65000>;
+ hysteresis = <10000>;
+ type = "active";
+ };
+ };
+
+ cooling-maps {
+ map0 {
+ trip = <&cpu_alert0>;
+ cooling-device =
+ <&A53_0 0 1>; /* Exclude highest OPP */
+ };
+
+ map1 {
+ trip = <&cpu_alert1>;
+ cooling-device =
+ <&A53_0 0 2>; /* Exclude two highest OPPs */
+ };
+
+ map4 {
+ trip = <&fan_toggle0>;
+ cooling-device = <&fan 0 1>;
+ };
+ };
+};
+
&i2c1 {
clock-frequency = <400000>;
pinctrl-names = "default";
@@ -254,6 +311,12 @@
};
&iomuxc {
+ pinctrl_gpio_fan: gpiofangrp {
+ fsl,pins = <
+ MX8MQ_IOMUXC_NAND_CLE_GPIO3_IO5 0x16
+ >;
+ };
+
pinctrl_i2c1: i2c1grp {
fsl,pins = <
MX8MQ_IOMUXC_I2C1_SCL_I2C1_SCL 0x4000007f
@@ -374,3 +437,4 @@
>;
};
};
+
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 6a1e83922c71..a3bb17a6b9df 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -198,7 +198,7 @@
};
thermal-zones {
- cpu-thermal {
+ cpu_thermal: cpu-thermal {
polling-delay-passive = <250>;
polling-delay = <2000>;
thermal-sensors = <&tmu 0>;
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v5] arm64: dts: imx8mq-phanbell: Add gpio-fan/thermal support
2020-03-03 0:52 [PATCH v5] arm64: dts: imx8mq-phanbell: Add gpio-fan/thermal support Vitor Massaru Iha
@ 2020-03-03 0:59 ` Fabio Estevam
2020-03-03 1:10 ` Vitor Massaru Iha
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2020-03-03 0:59 UTC (permalink / raw)
To: Vitor Massaru Iha
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
Marco Franchi, NXP Linux Team, lkcamp
Hi Vitor,
On Mon, Mar 2, 2020 at 9:52 PM Vitor Massaru Iha <vitor@massaru.org> wrote:
> pinctrl_i2c1: i2c1grp {
> fsl,pins = <
> MX8MQ_IOMUXC_I2C1_SCL_I2C1_SCL 0x4000007f
> @@ -374,3 +437,4 @@
> >;
> };
> };
> +
Unneeded blank line added here.
With that line removed you can add:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5] arm64: dts: imx8mq-phanbell: Add gpio-fan/thermal support
2020-03-03 0:59 ` Fabio Estevam
@ 2020-03-03 1:10 ` Vitor Massaru Iha
0 siblings, 0 replies; 3+ messages in thread
From: Vitor Massaru Iha @ 2020-03-03 1:10 UTC (permalink / raw)
To: Fabio Estevam
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
Marco Franchi, NXP Linux Team, lkcamp
Hi Fabio,
On Mon, 2020-03-02 at 21:59 -0300, Fabio Estevam wrote:
> Hi Vitor,
>
> On Mon, Mar 2, 2020 at 9:52 PM Vitor Massaru Iha <vitor@massaru.org>
> wrote:
>
> > pinctrl_i2c1: i2c1grp {
> > fsl,pins = <
> > MX8MQ_IOMUXC_I2C1_SCL_I2C1_SCL
> > 0x4000007f
> > @@ -374,3 +437,4 @@
> > >;
> > };
> > };
> > +
>
> Unneeded blank line added here.
Sorry about that.
>
> With that line removed you can add:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
> Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-03 1:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03 0:52 [PATCH v5] arm64: dts: imx8mq-phanbell: Add gpio-fan/thermal support Vitor Massaru Iha
2020-03-03 0:59 ` Fabio Estevam
2020-03-03 1:10 ` Vitor Massaru Iha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).