From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-rockchip@lists.infradead.org
Cc: kernel@collabora.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-imx@nxp.com,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>
Subject: Re: [Linux-stm32] [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver
Date: Tue, 10 Dec 2019 13:41:46 +0200 [thread overview]
Message-ID: <871rtc2yrp.fsf@collabora.com> (raw)
In-Reply-To: <20191202193359.703709-1-adrian.ratiu@collabora.com>
On Mon, 02 Dec 2019, Adrian Ratiu <adrian.ratiu@collabora.com>
wrote:
> Having a generic Synopsis DesignWare MIPI-DSI host controller
> bridge driver is a very good idea, however the current
> implementation has hardcoded quite a lot of the register layouts
> used by the two supported SoC vendors, STM and Rockchip, which
> use IP cores v1.30 and v1.31.
>
> This makes it hard to support other SoC vendors like the FSL/NXP
> i.MX 6 which use older v1.01 cores or future versions because,
> based on history, layout changes should also be expected in new
> DSI versions / SoCs.
>
> This patch series converts the bridge and platform drivers to
> access registers via generic regmap APIs and allows each
> platform driver to configure its register layout via struct
> reg_fields, then adds support for the host controller found on
> i.MX 6.
>
> I only have i.MX hardware with MIPI-DSI panel and relevant
> documentation available for testing so I'll really appreciate it
> if someone could test the series on Rockchip and
> STM... eyeballing register fields could only get me so far, so
> sorry in advance for any breakage!
>
> Many thanks to Boris Brezillon <boris.brezillon@collabora.com>
> for suggesting the regmap solution and to Liu Ying
> <Ying.Liu@freescale.com> for doing the initial i.MX platform
> driver implementation.
>
> This series applies on top of latest linux-next tree,
> next-20191202.
>
> v3 -> v4:
> * Added commmit message to dt-binding patch (Neil) * Converted
> the dt-binding to yaml dt-schema format (Neil) * Small DT node
> + driver fixes (Rob) * Renamed platform driver to reflect it's
> only for i.MX v6 (Fabio) * Added small panel example to the
> host controller DT binding
>
> v2 -> v3:
> * Added const declarations to dw-mipi-dsi.c structs (Emil) *
> Fixed Reviewed-by tags and cc'd some more relevant ML (Emil)
>
> v1 -> v2:
> * Moved register definitions & regmap initialization into
> bridge module. Platform drivers get the regmap via plat_data
> after calling the bridge probe (Emil).
I've been told I forgot to explicitly CC some of the maintainers,
sorry about that! Added a few more persons to CC.
>
> Adrian Ratiu (4):
> drm: bridge: dw_mipi_dsi: access registers via a regmap
> drm: bridge: dw_mipi_dsi: abstract register access using reg_fields
> drm: imx: Add i.MX 6 MIPI DSI host driver
> dt-bindings: display: add i.MX6 MIPI DSI host controller doc
>
> .../display/imx/fsl,mipi-dsi-imx6.yaml | 136 ++++
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 699 +++++++++++++-----
> drivers/gpu/drm/imx/Kconfig | 7 +
> drivers/gpu/drm/imx/Makefile | 1 +
> drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c | 378 ++++++++++
> .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 17 +-
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 34 +-
> include/drm/bridge/dw_mipi_dsi.h | 2 +-
> 8 files changed, 1067 insertions(+), 207 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml
> create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c
>
> --
> 2.24.0
>
> _______________________________________________
> Linux-stm32 mailing list
> Linux-stm32@st-md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
prev parent reply other threads:[~2019-12-10 11:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 19:33 [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver Adrian Ratiu
2019-12-02 19:33 ` [PATCH v4 1/4] drm: bridge: dw_mipi_dsi: access registers via a regmap Adrian Ratiu
2019-12-16 16:10 ` Ezequiel Garcia
2019-12-02 19:33 ` [PATCH v4 2/4] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields Adrian Ratiu
2019-12-02 19:33 ` [PATCH v4 3/4] drm: imx: Add i.MX 6 MIPI DSI host driver Adrian Ratiu
2019-12-02 19:33 ` [PATCH v4 4/4] dt-bindings: display: add i.MX6 MIPI DSI host controller doc Adrian Ratiu
2019-12-13 23:39 ` Rob Herring
2019-12-06 10:29 ` [Linux-stm32] [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver Philippe CORNU
2019-12-10 11:43 ` Adrian Ratiu
2019-12-10 11:41 ` Adrian Ratiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rtc2yrp.fsf@collabora.com \
--to=adrian.ratiu@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).