From: Marc Zyngier <maz@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
kernel-team@android.com, Rob Herring <robh@kernel.org>,
John Crispin <john@phrozen.org>, Biwen Li <biwen.li@nxp.com>,
Chris Brandt <chris.brandt@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] of/irq: Add a quirk for controllers with their own definition of interrupt-map
Date: Mon, 22 Nov 2021 13:54:22 +0000 [thread overview]
Message-ID: <8735no70tt.wl-maz@kernel.org> (raw)
In-Reply-To: <CAMuHMdX2ZRvDYA3idmw3nBcP6CO=2od6ZU-UeJo9vYsuB=fQNQ@mail.gmail.com>
On Mon, 22 Nov 2021 13:10:32 +0000,
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Marc,
>
> On Mon, Nov 22, 2021 at 11:30 AM Marc Zyngier <maz@kernel.org> wrote:
> > Since 041284181226 ("of/irq: Allow matching of an interrupt-map local
> > to an interrupt controller"), a handful of interrupt controllers have
> > stopped working correctly. This is due to the DT exposing a non-sensical
> > interrupt-map property, and their drivers relying on the kernel ignoring
> > this property.
> >
> > Since we cannot realistically fix this terrible behaviour, add a quirk
> > for the limited set of devices that have implemented this monster,
> > and document that this is a pretty bad practice.
> >
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: John Crispin <john@phrozen.org>
> > Cc: Biwen Li <biwen.li@nxp.com>
> > Cc: Chris Brandt <chris.brandt@renesas.com>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
>
> Thanks for your patch!
>
> > --- a/drivers/of/irq.c
> > +++ b/drivers/of/irq.c
> > @@ -76,6 +76,36 @@ struct device_node *of_irq_find_parent(struct device_node *child)
> > }
> > EXPORT_SYMBOL_GPL(of_irq_find_parent);
> >
> > +/*
> > + * These interrupt controllers abuse interrupt-map for unspeakable
> > + * reasons and rely on the core code to *ignore* it (the drivers do
> > + * their own parsing of the property).
> > + *
> > + * If you think of adding to the list for something *new*, think
> > + * again. There is a high chance that you will be sent back to the
> > + * drawing board.
> > + */
> > +static const char * const of_irq_imap_abusers[] = {
> > + "CBEA,platform-spider-pic",
> > + "sti,platform-spider-pic",
> > + "realtek,rtl-intc",
> > + "fsl,ls1021a-extirq",
> > + "fsl,ls1043a-extirq",
> > + "fsl,ls1088a-extirq",
> > + "renesas,rza1-irqc",
> > +};
>
> Are you sure "renesas,rza1-irqc" handles this wrong? How should it
> be handled instead? I read the other thread[1], but didn't became
> any wiser: interrupts are mapped one-to-one with the RZ/A1 IRQC.
>
> In both v5.15 and v5.16-rc1, interrupts seem to work fine on RSK+RZA1
> and RZA2MEVB, both with gpio-keys and when used as a wake-up interrupt.
This is odd. 5.16-rc1 should actively breaks the behaviour, as each
interrupt is directly routed to the GIC. Here's an extract of the DT
for r7s9210:
interrupt-map = <0 0 &gic GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
<1 0 &gic GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
<2 0 &gic GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
<3 0 &gic GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
<4 0 &gic GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
<5 0 &gic GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>,
<6 0 &gic GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>,
<7 0 &gic GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
I expect v5.16-rc1 to honour the routing described here and not
involve rza1-irqc, because that's what the DT says.
> With this patch applied, I see double keypresses with evtest: when
> pressing a key, I get a key-down event, immediately followed by a
> key-up event. When releasing the key, I again get two events.
>
> Good (v5.15 or v5.16-rc1):
>
> Event: time 1637585631.288990, type 1 (EV_KEY), code 2 (KEY_1), value 1
> Event: time 1637585631.288990, -------------- SYN_REPORT ------------
> Event: time 1637585631.499924, type 1 (EV_KEY), code 2 (KEY_1), value 0
> Event: time 1637585631.499924, -------------- SYN_REPORT ------------
>
> Bad (v5.16-rc1 + this patch):
>
> Event: time 1637585341.946647, type 1 (EV_KEY), code 2 (KEY_1), value 1
> Event: time 1637585341.946647, -------------- SYN_REPORT ------------
> Event: time 1637585341.960256, type 1 (EV_KEY), code 2 (KEY_1), value 0
> Event: time 1637585341.960256, -------------- SYN_REPORT ------------
> Event: time 1637585342.146775, type 1 (EV_KEY), code 2 (KEY_1), value 1
> Event: time 1637585342.146775, -------------- SYN_REPORT ------------
> Event: time 1637585342.160092, type 1 (EV_KEY), code 2 (KEY_1), value 0
> Event: time 1637585342.160092, -------------- SYN_REPORT ------------
Is there any chance you could trace whether rza1-irqc gets called at
all when setting up and handling the interrupt?
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-11-22 13:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 10:30 [PATCH] of/irq: Add a quirk for controllers with their own definition of interrupt-map Marc Zyngier
2021-11-22 13:10 ` Geert Uytterhoeven
2021-11-22 13:54 ` Marc Zyngier [this message]
2021-11-22 16:58 ` Geert Uytterhoeven
2021-11-23 7:57 ` Geert Uytterhoeven
2021-11-23 8:33 ` Marc Zyngier
2021-11-23 8:44 ` Geert Uytterhoeven
2021-11-23 9:11 ` Marc Zyngier
2021-11-24 7:54 ` Geert Uytterhoeven
2021-11-24 11:14 ` Marc Zyngier
2021-11-27 0:42 ` Prabhakar Mahadev Lad
2021-11-29 10:34 ` Marc Zyngier
2021-11-29 12:13 ` Lad, Prabhakar
2021-11-29 18:33 ` Rob Herring
2021-11-30 12:52 ` Lad, Prabhakar
2021-11-30 18:36 ` Marc Zyngier
2021-12-01 13:36 ` Lad, Prabhakar
2021-12-01 14:35 ` Rob Herring
2021-12-01 16:16 ` Lad, Prabhakar
2021-12-05 22:27 ` Lad, Prabhakar
2021-12-06 10:26 ` Marc Zyngier
2021-12-06 16:55 ` Lad, Prabhakar
2021-12-06 18:59 ` Rob Herring
2021-11-23 11:02 ` Geert Uytterhoeven
2021-11-23 8:40 ` Sander Vanheule
2021-11-23 9:12 ` Marc Zyngier
2021-11-29 19:15 ` Rob Herring
2021-11-29 19:31 ` Marc Zyngier
2021-11-29 19:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735no70tt.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=biwen.li@nxp.com \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=john@phrozen.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).