From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: Marc Zyngier <maz@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Rob Herring <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"kernel-team@android.com" <kernel-team@android.com>,
John Crispin <john@phrozen.org>, Biwen Li <biwen.li@nxp.com>,
Chris Brandt <Chris.Brandt@renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Subject: RE: [PATCH] of/irq: Add a quirk for controllers with their own definition of interrupt-map
Date: Sat, 27 Nov 2021 00:42:49 +0000 [thread overview]
Message-ID: <OSZPR01MB7019E7DD7119EFF9C994AA62AA649@OSZPR01MB7019.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <87r1b7ck40.wl-maz@kernel.org>
Hi Marc,
> -----Original Message-----
> From: Marc Zyngier <maz@kernel.org>
> Sent: 23 November 2021 09:11
> To: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; kernel-team@android.com; Rob Herring
> <robh@kernel.org>; John Crispin <john@phrozen.org>; Biwen Li <biwen.li@nxp.com>; Chris Brandt
> <Chris.Brandt@renesas.com>; linux-renesas-soc@vger.kernel.org; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: Re: [PATCH] of/irq: Add a quirk for controllers with their own definition of interrupt-map
>
> On Tue, 23 Nov 2021 08:44:19 +0000,
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Marc,
> >
> > On Tue, Nov 23, 2021 at 9:33 AM Marc Zyngier <maz@kernel.org> wrote:
> > > On Tue, 23 Nov 2021 07:57:48 +0000,
> > > Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > Summarized:
> > > > - Before the bad commit, and after your fix, irqc-rza1 is invoked,
> > > > and the number of interrupts seen is correct, but input events
> > > > are doubled.
> > > > - After the bad commit, irqc-rza1 is not invoked, and there is an
> > > > interrupt storm, but input events are OK.
> > >
> > > OK, that's reassuring, even if the "twice the events" stuff isn't
> > > what you'd expect. We at least know this is a separate issue, and
> > > that this patch on top of -rc1 brings you back to the 5.15 behaviour.
> > >
> > > I'd expect it to be the case for the other platforms as well.
> >
> > OK.
> >
> > BTW, what would have been the correct way to do this for irqc-rza1?
> > I think we're about to make the same mistake with RZ/G2L IRQC
> > support[1]?
>
> Indeed, and I was about to look into it.
>
> There are multiple ways to skin this cat, including renaming 'interrupt-map' to 'my-own-private-
> interrupt-map'. Or use something akin the new 'msi-range' (which we could call interrupt-range), and
> replace:
>
> interrupt-map = <0 0 &gic GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
> <1 0 &gic GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
> <2 0 &gic GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> <3 0 &gic GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
> <4 0 &gic GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
> <5 0 &gic GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>,
> <6 0 &gic GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>,
> <7 0 &gic GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
>
> with:
>
> interrupt-range = <&gic GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH 0 8>;
>
Just to clarify, do you suggest to add interrupt-range as a generic DT property or SoC/company specific property? If you meant to add generic property where would you suggest to document this property?
Maybe to chime in with "msi-ranges" we could name it to "interrupt-ranges"?
Cheers,
Prabhakar
> which reads as "base interrupt spec", "start pin", "count". This gives you almost the same level of
> information, and doesn't interfere with the rest of the DT properties. Parsing it is also much
> simpler.
> But that's up to you, really.
>
> M.
>
> --
> Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-11-27 0:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 10:30 [PATCH] of/irq: Add a quirk for controllers with their own definition of interrupt-map Marc Zyngier
2021-11-22 13:10 ` Geert Uytterhoeven
2021-11-22 13:54 ` Marc Zyngier
2021-11-22 16:58 ` Geert Uytterhoeven
2021-11-23 7:57 ` Geert Uytterhoeven
2021-11-23 8:33 ` Marc Zyngier
2021-11-23 8:44 ` Geert Uytterhoeven
2021-11-23 9:11 ` Marc Zyngier
2021-11-24 7:54 ` Geert Uytterhoeven
2021-11-24 11:14 ` Marc Zyngier
2021-11-27 0:42 ` Prabhakar Mahadev Lad [this message]
2021-11-29 10:34 ` Marc Zyngier
2021-11-29 12:13 ` Lad, Prabhakar
2021-11-29 18:33 ` Rob Herring
2021-11-30 12:52 ` Lad, Prabhakar
2021-11-30 18:36 ` Marc Zyngier
2021-12-01 13:36 ` Lad, Prabhakar
2021-12-01 14:35 ` Rob Herring
2021-12-01 16:16 ` Lad, Prabhakar
2021-12-05 22:27 ` Lad, Prabhakar
2021-12-06 10:26 ` Marc Zyngier
2021-12-06 16:55 ` Lad, Prabhakar
2021-12-06 18:59 ` Rob Herring
2021-11-23 11:02 ` Geert Uytterhoeven
2021-11-23 8:40 ` Sander Vanheule
2021-11-23 9:12 ` Marc Zyngier
2021-11-29 19:15 ` Rob Herring
2021-11-29 19:31 ` Marc Zyngier
2021-11-29 19:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSZPR01MB7019E7DD7119EFF9C994AA62AA649@OSZPR01MB7019.jpnprd01.prod.outlook.com \
--to=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=Chris.Brandt@renesas.com \
--cc=biwen.li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=john@phrozen.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maz@kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).