* [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property
@ 2020-07-27 7:41 Hsin-Yi Wang
2020-07-31 11:20 ` Enric Balletbo i Serra
2020-09-21 10:05 ` Matthias Brugger
0 siblings, 2 replies; 4+ messages in thread
From: Hsin-Yi Wang @ 2020-07-27 7:41 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Enric Balletbo i Serra, Hsin-Yi Wang, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
bus-width and non-removable is not used by the driver.
max-frequency should be spi-max-frequency for flash node.
Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
Reported-by: Nicolas Boichat <drinkcat@chromium.org>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index a5a12b2599a4..01522dd10603 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -431,12 +431,11 @@ &nor_flash {
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&nor_gpio1_pins>;
- bus-width = <8>;
- max-frequency = <50000000>;
- non-removable;
+
flash@0 {
compatible = "jedec,spi-nor";
reg = <0>;
+ spi-max-frequency = <50000000>;
};
};
--
2.28.0.rc0.142.g3c755180ce-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property
2020-07-27 7:41 [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property Hsin-Yi Wang
@ 2020-07-31 11:20 ` Enric Balletbo i Serra
2020-09-16 5:25 ` Hsin-Yi Wang
2020-09-21 10:05 ` Matthias Brugger
1 sibling, 1 reply; 4+ messages in thread
From: Enric Balletbo i Serra @ 2020-07-31 11:20 UTC (permalink / raw)
To: Hsin-Yi Wang, Matthias Brugger
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
Hi Hsin-Yi,
Thank you for your patch.
On 27/7/20 9:41, Hsin-Yi Wang wrote:
> bus-width and non-removable is not used by the driver.
> max-frequency should be spi-max-frequency for flash node.
>
> Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
> Reported-by: Nicolas Boichat <drinkcat@chromium.org>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index a5a12b2599a4..01522dd10603 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -431,12 +431,11 @@ &nor_flash {
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&nor_gpio1_pins>;
> - bus-width = <8>;
> - max-frequency = <50000000>;
> - non-removable;
> +
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> + spi-max-frequency = <50000000>;
> };
> };
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property
2020-07-31 11:20 ` Enric Balletbo i Serra
@ 2020-09-16 5:25 ` Hsin-Yi Wang
0 siblings, 0 replies; 4+ messages in thread
From: Hsin-Yi Wang @ 2020-09-16 5:25 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Matthias Brugger, Rob Herring, Devicetree List,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/Mediatek SoC support, lkml
On Fri, Jul 31, 2020 at 7:21 PM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Hsin-Yi,
>
> Thank you for your patch.
>
> On 27/7/20 9:41, Hsin-Yi Wang wrote:
> > bus-width and non-removable is not used by the driver.
> > max-frequency should be spi-max-frequency for flash node.
> >
> > Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
> > Reported-by: Nicolas Boichat <drinkcat@chromium.org>
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
Gentle ping.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property
2020-07-27 7:41 [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property Hsin-Yi Wang
2020-07-31 11:20 ` Enric Balletbo i Serra
@ 2020-09-21 10:05 ` Matthias Brugger
1 sibling, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2020-09-21 10:05 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Rob Herring, Enric Balletbo i Serra, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
On 27/07/2020 09:41, Hsin-Yi Wang wrote:
> bus-width and non-removable is not used by the driver.
> max-frequency should be spi-max-frequency for flash node.
>
> Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
> Reported-by: Nicolas Boichat <drinkcat@chromium.org>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Applied to v5.9-next/dts64
Thanks!
> ---
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index a5a12b2599a4..01522dd10603 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -431,12 +431,11 @@ &nor_flash {
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&nor_gpio1_pins>;
> - bus-width = <8>;
> - max-frequency = <50000000>;
> - non-removable;
> +
> flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
> + spi-max-frequency = <50000000>;
> };
> };
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-21 10:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 7:41 [PATCH] arm64: dts: mt8173: elm: Fix nor_flash node property Hsin-Yi Wang
2020-07-31 11:20 ` Enric Balletbo i Serra
2020-09-16 5:25 ` Hsin-Yi Wang
2020-09-21 10:05 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).