From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Rob Herring <robh@kernel.org>,
William Breathitt Gray <william.gray@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Chris Paterson" <Chris.Paterson2@renesas.com>,
"Biju Das" <biju.das@bp.renesas.com>,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: Document RZ/G2L MTU3a bindings
Date: Sun, 9 Oct 2022 17:16:29 +0200 [thread overview]
Message-ID: <8b4a2bfd-ce7f-6bb9-4e50-ecd9bda881a2@linaro.org> (raw)
In-Reply-To: <OS0PR01MB59221BDEB7E6B39AEFD31C44865E9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On 08/10/2022 09:42, Biju Das wrote:
>>>> + "tgia8", "tgib8", "tgic8", "tgid8",
>>> "tgiv8", "tgiu8";
>>>> + clocks = <&cpg CPG_MOD R9A07G044_MTU_X_MCK_MTU3>;
>>>> + power-domains = <&cpg>;
>>>> + resets = <&cpg R9A07G044_MTU_X_PRESET_MTU3>;
>>>> +
>>>> + counter {
>>>> + compatible = "renesas,rz-mtu3-counter";
>>>
>>> You don't have any resources for the counter in DT, so you don't
>> even
>>> need a node here. Just have the parent driver instaniate the counter
>>> driver.
>>
>
> If I remove "renesas,rz-mtu3-counter" and "renesas,rz-mtu3-pwm" then instantiating
> the counter and pwm driver from parent driver by directly calling probe function is
> giving cyclic dependency error[1].
How is this related to DT? Purpose of DT is not to solve your probe
problems.
>
> So looks like either we need to use compatible "renesas,rz-mtu3-counter" and
> "renesas,rz-mtu3-pwm" if these functionalities to be in respective subsystem tree
>
No, you don't need. Your driver implementation is not really related to
the bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-09 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 13:57 [PATCH v3 0/4] Add RZ/G2L MTU3a MFD, Counter and pwm driver Biju Das
2022-10-06 13:57 ` [PATCH v3 1/4] dt-bindings: mfd: Document RZ/G2L MTU3a bindings Biju Das
2022-10-06 20:17 ` Rob Herring
2022-10-07 12:40 ` Biju Das
2022-10-08 7:42 ` Biju Das
2022-10-08 10:51 ` Biju Das
2022-10-09 14:38 ` Geert Uytterhoeven
2022-10-09 15:17 ` Krzysztof Kozlowski
2022-10-10 13:00 ` Biju Das
2022-10-10 7:10 ` Biju Das
2022-10-09 15:16 ` Krzysztof Kozlowski [this message]
2022-10-10 15:13 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4a2bfd-ce7f-6bb9-4e50-ecd9bda881a2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).