From: Billy Tsai <billy_tsai@aspeedtech.com>
To: Rob Herring <robh@kernel.org>
Cc: "lee.jones@linaro.org" <lee.jones@linaro.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [v9 1/2] dt-bindings: Add bindings for aspeed pwm-tach.
Date: Mon, 4 Oct 2021 01:46:01 +0000 [thread overview]
Message-ID: <A7C9DA11-6880-46EC-BD71-2E1984EBA294@aspeedtech.com> (raw)
In-Reply-To: <029CA29B-1488-4F73-A9E7-FB9BCD0B987F@aspeedtech.com>
Hi Rob,
On 2021/7/14, 12:02 PM, "Billy Tsai" <billy_tsai@aspeedtech.com> wrote:
On 2021/7/14, 6:14 AM, "Rob Herring" <robh@kernel.org> wrote:
On Fri, Jul 09, 2021 at 02:52:16PM +0800, Billy Tsai wrote:
>>> This patch adds device binding for aspeed pwm-tach device which is a
>>> multi-function device include pwm and tach function and pwm/tach device
>>> bindings which should be the child-node of pwm-tach device.
>>I'll say it again, the fan control h/w needs some common bindings for
>>describing fans and fan connections to pwm and tach. I'm not going to
>>sign off on more fan bindings just doing their own thing.
> This patch doesn't use to binding the fan control h/w. It is used to binding the two independent h/w blocks.
> One is used to provide pwm output and another is used to monitor the speed of the input.
> It is different from "aspeed-pwm-tacho.txt" and "npcm750-pwm-fan.txt" which only focus on fan usage.
> It is more like the "kontron,sl28cpld.yaml" the device includes a fan monitor and PWM output devices.
Can you give me more suggestions about this patch?
Thanks
next prev parent reply other threads:[~2021-10-04 1:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 6:52 [v9 0/2] Support pwm driver for aspeed ast26xx Billy Tsai
2021-07-09 6:52 ` [v9 1/2] dt-bindings: Add bindings for aspeed pwm-tach Billy Tsai
2021-07-13 22:14 ` Rob Herring
2021-07-14 4:02 ` Billy Tsai
2021-10-04 1:46 ` Billy Tsai [this message]
2021-07-09 6:52 ` [v9 2/2] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2021-07-15 15:05 ` Uwe Kleine-König
2021-07-16 1:48 ` Billy Tsai
2021-07-16 7:09 ` Uwe Kleine-König
2021-07-16 9:22 ` Billy Tsai
2021-07-16 10:13 ` Uwe Kleine-König
2021-07-16 10:56 ` Billy Tsai
2021-07-21 10:52 ` Billy Tsai
2021-07-21 12:48 ` Uwe Kleine-König
2021-07-23 4:23 ` Billy Tsai
2021-07-23 20:12 ` Uwe Kleine-König
2021-07-26 5:14 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A7C9DA11-6880-46EC-BD71-2E1984EBA294@aspeedtech.com \
--to=billy_tsai@aspeedtech.com \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).