* [PATCH] arm: dts: IPQ4019: add SDHCI VQMMC LDO node
@ 2020-09-07 10:19 Robert Marko
2020-10-02 17:38 ` Robert Marko
2021-01-25 16:50 ` Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Robert Marko @ 2020-09-07 10:19 UTC (permalink / raw)
To: agross, bjorn.andersson, robh+dt, linux-arm-msm, devicetree,
linux-kernel
Cc: Robert Marko, Luka Perkov
Since we now have driver for the SDHCI VQMMC LDO needed
for I/0 voltage levels lets introduce the necessary node for it.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Cc: Luka Perkov <luka.perkov@sartura.hr>
---
arch/arm/boot/dts/qcom-ipq4019.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
index 6741a1972e55..7774dbd3cec7 100644
--- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
@@ -211,6 +211,16 @@ tlmm: pinctrl@1000000 {
interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
};
+ vqmmc: regulator@1948000 {
+ compatible = "qcom,vqmmc-ipq4019-regulator";
+ reg = <0x01948000 0x4>;
+ regulator-name = "vqmmc";
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-always-on;
+ status = "disabled";
+ };
+
sdhci: sdhci@7824900 {
compatible = "qcom,sdhci-msm-v4";
reg = <0x7824900 0x11c>, <0x7824000 0x800>;
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: dts: IPQ4019: add SDHCI VQMMC LDO node
2020-09-07 10:19 [PATCH] arm: dts: IPQ4019: add SDHCI VQMMC LDO node Robert Marko
@ 2020-10-02 17:38 ` Robert Marko
2021-01-25 16:50 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Robert Marko @ 2020-10-02 17:38 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, robh+dt, linux-arm-msm, devicetree,
linux-kernel
Cc: Luka Perkov
On Mon, Sep 7, 2020 at 12:19 PM Robert Marko <robert.marko@sartura.hr> wrote:
>
> Since we now have driver for the SDHCI VQMMC LDO needed
> for I/0 voltage levels lets introduce the necessary node for it.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> ---
> arch/arm/boot/dts/qcom-ipq4019.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> index 6741a1972e55..7774dbd3cec7 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> @@ -211,6 +211,16 @@ tlmm: pinctrl@1000000 {
> interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + vqmmc: regulator@1948000 {
> + compatible = "qcom,vqmmc-ipq4019-regulator";
> + reg = <0x01948000 0x4>;
> + regulator-name = "vqmmc";
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-always-on;
> + status = "disabled";
> + };
> +
> sdhci: sdhci@7824900 {
> compatible = "qcom,sdhci-msm-v4";
> reg = <0x7824900 0x11c>, <0x7824000 0x800>;
> --
> 2.26.2
>
Hi,
Is there an issue with the patch preventing the review?
Regards,
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: dts: IPQ4019: add SDHCI VQMMC LDO node
2020-09-07 10:19 [PATCH] arm: dts: IPQ4019: add SDHCI VQMMC LDO node Robert Marko
2020-10-02 17:38 ` Robert Marko
@ 2021-01-25 16:50 ` Bjorn Andersson
2021-01-26 9:45 ` Robert Marko
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2021-01-25 16:50 UTC (permalink / raw)
To: Robert Marko
Cc: agross, robh+dt, linux-arm-msm, devicetree, linux-kernel, Luka Perkov
On Mon 07 Sep 05:19 CDT 2020, Robert Marko wrote:
> Since we now have driver for the SDHCI VQMMC LDO needed
> for I/0 voltage levels lets introduce the necessary node for it.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> ---
> arch/arm/boot/dts/qcom-ipq4019.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> index 6741a1972e55..7774dbd3cec7 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> @@ -211,6 +211,16 @@ tlmm: pinctrl@1000000 {
> interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + vqmmc: regulator@1948000 {
> + compatible = "qcom,vqmmc-ipq4019-regulator";
> + reg = <0x01948000 0x4>;
The actual hardware block where this register is found is the "TCSR"
which is 0x01947000 of size 0x21000 - making this the register at offset
0x11000.
Perhaps it would have been better represented as a simple-mfd with this
regulator as a child node thereof.
That said, this has been sitting long enough, so I'll merge it as is and
we can rework it once we need more pieces of tcsr.
Thanks,
Bjorn
> + regulator-name = "vqmmc";
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-always-on;
> + status = "disabled";
> + };
> +
> sdhci: sdhci@7824900 {
> compatible = "qcom,sdhci-msm-v4";
> reg = <0x7824900 0x11c>, <0x7824000 0x800>;
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm: dts: IPQ4019: add SDHCI VQMMC LDO node
2021-01-25 16:50 ` Bjorn Andersson
@ 2021-01-26 9:45 ` Robert Marko
0 siblings, 0 replies; 4+ messages in thread
From: Robert Marko @ 2021-01-26 9:45 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, robh+dt, linux-arm-msm, devicetree, linux-kernel,
Luka Perkov
On Mon, Jan 25, 2021 at 5:50 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Mon 07 Sep 05:19 CDT 2020, Robert Marko wrote:
>
> > Since we now have driver for the SDHCI VQMMC LDO needed
> > for I/0 voltage levels lets introduce the necessary node for it.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > Cc: Luka Perkov <luka.perkov@sartura.hr>
> > ---
> > arch/arm/boot/dts/qcom-ipq4019.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> > index 6741a1972e55..7774dbd3cec7 100644
> > --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> > @@ -211,6 +211,16 @@ tlmm: pinctrl@1000000 {
> > interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> > };
> >
> > + vqmmc: regulator@1948000 {
> > + compatible = "qcom,vqmmc-ipq4019-regulator";
> > + reg = <0x01948000 0x4>;
>
> The actual hardware block where this register is found is the "TCSR"
> which is 0x01947000 of size 0x21000 - making this the register at offset
> 0x11000.
>
> Perhaps it would have been better represented as a simple-mfd with this
> regulator as a child node thereof.
>
>
> That said, this has been sitting long enough, so I'll merge it as is and
> we can rework it once we need more pieces of tcsr.
Thanks,
I was unaware that it is part of TCSR as I don't have datasheets
and this was ported from multiple versions of the downstream driver.
Regards,
Robert
>
> Thanks,
> Bjorn
>
> > + regulator-name = "vqmmc";
> > + regulator-min-microvolt = <1500000>;
> > + regulator-max-microvolt = <3000000>;
> > + regulator-always-on;
> > + status = "disabled";
> > + };
> > +
> > sdhci: sdhci@7824900 {
> > compatible = "qcom,sdhci-msm-v4";
> > reg = <0x7824900 0x11c>, <0x7824000 0x800>;
> > --
> > 2.26.2
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-26 9:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 10:19 [PATCH] arm: dts: IPQ4019: add SDHCI VQMMC LDO node Robert Marko
2020-10-02 17:38 ` Robert Marko
2021-01-25 16:50 ` Bjorn Andersson
2021-01-26 9:45 ` Robert Marko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).