From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Benjamin Gaignard <benjamin.gaignard@st.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
pascal paillet <p.paillet@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-stm32@st-md-mailman.stormreply.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] dt-bindings: timer: Add STM32 Low Power Timer bindings
Date: Wed, 15 Jan 2020 15:45:51 +0100 [thread overview]
Message-ID: <CA+M3ks7FGZ9TMO0=yXrhZph1Cn1GQ+2-tM7SnDrRDXVoCjrTjA@mail.gmail.com> (raw)
In-Reply-To: <20200115143521.GA15099@bogus>
Le mer. 15 janv. 2020 à 15:35, Rob Herring <robh@kernel.org> a écrit :
>
> On Thu, Jan 09, 2020 at 03:53:31PM +0100, Benjamin Gaignard wrote:
> > Document STM32 Low Power bindings.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> > ---
> > .../bindings/timer/st,stm32-lp-timer.yaml | 44 ++++++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml b/Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml
> > new file mode 100644
> > index 000000000000..ca040b96dc47
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml
>
> Use the compatible for the filename.
it will be in v2
>
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/timer/st,stm32-lp-timer.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: STMicroelectronics STM32 Low Power 16 bits timers bindings
> > +
> > +maintainers:
> > + - Benjamin Gaignard <benjamin.gaignard@st.com>
> > +
> > +properties:
> > + compatible:
> > + const: st,stm32-lptimer-clkevent
>
> 'clkevent' is a h/w name? Seems redundant and abusing compatible to
> bind to a specific Linux driver.
No but st,stm32-lptimer compatible is already used for another driver
The hardware block can implement multiple features but not all at the same time
so I try to distinguish them with the compatible.
In this particular case I would like tag it as a clock event driver.
>
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/stm32mp1-clks.h>
> > + clkevent: clkevent@40009000 {
>
> timer@...
OK
>
> > + compatible = "st,stm32-lptimer-clkevent";
> > + reg = <0x40009000 0x400>;
> > + clocks = <&rcc LPTIM1_K>;
> > + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
> > + };
> > +
> > +...
> > --
> > 2.15.0
> >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-15 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 14:53 [PATCH 0/3] clockevent: add low power STM32 timer Benjamin Gaignard
2020-01-09 14:53 ` [PATCH 1/3] dt-bindings: timer: Add STM32 Low Power Timer bindings Benjamin Gaignard
2020-01-15 14:35 ` Rob Herring
2020-01-15 14:45 ` Benjamin Gaignard [this message]
2020-01-15 19:00 ` Rob Herring
2020-01-15 19:17 ` Benjamin Gaignard
2020-01-09 14:53 ` [PATCH 2/3] clocksource: Add Low Power STM32 timers driver Benjamin Gaignard
2020-01-16 9:06 ` Linus Walleij
2020-01-16 15:44 ` Benjamin Gaignard
2020-01-16 15:53 ` Linus Walleij
2020-01-09 14:53 ` [PATCH 3/3] ARM: stm32: select STM32 low power timer clock event driver Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+M3ks7FGZ9TMO0=yXrhZph1Cn1GQ+2-tM7SnDrRDXVoCjrTjA@mail.gmail.com' \
--to=benjamin.gaignard@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.paillet@st.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).