From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Benjamin Gaignard <benjamin.gaignard@st.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Russell King <linux@armlinux.org.uk>,
Pascal PAILLET-LME <p.paillet@st.com>,
Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-stm32@st-md-mailman.stormreply.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] clocksource: Add Low Power STM32 timers driver
Date: Thu, 16 Jan 2020 16:44:26 +0100 [thread overview]
Message-ID: <CA+M3ks7s_KOhXciJPZc3N4z9GNkiKa=fWdQ3hC_HTtrWMWYHtQ@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdaK+kQZH_Txu-r4DY_m6muh26aCWcGOkxbi8hbCgww28A@mail.gmail.com>
Le jeu. 16 janv. 2020 à 10:07, Linus Walleij
<linus.walleij@linaro.org> a écrit :
>
> On Thu, Jan 9, 2020 at 3:54 PM Benjamin Gaignard
> <benjamin.gaignard@st.com> wrote:
>
> > Implement clock event driver using low power STM32 timers.
> > Low power timers counter s running even in when CPU is in stop mode.
> > It could be used as clock event broadcaster to wake up CPUs but not like
> > a clocksource because each it rise an interrupt the counter restart from 0.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> > Signed-off-by: Pascal Paillet <p.paillet@st.com>
>
> Looks good to me:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Hi Linus,
Thanks for your review. I had to rework a bit the driver to solve the
bindings issues
so I haven't put your RB on version 2.
>
> If you have a spare always-on timer (and it looks like you have) which
> you can set as free-running, you could register it with
> CLOCK_SOURCE_SUSPEND_NONSTOP so it
The driver only implement clock event feature so I don't think that is
flag is applicable.
Regards,
Benjamin
> keeps the system clock ticking also during suspend as
> alternative clock source.
>
> Yours,
> Linus Walleij
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-16 15:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 14:53 [PATCH 0/3] clockevent: add low power STM32 timer Benjamin Gaignard
2020-01-09 14:53 ` [PATCH 1/3] dt-bindings: timer: Add STM32 Low Power Timer bindings Benjamin Gaignard
2020-01-15 14:35 ` Rob Herring
2020-01-15 14:45 ` Benjamin Gaignard
2020-01-15 19:00 ` Rob Herring
2020-01-15 19:17 ` Benjamin Gaignard
2020-01-09 14:53 ` [PATCH 2/3] clocksource: Add Low Power STM32 timers driver Benjamin Gaignard
2020-01-16 9:06 ` Linus Walleij
2020-01-16 15:44 ` Benjamin Gaignard [this message]
2020-01-16 15:53 ` Linus Walleij
2020-01-09 14:53 ` [PATCH 3/3] ARM: stm32: select STM32 low power timer clock event driver Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+M3ks7s_KOhXciJPZc3N4z9GNkiKa=fWdQ3hC_HTtrWMWYHtQ@mail.gmail.com' \
--to=benjamin.gaignard@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=baolin.wang7@gmail.com \
--cc=benjamin.gaignard@st.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.paillet@st.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).