[PATCH v2 0/2] combine bindings for simple panels in a few files

[PATCH v2 0/2] combine bindings for simple panels in a few files

[Sam Ravnborg]

This patchset introduces two files:

    panel-simple.yaml
    panel-simple-dsi.yaml

The two files will be used for bindings for simple
panels that have only a single power-supply.

For now only a few bindings are migrated - the
reamining bindings will be migrated when we have agreed
on the format.

v2:
  - updated binding description in panel-simple.yaml
  - fixed exampe in panel-simple.yaml
    (I was missing libyaml-dev - now the examples are checked properly here)
  - added panel-simple-dsi.yaml

	Sam 

Sam Ravnborg (2):
      dt-bindings: one binding file for all simple panels
      dt-bindings: one file of all simple DSI panels

 .../display/panel/ampire,am-480272h3tmqw-t01h.yaml | 42 --------------
 .../display/panel/ampire,am800480r3tmqwa1h.txt     |  7 ---
 .../display/panel/panasonic,vvx10f034n00.txt       | 20 -------
 .../bindings/display/panel/panel-simple-dsi.yaml   | 67 ++++++++++++++++++++++
 .../bindings/display/panel/panel-simple.yaml       | 59 +++++++++++++++++++
 5 files changed, 126 insertions(+), 69 deletions(-)

[PATCH v2 1/2] dt-bindings: one binding file for all simple panels

[Sam Ravnborg]

There is an increasing number of new simple panels.
Common for many of these simple panels are that they have one
mandatory power-supply and some of them have backlight and / or
an enable gpio.

The binding file to describe these panels adds overhead
that really do not add value.
The binding are known and there is nothing gained from a
dedicated binding file nor for any dedicated example.

The following patch introduces a single panel-simple.yaml
and converts two ampire bindings over to the new file.

The conversion - if applied will have following effects:

- The maintainer for the individual file will change
    There is no need for many different maintainers for a simple binding.
    We have the same situation with the panel-simple driver in the kernel.

- The license will change to (GPL-2.0-only OR BSD-2-Clause)
    There is usually only a single line copied from the original
    file, a line that is often copied from a datasheet.
    This license change should be acceptable considered what little
    is copied.
    If the license change is not OK we can use a dedicated binding
    file in these cases.

This is a follow-up on Rob's big patch converting a lot of panel bindings
to individual files:

"dt-bindings: display: Convert a bunch of panels to DT schema"
https://patchwork.ozlabs.org/patch/1197683/

The objectives with one file for the relevant simple panels are:
- Make it simpler to add bindings for simple panels
- Keep the number of bindings file lower and thus easier to find a
  relevant file to copy from when adding new panels.
- Keep the binding documentation for simple panels more consistent
- Make it simpler to add support for new panels

v2:
  - spelling fixes (imirkin via irc, Rob)
  - updated description (Rob)
  - list properires in alphabetical order
  - added power-supply to example (Rob)
  - updated title
  - reworded changelog a little

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Yannick Fertre <yannick.fertre@st.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org
---
 .../panel/ampire,am-480272h3tmqw-t01h.yaml    | 42 -------------
 .../panel/ampire,am800480r3tmqwa1h.txt        |  7 ---
 .../bindings/display/panel/panel-simple.yaml  | 59 +++++++++++++++++++
 3 files changed, 59 insertions(+), 49 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml b/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
deleted file mode 100644
index c6e33e7f36d0..000000000000
--- a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
+++ /dev/null
@@ -1,42 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/display/panel/ampire,am-480272h3tmqw-t01h.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
-
-maintainers:
-  - Yannick Fertre <yannick.fertre@st.com>
-  - Thierry Reding <treding@nvidia.com>
-
-allOf:
-  - $ref: panel-common.yaml#
-
-properties:
-  compatible:
-    const: ampire,am-480272h3tmqw-t01h
-
-  power-supply: true
-  enable-gpios: true
-  backlight: true
-  port: true
-
-required:
-  - compatible
-
-additionalProperties: false
-
-examples:
-  - |
-    panel_rgb: panel {
-      compatible = "ampire,am-480272h3tmqw-t01h";
-      enable-gpios = <&gpioa 8 1>;
-      port {
-        panel_in_rgb: endpoint {
-          remote-endpoint = <&controller_out_rgb>;
-        };
-      };
-    };
-
-...
diff --git a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt b/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
deleted file mode 100644
index 83e2cae1cc1b..000000000000
--- a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
-
-Required properties:
-- compatible: should be "ampire,am800480r3tmqwa1h"
-
-This binding is compatible with the simple-panel binding, which is specified
-in simple-panel.txt in this directory.
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
new file mode 100644
index 000000000000..51ca50201182
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/panel-simple.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Simple panels with one power supply
+
+maintainers:
+  - Thierry Reding <thierry.reding@gmail.com>
+  - Sam Ravnborg <sam@ravnborg.org>
+
+description: |
+  This binding file is a collection of the simple (dumb) panels that
+  requires only a single power-supply.
+  There are optionally a backlight and an enable GPIO.
+  The panel may use an OF graph binding for the association to the display,
+  or it may be a direct child node of the display.
+
+  If the panel is more advanced a dedicated binding file is required. 
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+
+  compatible:
+    enum:
+    # compatible must be listed in alphabetical order, ordered by compatible.
+    # The description in the comment is mandatory for each compatible.
+
+    # Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
+    - ampire,am-480272h3tmqw-t01h
+    # Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
+    - ampire,am800480r3tmqwa1h
+
+  backlight: true
+  enable-gpios: true
+  port: true
+  power-supply: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - power-supply
+
+examples:
+  - |
+    panel_rgb: panel-rgb {
+      compatible = "ampire,am-480272h3tmqw-t01h";
+      power-supply = <&vcc_lcd_reg>;
+
+      port {
+        panel_in_rgb: endpoint {
+          remote-endpoint = <&ltdc_out_rgb>;
+        };
+      };
+    };
-- 
2.20.1

[PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

[Sam Ravnborg]

To complement panel-simple.yaml, create panel-simple-dsi.yaml.
panel-simple-dsi-yaml are for all simple DSP panels with a single
power-supply and optional backlight / enable GPIO.

Migrate panasonic,vvx10f034n00 over to the new file.

The objectives with one file for all the simple DSI panels are:
    - Make it simpler to add bindings for simple DSI panels
    - Keep the number of bindings file lower
    - Keep the binding documentation for simple DSI panels more consistent

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Yannick Fertre <yannick.fertre@st.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org
---
 .../display/panel/panasonic,vvx10f034n00.txt  | 20 ------
 .../display/panel/panel-simple-dsi.yaml       | 67 +++++++++++++++++++
 2 files changed, 67 insertions(+), 20 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt b/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
deleted file mode 100644
index 37dedf6a6702..000000000000
--- a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-Panasonic 10" WUXGA TFT LCD panel
-
-Required properties:
-- compatible: should be "panasonic,vvx10f034n00"
-- reg: DSI virtual channel of the peripheral
-- power-supply: phandle of the regulator that provides the supply voltage
-
-Optional properties:
-- backlight: phandle of the backlight device attached to the panel
-
-Example:
-
-	mdss_dsi@fd922800 {
-		panel@0 {
-			compatible = "panasonic,vvx10f034n00";
-			reg = <0>;
-			power-supply = <&vreg_vsp>;
-			backlight = <&lp8566_wled>;
-		};
-	};
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
new file mode 100644
index 000000000000..05c52390269e
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/panel-simple-dsi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Simple DSI panels with a single power-supply
+
+maintainers:
+  - Thierry Reding <thierry.reding@gmail.com>
+  - Sam Ravnborg <sam@ravnborg.org>
+
+description: |
+  This binding file is a collection of the DSI panels that
+  requires only a single power-supply.
+  There are optionally a backlight and an enable GPIO.
+  The panel may use an OF graph binding for the association to the display,
+  or it may be a direct child node of the display.
+
+  If the panel is more advanced a dedicated binding file is required.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+
+  compatible:
+    enum:
+    # compatible must be listed in alphabetical order, ordered by compatible.
+    # The description in the comment is mandatory for each compatible.
+
+    # Panasonic 10" WUXGA TFT LCD panel
+    - panasonic,vvx10f034n00
+
+  reg:
+    maxItems: 1
+    description: DSI virtual channel
+
+  backlight: true
+  enable-gpios: true
+  port: true
+  power-supply: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - power-supply
+  - reg
+
+examples:
+  - |
+    mdss_dsi@fd922800 {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      panel@0 {
+        compatible = "panasonic,vvx10f034n00";
+        reg = <0>;
+        power-supply = <&vcc_lcd_reg>;
+
+        port {
+          panel: endpoint {
+            remote-endpoint = <&ltdc_out>;
+          };
+        };
+      };
+    };
-- 
2.20.1

Re: [PATCH v2 0/2] combine bindings for simple panels in a few files

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

On Thu, Jan 02, 2020 at 11:17:10AM +0100, Sam Ravnborg wrote:
> This patchset introduces two files:
> 
>     panel-simple.yaml
>     panel-simple-dsi.yaml
> 
> The two files will be used for bindings for simple
> panels that have only a single power-supply.
> 
> For now only a few bindings are migrated - the
> reamining bindings will be migrated when we have agreed
> on the format.
> 
> v2:
>   - updated binding description in panel-simple.yaml
>   - fixed exampe in panel-simple.yaml
>     (I was missing libyaml-dev - now the examples are checked properly here)
>   - added panel-simple-dsi.yaml
> 
> 	Sam 
> 
> Sam Ravnborg (2):
>       dt-bindings: one binding file for all simple panels
>       dt-bindings: one file of all simple DSI panels
> 
>  .../display/panel/ampire,am-480272h3tmqw-t01h.yaml | 42 --------------
>  .../display/panel/ampire,am800480r3tmqwa1h.txt     |  7 ---
>  .../display/panel/panasonic,vvx10f034n00.txt       | 20 -------
>  .../bindings/display/panel/panel-simple-dsi.yaml   | 67 ++++++++++++++++++++++
>  .../bindings/display/panel/panel-simple.yaml       | 59 +++++++++++++++++++
>  5 files changed, 126 insertions(+), 69 deletions(-)

I like this. With the improved structure that the YAML bindings provide
this becomes rather neat. You may want to update the subject of the
patches to better reflect the style (most seem to use "dt-bindings:
display: " as prefix, for example). But overall, looks good:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 1/2] dt-bindings: one binding file for all simple panels

[Benjamin Gaignard]

Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg <sam@ravnborg.org> a écrit :
>
> There is an increasing number of new simple panels.
> Common for many of these simple panels are that they have one
> mandatory power-supply and some of them have backlight and / or
> an enable gpio.
>
> The binding file to describe these panels adds overhead
> that really do not add value.
> The binding are known and there is nothing gained from a
> dedicated binding file nor for any dedicated example.
>
> The following patch introduces a single panel-simple.yaml
> and converts two ampire bindings over to the new file.
>
> The conversion - if applied will have following effects:
>
> - The maintainer for the individual file will change
>     There is no need for many different maintainers for a simple binding.
>     We have the same situation with the panel-simple driver in the kernel.
>
> - The license will change to (GPL-2.0-only OR BSD-2-Clause)
>     There is usually only a single line copied from the original
>     file, a line that is often copied from a datasheet.
>     This license change should be acceptable considered what little
>     is copied.
>     If the license change is not OK we can use a dedicated binding
>     file in these cases.
>
> This is a follow-up on Rob's big patch converting a lot of panel bindings
> to individual files:
>
> "dt-bindings: display: Convert a bunch of panels to DT schema"
> https://patchwork.ozlabs.org/patch/1197683/
>
> The objectives with one file for the relevant simple panels are:
> - Make it simpler to add bindings for simple panels
> - Keep the number of bindings file lower and thus easier to find a
>   relevant file to copy from when adding new panels.
> - Keep the binding documentation for simple panels more consistent
> - Make it simpler to add support for new panels
>
> v2:
>   - spelling fixes (imirkin via irc, Rob)
>   - updated description (Rob)
>   - list properires in alphabetical order
>   - added power-supply to example (Rob)
>   - updated title
>   - reworded changelog a little
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Yannick Fertre <yannick.fertre@st.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicetree@vger.kernel.org
> ---
>  .../panel/ampire,am-480272h3tmqw-t01h.yaml    | 42 -------------
>  .../panel/ampire,am800480r3tmqwa1h.txt        |  7 ---
>  .../bindings/display/panel/panel-simple.yaml  | 59 +++++++++++++++++++
>  3 files changed, 59 insertions(+), 49 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml b/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
> deleted file mode 100644
> index c6e33e7f36d0..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0
> -%YAML 1.2
> ----
> -$id: http://devicetree.org/schemas/display/panel/ampire,am-480272h3tmqw-t01h.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
> -
> -maintainers:
> -  - Yannick Fertre <yannick.fertre@st.com>
> -  - Thierry Reding <treding@nvidia.com>
> -
> -allOf:
> -  - $ref: panel-common.yaml#
> -
> -properties:
> -  compatible:
> -    const: ampire,am-480272h3tmqw-t01h
> -
> -  power-supply: true
> -  enable-gpios: true
> -  backlight: true
> -  port: true
> -
> -required:
> -  - compatible
> -
> -additionalProperties: false
> -
> -examples:
> -  - |
> -    panel_rgb: panel {
> -      compatible = "ampire,am-480272h3tmqw-t01h";
> -      enable-gpios = <&gpioa 8 1>;
> -      port {
> -        panel_in_rgb: endpoint {
> -          remote-endpoint = <&controller_out_rgb>;
> -        };
> -      };
> -    };
> -
> -...
> diff --git a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt b/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
> deleted file mode 100644
> index 83e2cae1cc1b..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "ampire,am800480r3tmqwa1h"
> -
> -This binding is compatible with the simple-panel binding, which is specified
> -in simple-panel.txt in this directory.
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> new file mode 100644
> index 000000000000..51ca50201182
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/panel-simple.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Simple panels with one power supply
> +
> +maintainers:
> +  - Thierry Reding <thierry.reding@gmail.com>
> +  - Sam Ravnborg <sam@ravnborg.org>
> +
> +description: |
> +  This binding file is a collection of the simple (dumb) panels that
> +  requires only a single power-supply.
> +  There are optionally a backlight and an enable GPIO.
> +  The panel may use an OF graph binding for the association to the display,
> +  or it may be a direct child node of the display.
> +
> +  If the panel is more advanced a dedicated binding file is required.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +
> +  compatible:
> +    enum:
> +    # compatible must be listed in alphabetical order, ordered by compatible.
> +    # The description in the comment is mandatory for each compatible.
> +
> +    # Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
> +    - ampire,am-480272h3tmqw-t01h
> +    # Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
> +    - ampire,am800480r3tmqwa1h
> +
> +  backlight: true
> +  enable-gpios: true
> +  port: true
> +  power-supply: true
> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - power-supply

Hi Sam,

power-supply property should be optional like it was in
ampire,am-480272h3tmqw-t01h.yaml
else it looks good for me.

Benjamin

> +
> +examples:
> +  - |
> +    panel_rgb: panel-rgb {
> +      compatible = "ampire,am-480272h3tmqw-t01h";
> +      power-supply = <&vcc_lcd_reg>;
> +
> +      port {
> +        panel_in_rgb: endpoint {
> +          remote-endpoint = <&ltdc_out_rgb>;
> +        };
> +      };
> +    };
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

[Benjamin Gaignard]

Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg <sam@ravnborg.org> a écrit :
>
> To complement panel-simple.yaml, create panel-simple-dsi.yaml.
> panel-simple-dsi-yaml are for all simple DSP panels with a single
> power-supply and optional backlight / enable GPIO.
>
> Migrate panasonic,vvx10f034n00 over to the new file.
>
> The objectives with one file for all the simple DSI panels are:
>     - Make it simpler to add bindings for simple DSI panels
>     - Keep the number of bindings file lower
>     - Keep the binding documentation for simple DSI panels more consistent
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Yannick Fertre <yannick.fertre@st.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicetree@vger.kernel.org
> ---
>  .../display/panel/panasonic,vvx10f034n00.txt  | 20 ------
>  .../display/panel/panel-simple-dsi.yaml       | 67 +++++++++++++++++++
>  2 files changed, 67 insertions(+), 20 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt b/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> deleted file mode 100644
> index 37dedf6a6702..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -Panasonic 10" WUXGA TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "panasonic,vvx10f034n00"
> -- reg: DSI virtual channel of the peripheral
> -- power-supply: phandle of the regulator that provides the supply voltage
> -
> -Optional properties:
> -- backlight: phandle of the backlight device attached to the panel
> -
> -Example:
> -
> -       mdss_dsi@fd922800 {
> -               panel@0 {
> -                       compatible = "panasonic,vvx10f034n00";
> -                       reg = <0>;
> -                       power-supply = <&vreg_vsp>;
> -                       backlight = <&lp8566_wled>;
> -               };
> -       };
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> new file mode 100644
> index 000000000000..05c52390269e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/panel-simple-dsi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Simple DSI panels with a single power-supply
> +
> +maintainers:
> +  - Thierry Reding <thierry.reding@gmail.com>
> +  - Sam Ravnborg <sam@ravnborg.org>
> +
> +description: |
> +  This binding file is a collection of the DSI panels that
> +  requires only a single power-supply.
> +  There are optionally a backlight and an enable GPIO.
> +  The panel may use an OF graph binding for the association to the display,
> +  or it may be a direct child node of the display.
> +
> +  If the panel is more advanced a dedicated binding file is required.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +
> +  compatible:
> +    enum:
> +    # compatible must be listed in alphabetical order, ordered by compatible.
> +    # The description in the comment is mandatory for each compatible.
> +
> +    # Panasonic 10" WUXGA TFT LCD panel
> +    - panasonic,vvx10f034n00

Hi Sam,

I have tested your patch with these 2 dsi panels:
# Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD
  - orisetech,otm8009a
 # Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280 TFT LCD
   - raydium,rm68200

It is close to be fine for me but I have minors comments below.

Benjamin

> +
> +  reg:
> +    maxItems: 1
> +    description: DSI virtual channel
> +
> +  backlight: true
> +  enable-gpios: true
> +  port: true
> +  power-supply: true

add reset-gpios: true to support orisetech panel

> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - power-supply

power-supply should optional

> +  - reg
> +
> +examples:
> +  - |
> +    mdss_dsi@fd922800 {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      panel@0 {
> +        compatible = "panasonic,vvx10f034n00";
> +        reg = <0>;
> +        power-supply = <&vcc_lcd_reg>;
> +
> +        port {
> +          panel: endpoint {
> +            remote-endpoint = <&ltdc_out>;
> +          };
> +        };
> +      };
> +    };
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

[Rob Herring]

On Tue, Jan 7, 2020 at 9:44 AM Benjamin Gaignard
<benjamin.gaignard@linaro.org> wrote:
>
> Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg <sam@ravnborg.org> a écrit :
> >
> > To complement panel-simple.yaml, create panel-simple-dsi.yaml.
> > panel-simple-dsi-yaml are for all simple DSP panels with a single
> > power-supply and optional backlight / enable GPIO.
> >
> > Migrate panasonic,vvx10f034n00 over to the new file.
> >
> > The objectives with one file for all the simple DSI panels are:
> >     - Make it simpler to add bindings for simple DSI panels
> >     - Keep the number of bindings file lower
> >     - Keep the binding documentation for simple DSI panels more consistent
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Yannick Fertre <yannick.fertre@st.com>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: devicetree@vger.kernel.org
> > ---
> >  .../display/panel/panasonic,vvx10f034n00.txt  | 20 ------
> >  .../display/panel/panel-simple-dsi.yaml       | 67 +++++++++++++++++++
> >  2 files changed, 67 insertions(+), 20 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt b/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> > deleted file mode 100644
> > index 37dedf6a6702..000000000000
> > --- a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> > +++ /dev/null
> > @@ -1,20 +0,0 @@
> > -Panasonic 10" WUXGA TFT LCD panel
> > -
> > -Required properties:
> > -- compatible: should be "panasonic,vvx10f034n00"
> > -- reg: DSI virtual channel of the peripheral
> > -- power-supply: phandle of the regulator that provides the supply voltage
> > -
> > -Optional properties:
> > -- backlight: phandle of the backlight device attached to the panel
> > -
> > -Example:
> > -
> > -       mdss_dsi@fd922800 {
> > -               panel@0 {
> > -                       compatible = "panasonic,vvx10f034n00";
> > -                       reg = <0>;
> > -                       power-supply = <&vreg_vsp>;
> > -                       backlight = <&lp8566_wled>;
> > -               };
> > -       };
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > new file mode 100644
> > index 000000000000..05c52390269e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > @@ -0,0 +1,67 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/panel-simple-dsi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Simple DSI panels with a single power-supply
> > +
> > +maintainers:
> > +  - Thierry Reding <thierry.reding@gmail.com>
> > +  - Sam Ravnborg <sam@ravnborg.org>
> > +
> > +description: |
> > +  This binding file is a collection of the DSI panels that
> > +  requires only a single power-supply.
> > +  There are optionally a backlight and an enable GPIO.
> > +  The panel may use an OF graph binding for the association to the display,
> > +  or it may be a direct child node of the display.
> > +
> > +  If the panel is more advanced a dedicated binding file is required.
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +
> > +  compatible:
> > +    enum:
> > +    # compatible must be listed in alphabetical order, ordered by compatible.
> > +    # The description in the comment is mandatory for each compatible.
> > +
> > +    # Panasonic 10" WUXGA TFT LCD panel
> > +    - panasonic,vvx10f034n00
>
> Hi Sam,
>
> I have tested your patch with these 2 dsi panels:
> # Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD
>   - orisetech,otm8009a
>  # Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280 TFT LCD
>    - raydium,rm68200
>
> It is close to be fine for me but I have minors comments below.
>
> Benjamin
>
> > +
> > +  reg:
> > +    maxItems: 1
> > +    description: DSI virtual channel
> > +
> > +  backlight: true
> > +  enable-gpios: true
> > +  port: true
> > +  power-supply: true
>
> add reset-gpios: true to support orisetech panel

Nope. If not a single GPIO and single supply, not a simple panel.

Maybe reset could be allowed, but we have to draw the line somewhere.

> > +
> > +additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - power-supply
>
> power-supply should optional

The panel works without power? The dts should have a fixed supply if
not controllable.

Here's the problem. If it is not required, then panels with multiple
supplies will get added here because they didn't care to begin with.
Then when someone decides to think about the supplies it will have to
be moved. Bindings need to be complete from the start.

Rob

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

[Rob Herring]

On Thu, Jan 2, 2020 at 4:17 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> To complement panel-simple.yaml, create panel-simple-dsi.yaml.
> panel-simple-dsi-yaml are for all simple DSP panels with a single
> power-supply and optional backlight / enable GPIO.
>
> Migrate panasonic,vvx10f034n00 over to the new file.
>
> The objectives with one file for all the simple DSI panels are:
>     - Make it simpler to add bindings for simple DSI panels
>     - Keep the number of bindings file lower
>     - Keep the binding documentation for simple DSI panels more consistent
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Yannick Fertre <yannick.fertre@st.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicetree@vger.kernel.org
> ---
>  .../display/panel/panasonic,vvx10f034n00.txt  | 20 ------
>  .../display/panel/panel-simple-dsi.yaml       | 67 +++++++++++++++++++
>  2 files changed, 67 insertions(+), 20 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml

Reviewed-by: Rob Herring <robh@kernel.org>

>
> diff --git a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt b/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> deleted file mode 100644
> index 37dedf6a6702..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -Panasonic 10" WUXGA TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "panasonic,vvx10f034n00"
> -- reg: DSI virtual channel of the peripheral
> -- power-supply: phandle of the regulator that provides the supply voltage
> -
> -Optional properties:
> -- backlight: phandle of the backlight device attached to the panel
> -
> -Example:
> -
> -       mdss_dsi@fd922800 {
> -               panel@0 {
> -                       compatible = "panasonic,vvx10f034n00";
> -                       reg = <0>;
> -                       power-supply = <&vreg_vsp>;
> -                       backlight = <&lp8566_wled>;
> -               };
> -       };
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> new file mode 100644
> index 000000000000..05c52390269e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/panel-simple-dsi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Simple DSI panels with a single power-supply
> +
> +maintainers:
> +  - Thierry Reding <thierry.reding@gmail.com>
> +  - Sam Ravnborg <sam@ravnborg.org>
> +
> +description: |
> +  This binding file is a collection of the DSI panels that
> +  requires only a single power-supply.
> +  There are optionally a backlight and an enable GPIO.
> +  The panel may use an OF graph binding for the association to the display,
> +  or it may be a direct child node of the display.
> +
> +  If the panel is more advanced a dedicated binding file is required.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +
> +  compatible:
> +    enum:
> +    # compatible must be listed in alphabetical order, ordered by compatible.
> +    # The description in the comment is mandatory for each compatible.

To answer your irc question, this is fine. You could do it like this instead:

oneOf:
  - description: ...
    const: compat-string
  - description: ...
    const: compat-string-2

The advantage is being able to extract 'description' if say you wanted
to generate documentation. Even so, I somewhat prefer how you have it.

> +
> +    # Panasonic 10" WUXGA TFT LCD panel

I'd align the # with the string to keep the list '-' a bit more
visible. IOW, 2 more spaces (before my next comment).

> +    - panasonic,vvx10f034n00

This should be indented 2 more spaces.

BTW, I extracted all the panels from my patch with this:

git show | grep -E '(title|const)' | sed -e 's/\+title:/  #/' -e 's/+
  const:/\-/'

There's a few with more than just 'title'.

Rob

Re: [PATCH v2 1/2] dt-bindings: one binding file for all simple panels

[Rob Herring]

On Thu, Jan 2, 2020 at 4:17 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> There is an increasing number of new simple panels.
> Common for many of these simple panels are that they have one
> mandatory power-supply and some of them have backlight and / or
> an enable gpio.
>
> The binding file to describe these panels adds overhead
> that really do not add value.
> The binding are known and there is nothing gained from a
> dedicated binding file nor for any dedicated example.
>
> The following patch introduces a single panel-simple.yaml
> and converts two ampire bindings over to the new file.
>
> The conversion - if applied will have following effects:
>
> - The maintainer for the individual file will change
>     There is no need for many different maintainers for a simple binding.
>     We have the same situation with the panel-simple driver in the kernel.
>
> - The license will change to (GPL-2.0-only OR BSD-2-Clause)
>     There is usually only a single line copied from the original
>     file, a line that is often copied from a datasheet.
>     This license change should be acceptable considered what little
>     is copied.
>     If the license change is not OK we can use a dedicated binding
>     file in these cases.
>
> This is a follow-up on Rob's big patch converting a lot of panel bindings
> to individual files:
>
> "dt-bindings: display: Convert a bunch of panels to DT schema"
> https://patchwork.ozlabs.org/patch/1197683/
>
> The objectives with one file for the relevant simple panels are:
> - Make it simpler to add bindings for simple panels
> - Keep the number of bindings file lower and thus easier to find a
>   relevant file to copy from when adding new panels.
> - Keep the binding documentation for simple panels more consistent
> - Make it simpler to add support for new panels
>
> v2:
>   - spelling fixes (imirkin via irc, Rob)
>   - updated description (Rob)
>   - list properires in alphabetical order
>   - added power-supply to example (Rob)
>   - updated title
>   - reworded changelog a little
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Yannick Fertre <yannick.fertre@st.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicetree@vger.kernel.org
> ---
>  .../panel/ampire,am-480272h3tmqw-t01h.yaml    | 42 -------------
>  .../panel/ampire,am800480r3tmqwa1h.txt        |  7 ---
>  .../bindings/display/panel/panel-simple.yaml  | 59 +++++++++++++++++++
>  3 files changed, 59 insertions(+), 49 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple.yaml

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

[Benjamin Gaignard]

Le mar. 7 janv. 2020 à 18:05, Rob Herring <robh@kernel.org> a écrit :
>
> On Tue, Jan 7, 2020 at 9:44 AM Benjamin Gaignard
> <benjamin.gaignard@linaro.org> wrote:
> >
> > Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg <sam@ravnborg.org> a écrit :
> > >
> > > To complement panel-simple.yaml, create panel-simple-dsi.yaml.
> > > panel-simple-dsi-yaml are for all simple DSP panels with a single
> > > power-supply and optional backlight / enable GPIO.
> > >
> > > Migrate panasonic,vvx10f034n00 over to the new file.
> > >
> > > The objectives with one file for all the simple DSI panels are:
> > >     - Make it simpler to add bindings for simple DSI panels
> > >     - Keep the number of bindings file lower
> > >     - Keep the binding documentation for simple DSI panels more consistent
> > >
> > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > Cc: Rob Herring <robh@kernel.org>
> > > Cc: Maxime Ripard <mripard@kernel.org>
> > > Cc: Yannick Fertre <yannick.fertre@st.com>
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: dri-devel@lists.freedesktop.org
> > > Cc: devicetree@vger.kernel.org
> > > ---
> > >  .../display/panel/panasonic,vvx10f034n00.txt  | 20 ------
> > >  .../display/panel/panel-simple-dsi.yaml       | 67 +++++++++++++++++++
> > >  2 files changed, 67 insertions(+), 20 deletions(-)
> > >  delete mode 100644 Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> > >  create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt b/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> > > deleted file mode 100644
> > > index 37dedf6a6702..000000000000
> > > --- a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> > > +++ /dev/null
> > > @@ -1,20 +0,0 @@
> > > -Panasonic 10" WUXGA TFT LCD panel
> > > -
> > > -Required properties:
> > > -- compatible: should be "panasonic,vvx10f034n00"
> > > -- reg: DSI virtual channel of the peripheral
> > > -- power-supply: phandle of the regulator that provides the supply voltage
> > > -
> > > -Optional properties:
> > > -- backlight: phandle of the backlight device attached to the panel
> > > -
> > > -Example:
> > > -
> > > -       mdss_dsi@fd922800 {
> > > -               panel@0 {
> > > -                       compatible = "panasonic,vvx10f034n00";
> > > -                       reg = <0>;
> > > -                       power-supply = <&vreg_vsp>;
> > > -                       backlight = <&lp8566_wled>;
> > > -               };
> > > -       };
> > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > > new file mode 100644
> > > index 000000000000..05c52390269e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > > @@ -0,0 +1,67 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/panel-simple-dsi.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Simple DSI panels with a single power-supply
> > > +
> > > +maintainers:
> > > +  - Thierry Reding <thierry.reding@gmail.com>
> > > +  - Sam Ravnborg <sam@ravnborg.org>
> > > +
> > > +description: |
> > > +  This binding file is a collection of the DSI panels that
> > > +  requires only a single power-supply.
> > > +  There are optionally a backlight and an enable GPIO.
> > > +  The panel may use an OF graph binding for the association to the display,
> > > +  or it may be a direct child node of the display.
> > > +
> > > +  If the panel is more advanced a dedicated binding file is required.
> > > +
> > > +allOf:
> > > +  - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > +
> > > +  compatible:
> > > +    enum:
> > > +    # compatible must be listed in alphabetical order, ordered by compatible.
> > > +    # The description in the comment is mandatory for each compatible.
> > > +
> > > +    # Panasonic 10" WUXGA TFT LCD panel
> > > +    - panasonic,vvx10f034n00
> >
> > Hi Sam,
> >
> > I have tested your patch with these 2 dsi panels:
> > # Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD
> >   - orisetech,otm8009a
> >  # Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280 TFT LCD
> >    - raydium,rm68200
> >
> > It is close to be fine for me but I have minors comments below.
> >
> > Benjamin
> >
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +    description: DSI virtual channel
> > > +
> > > +  backlight: true
> > > +  enable-gpios: true
> > > +  port: true
> > > +  power-supply: true
> >
> > add reset-gpios: true to support orisetech panel
>
> Nope. If not a single GPIO and single supply, not a simple panel.
>
> Maybe reset could be allowed, but we have to draw the line somewhere.
>
> > > +
> > > +additionalProperties: false
> > > +
> > > +required:
> > > +  - compatible
> > > +  - power-supply
> >
> > power-supply should optional
>
> The panel works without power? The dts should have a fixed supply if
> not controllable.
>
> Here's the problem. If it is not required, then panels with multiple
> supplies will get added here because they didn't care to begin with.
> Then when someone decides to think about the supplies it will have to
> be moved. Bindings need to be complete from the start.

Fair enough, I will add fixed supply in dts files.
If reset-gpios could be added in this schema then we could include
oristech panel here.

Benjamin

>
> Rob

Re: [PATCH v2 1/2] dt-bindings: one binding file for all simple panels

[Sam Ravnborg]

Hi Benjamin.

> > +
> > +required:
> > +  - compatible
> > +  - power-supply
> 
> Hi Sam,
> 
> power-supply property should be optional like it was in
> ampire,am-480272h3tmqw-t01h.yaml
> else it looks good for me.

power-supply was discussed in PATRCH 2/2 and the conclusion was that
power-supply is required.
Thus I take this as an Acked-by:

And I have committed to drm-misc-next

	Sam

Re: [PATCH v2 1/2] dt-bindings: one binding file for all simple panels

[Sam Ravnborg]

Hi Jyri, Rob, Paul, Miquel.

Following patch is now applied to drm-misc-next.

Please add your simple panels to this file so
we avoid independent bindings files for ecah panel.

I will handle the inevitable conflicts when I apply.

	Sam


On Thu, Jan 02, 2020 at 11:17:11AM +0100, Sam Ravnborg wrote:
> There is an increasing number of new simple panels.
> Common for many of these simple panels are that they have one
> mandatory power-supply and some of them have backlight and / or
> an enable gpio.
> 
> The binding file to describe these panels adds overhead
> that really do not add value.
> The binding are known and there is nothing gained from a
> dedicated binding file nor for any dedicated example.
> 
> The following patch introduces a single panel-simple.yaml
> and converts two ampire bindings over to the new file.
> 
> The conversion - if applied will have following effects:
> 
> - The maintainer for the individual file will change
>     There is no need for many different maintainers for a simple binding.
>     We have the same situation with the panel-simple driver in the kernel.
> 
> - The license will change to (GPL-2.0-only OR BSD-2-Clause)
>     There is usually only a single line copied from the original
>     file, a line that is often copied from a datasheet.
>     This license change should be acceptable considered what little
>     is copied.
>     If the license change is not OK we can use a dedicated binding
>     file in these cases.
> 
> This is a follow-up on Rob's big patch converting a lot of panel bindings
> to individual files:
> 
> "dt-bindings: display: Convert a bunch of panels to DT schema"
> https://patchwork.ozlabs.org/patch/1197683/
> 
> The objectives with one file for the relevant simple panels are:
> - Make it simpler to add bindings for simple panels
> - Keep the number of bindings file lower and thus easier to find a
>   relevant file to copy from when adding new panels.
> - Keep the binding documentation for simple panels more consistent
> - Make it simpler to add support for new panels
> 
> v2:
>   - spelling fixes (imirkin via irc, Rob)
>   - updated description (Rob)
>   - list properires in alphabetical order
>   - added power-supply to example (Rob)
>   - updated title
>   - reworded changelog a little
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Yannick Fertre <yannick.fertre@st.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicetree@vger.kernel.org
> ---
>  .../panel/ampire,am-480272h3tmqw-t01h.yaml    | 42 -------------
>  .../panel/ampire,am800480r3tmqwa1h.txt        |  7 ---
>  .../bindings/display/panel/panel-simple.yaml  | 59 +++++++++++++++++++
>  3 files changed, 59 insertions(+), 49 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml b/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
> deleted file mode 100644
> index c6e33e7f36d0..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0
> -%YAML 1.2
> ----
> -$id: http://devicetree.org/schemas/display/panel/ampire,am-480272h3tmqw-t01h.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
> -
> -maintainers:
> -  - Yannick Fertre <yannick.fertre@st.com>
> -  - Thierry Reding <treding@nvidia.com>
> -
> -allOf:
> -  - $ref: panel-common.yaml#
> -
> -properties:
> -  compatible:
> -    const: ampire,am-480272h3tmqw-t01h
> -
> -  power-supply: true
> -  enable-gpios: true
> -  backlight: true
> -  port: true
> -
> -required:
> -  - compatible
> -
> -additionalProperties: false
> -
> -examples:
> -  - |
> -    panel_rgb: panel {
> -      compatible = "ampire,am-480272h3tmqw-t01h";
> -      enable-gpios = <&gpioa 8 1>;
> -      port {
> -        panel_in_rgb: endpoint {
> -          remote-endpoint = <&controller_out_rgb>;
> -        };
> -      };
> -    };
> -
> -...
> diff --git a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt b/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
> deleted file mode 100644
> index 83e2cae1cc1b..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "ampire,am800480r3tmqwa1h"
> -
> -This binding is compatible with the simple-panel binding, which is specified
> -in simple-panel.txt in this directory.
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> new file mode 100644
> index 000000000000..51ca50201182
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/panel-simple.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Simple panels with one power supply
> +
> +maintainers:
> +  - Thierry Reding <thierry.reding@gmail.com>
> +  - Sam Ravnborg <sam@ravnborg.org>
> +
> +description: |
> +  This binding file is a collection of the simple (dumb) panels that
> +  requires only a single power-supply.
> +  There are optionally a backlight and an enable GPIO.
> +  The panel may use an OF graph binding for the association to the display,
> +  or it may be a direct child node of the display.
> +
> +  If the panel is more advanced a dedicated binding file is required. 
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +
> +  compatible:
> +    enum:
> +    # compatible must be listed in alphabetical order, ordered by compatible.
> +    # The description in the comment is mandatory for each compatible.
> +
> +    # Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
> +    - ampire,am-480272h3tmqw-t01h
> +    # Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
> +    - ampire,am800480r3tmqwa1h
> +
> +  backlight: true
> +  enable-gpios: true
> +  port: true
> +  power-supply: true
> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - power-supply
> +
> +examples:
> +  - |
> +    panel_rgb: panel-rgb {
> +      compatible = "ampire,am-480272h3tmqw-t01h";
> +      power-supply = <&vcc_lcd_reg>;
> +
> +      port {
> +        panel_in_rgb: endpoint {
> +          remote-endpoint = <&ltdc_out_rgb>;
> +        };
> +      };
> +    };
> -- 
> 2.20.1

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

[Benjamin Gaignard]

Le mer. 8 janv. 2020 à 10:41, Benjamin Gaignard
<benjamin.gaignard@linaro.org> a écrit :
>
> Le mar. 7 janv. 2020 à 18:05, Rob Herring <robh@kernel.org> a écrit :
> >
> > On Tue, Jan 7, 2020 at 9:44 AM Benjamin Gaignard
> > <benjamin.gaignard@linaro.org> wrote:
> > >
> > > Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg <sam@ravnborg.org> a écrit :
> > > >
> > > > To complement panel-simple.yaml, create panel-simple-dsi.yaml.
> > > > panel-simple-dsi-yaml are for all simple DSP panels with a single
> > > > power-supply and optional backlight / enable GPIO.
> > > >
> > > > Migrate panasonic,vvx10f034n00 over to the new file.
> > > >
> > > > The objectives with one file for all the simple DSI panels are:
> > > >     - Make it simpler to add bindings for simple DSI panels
> > > >     - Keep the number of bindings file lower
> > > >     - Keep the binding documentation for simple DSI panels more consistent
> > > >
> > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > > Cc: Rob Herring <robh@kernel.org>
> > > > Cc: Maxime Ripard <mripard@kernel.org>
> > > > Cc: Yannick Fertre <yannick.fertre@st.com>
> > > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > > Cc: dri-devel@lists.freedesktop.org
> > > > Cc: devicetree@vger.kernel.org
> > > > ---
> > > >  .../display/panel/panasonic,vvx10f034n00.txt  | 20 ------
> > > >  .../display/panel/panel-simple-dsi.yaml       | 67 +++++++++++++++++++
> > > >  2 files changed, 67 insertions(+), 20 deletions(-)
> > > >  delete mode 100644 Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> > > >  create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt b/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> > > > deleted file mode 100644
> > > > index 37dedf6a6702..000000000000
> > > > --- a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> > > > +++ /dev/null
> > > > @@ -1,20 +0,0 @@
> > > > -Panasonic 10" WUXGA TFT LCD panel
> > > > -
> > > > -Required properties:
> > > > -- compatible: should be "panasonic,vvx10f034n00"
> > > > -- reg: DSI virtual channel of the peripheral
> > > > -- power-supply: phandle of the regulator that provides the supply voltage
> > > > -
> > > > -Optional properties:
> > > > -- backlight: phandle of the backlight device attached to the panel
> > > > -
> > > > -Example:
> > > > -
> > > > -       mdss_dsi@fd922800 {
> > > > -               panel@0 {
> > > > -                       compatible = "panasonic,vvx10f034n00";
> > > > -                       reg = <0>;
> > > > -                       power-supply = <&vreg_vsp>;
> > > > -                       backlight = <&lp8566_wled>;
> > > > -               };
> > > > -       };
> > > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > > > new file mode 100644
> > > > index 000000000000..05c52390269e
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > > > @@ -0,0 +1,67 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/display/panel/panel-simple-dsi.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Simple DSI panels with a single power-supply
> > > > +
> > > > +maintainers:
> > > > +  - Thierry Reding <thierry.reding@gmail.com>
> > > > +  - Sam Ravnborg <sam@ravnborg.org>
> > > > +
> > > > +description: |
> > > > +  This binding file is a collection of the DSI panels that
> > > > +  requires only a single power-supply.
> > > > +  There are optionally a backlight and an enable GPIO.
> > > > +  The panel may use an OF graph binding for the association to the display,
> > > > +  or it may be a direct child node of the display.
> > > > +
> > > > +  If the panel is more advanced a dedicated binding file is required.
> > > > +
> > > > +allOf:
> > > > +  - $ref: panel-common.yaml#
> > > > +
> > > > +properties:
> > > > +
> > > > +  compatible:
> > > > +    enum:
> > > > +    # compatible must be listed in alphabetical order, ordered by compatible.
> > > > +    # The description in the comment is mandatory for each compatible.
> > > > +
> > > > +    # Panasonic 10" WUXGA TFT LCD panel
> > > > +    - panasonic,vvx10f034n00
> > >
> > > Hi Sam,
> > >
> > > I have tested your patch with these 2 dsi panels:
> > > # Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD
> > >   - orisetech,otm8009a
> > >  # Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280 TFT LCD
> > >    - raydium,rm68200
> > >
> > > It is close to be fine for me but I have minors comments below.
> > >
> > > Benjamin
> > >
> > > > +
> > > > +  reg:
> > > > +    maxItems: 1
> > > > +    description: DSI virtual channel
> > > > +
> > > > +  backlight: true
> > > > +  enable-gpios: true
> > > > +  port: true
> > > > +  power-supply: true
> > >
> > > add reset-gpios: true to support orisetech panel
> >
> > Nope. If not a single GPIO and single supply, not a simple panel.
> >
> > Maybe reset could be allowed, but we have to draw the line somewhere.
> >
> > > > +
> > > > +additionalProperties: false
> > > > +
> > > > +required:
> > > > +  - compatible
> > > > +  - power-supply
> > >
> > > power-supply should optional
> >
> > The panel works without power? The dts should have a fixed supply if
> > not controllable.
> >
> > Here's the problem. If it is not required, then panels with multiple
> > supplies will get added here because they didn't care to begin with.
> > Then when someone decides to think about the supplies it will have to
> > be moved. Bindings need to be complete from the start.
>
> Fair enough, I will add fixed supply in dts files.
> If reset-gpios could be added in this schema then we could include
> oristech panel here.

Does this patch has been merged ?

Regards,
Benjamin

>
> Benjamin
>
> >
> > Rob

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

[Sam Ravnborg]

Hi Benjamin.
> > >
> > > Here's the problem. If it is not required, then panels with multiple
> > > supplies will get added here because they didn't care to begin with.
> > > Then when someone decides to think about the supplies it will have to
> > > be moved. Bindings need to be complete from the start.
> >
> > Fair enough, I will add fixed supply in dts files.
> > If reset-gpios could be added in this schema then we could include
> > oristech panel here.
> 
> Does this patch has been merged ?

I was sidetracked by other things.
Maybe you can move it forward?

	Sam

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

[Benjamin Gaignard]

Le mer. 29 janv. 2020 à 20:47, Sam Ravnborg <sam@ravnborg.org> a écrit :
>
> Hi Benjamin.
> > > >
> > > > Here's the problem. If it is not required, then panels with multiple
> > > > supplies will get added here because they didn't care to begin with.
> > > > Then when someone decides to think about the supplies it will have to
> > > > be moved. Bindings need to be complete from the start.
> > >
> > > Fair enough, I will add fixed supply in dts files.
> > > If reset-gpios could be added in this schema then we could include
> > > oristech panel here.
> >
> > Does this patch has been merged ?
>
> I was sidetracked by other things.
> Maybe you can move it forward?

Yes I will send a v3.
Benjamin

>
>         Sam