* [v2] ARM: dts: imx: Add support for Advantech DMS-BA16
@ 2018-02-06 0:05 Ken Lin
[not found] ` <20180206000501.14641-1-yungching0725-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Ken Lin @ 2018-02-06 0:05 UTC (permalink / raw)
To: shawnguo-DgEjT+Ai2ygdnm+yROfE0A
Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ, fabio.estevam-3arQi8VN3Tc,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
linux-I+IVW8TIWO2tmTQ+vhA3Yw,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Add support for Advantech DMS-BA16 board, which uses
the Advantech BA-16 module.
Signed-off-by: Ken Lin <yungching0725-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
Change in v2:
- Fix the order issue in Makefile
- Sort out the nodes alphabetically
- Use SPDX tag
- Fix some property issues
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/imx6q-dms-ba16.dts | 146 +++++++++++++++++++++++++++++++++++
2 files changed, 147 insertions(+)
create mode 100644 arch/arm/boot/dts/imx6q-dms-ba16.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ade7a38543dc..585c3da4a47a 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -435,6 +435,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6q-dfi-fs700-m60.dtb \
imx6q-display5-tianma-tm070-1280x768.dtb \
imx6q-dmo-edmqmx6.dtb \
+ imx6q-dms-ba16.dtb \
imx6q-evi.dtb \
imx6q-gk802.dtb \
imx6q-gw51xx.dtb \
diff --git a/arch/arm/boot/dts/imx6q-dms-ba16.dts b/arch/arm/boot/dts/imx6q-dms-ba16.dts
new file mode 100644
index 000000000000..055b88a6096d
--- /dev/null
+++ b/arch/arm/boot/dts/imx6q-dms-ba16.dts
@@ -0,0 +1,146 @@
+/*
+ * Copyright 2018 Advantech Corporation
+ *
+ * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+ */
+
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include "imx6q-ba16.dtsi"
+
+/ {
+ model = "Advantech DMS-BA16";
+ compatible = "advantech,imx6q-dms-ba16", "advantech,imx6q-ba16", "fsl,imx6q";
+
+ reg_usb_otg_vbus: regulator-usbotgvbus {
+ compatible = "regulator-fixed";
+ regulator-name = "usb_otg_vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbotgvbus>;
+ gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ sys_mclk: clock-sys-mclk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <22000000>;
+ };
+
+ sound {
+ compatible = "fsl,imx6q-ba16-sgtl5000",
+ "fsl,imx-audio-sgtl5000";
+ model = "imx6q-ba16-sgtl5000";
+ ssi-controller = <&ssi1>;
+ audio-codec = <&sgtl5000>;
+ audio-routing =
+ "MIC_IN", "Mic Jack",
+ "Mic Jack", "Mic Bias",
+ "Headphone Jack", "HP_OUT";
+ mux-int-port = <1>;
+ mux-ext-port = <4>;
+ };
+};
+
+&ecspi5 {
+ num-cs = <1>;
+ cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi5>;
+ status = "okay";
+
+ m25_eeprom: m25p80@0 {
+ compatible = "atmel,at25";
+ spi-max-frequency = <20000000>;
+ size = <0x8000>;
+ pagesize = <64>;
+ reg = <0>;
+ address-width = <16>;
+ };
+};
+
+&iomuxc {
+
+ pinctrl_usbotgvbus: usbotgvbusgrp {
+ fsl,pins = <
+ MX6QDL_PAD_KEY_ROW4__GPIO4_IO15 0x000b0
+ MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
+ >;
+ };
+
+ pinctrl_i2c1_gpio: i2c1gpiogrp {
+ fsl,pins = <
+ MX6QDL_PAD_CSI0_DAT8__GPIO5_IO26 0x1b0b0
+ MX6QDL_PAD_CSI0_DAT9__GPIO5_IO27 0x1b0b0
+ >;
+ };
+
+ pinctrl_i2c2_gpio: i2c2gpiogrp {
+ fsl,pins = <
+ MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x1b0b0
+ MX6QDL_PAD_KEY_ROW3__GPIO4_IO13 0x1b0b0
+ >;
+ };
+
+ pinctrl_i2c3_gpio: i2c3gpiogrp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_3__GPIO1_IO03 0x1b0b0
+ MX6QDL_PAD_GPIO_6__GPIO1_IO06 0x1b0b0
+ >;
+ };
+};
+
+&i2c1 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c1>;
+ status = "okay";
+
+ sgtl5000: codec@a {
+ compatible = "fsl,sgtl5000";
+ reg = <0x0a>;
+ clocks = <&sys_mclk>;
+ lrclk-strength = <0x3>;
+ VDDA-supply = <®_1p8v>;
+ VDDIO-supply = <®_3p3v>;
+ };
+};
+
+&pwm2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm2>;
+ status = "okay";
+};
+
+&sata {
+ fsl,no-spread-spectrum;
+ fsl,transmit-atten-16ths = <12>;
+ fsl,transmit-boost-mdB = <3330>;
+ fsl,transmit-level-mV = <1133>;
+ fsl,receive-dpll-mode = <1>;
+ status = "okay";
+};
+
+&usbotg {
+ vbus-supply = <®_usb_otg_vbus>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbotg>;
+ dr_mode = "otg";
+ disable-over-current;
+ status = "okay";
+};
+
+&usdhc4 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc4>;
+ bus-width = <8>;
+ cd-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>;
+ no-1-8-v;
+ keep-power-in-suspend;
+ wakeup-source;
+ status = "okay";
+};
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [v2] ARM: dts: imx: Add support for Advantech DMS-BA16
[not found] ` <20180206000501.14641-1-yungching0725-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-02-06 0:13 ` Fabio Estevam
[not found] ` <CAOMZO5CzDXxyzG9yC+26X4Ubek0bWMa_gxfBc4iQpBGxhbQ5DA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2018-02-06 0:13 UTC (permalink / raw)
To: Ken Lin
Cc: Shawn Guo, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Russell King - ARM Linux, linux-kernel, Rob Herring,
Sascha Hauer, Fabio Estevam,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Ken,
On Mon, Feb 5, 2018 at 10:05 PM, Ken Lin <yungching0725-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ade7a38543dc..585c3da4a47a 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -435,6 +435,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> imx6q-dfi-fs700-m60.dtb \
> imx6q-display5-tianma-tm070-1280x768.dtb \
> imx6q-dmo-edmqmx6.dtb \
> + imx6q-dms-ba16.dtb \
> imx6q-evi.dtb \
> imx6q-gk802.dtb \
> imx6q-gw51xx.dtb \
> diff --git a/arch/arm/boot/dts/imx6q-dms-ba16.dts b/arch/arm/boot/dts/imx6q-dms-ba16.dts
> new file mode 100644
> index 000000000000..055b88a6096d
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6q-dms-ba16.dts
> @@ -0,0 +1,146 @@
> +/*
> + * Copyright 2018 Advantech Corporation
> + *
> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
You should put the SPDX line as the first line and it should start with //:
// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> + */
> +
> +
No need for two blank lines. One is enough.
> +/dts-v1/;
> +
...
> +&ecspi5 {
> + num-cs = <1>;
You can remove this property.
> + cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi5>;
> + status = "okay";
> +
> + m25_eeprom: m25p80@0 {
> + compatible = "atmel,at25";
According to Documentation/devicetree/bindings/eeprom/at25.txt this
should have the following format:
compatible : Should be "<vendor>,<type>", and generic value "atmel,at25".
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v2] ARM: dts: imx: Add support for Advantech DMS-BA16
[not found] ` <CAOMZO5CzDXxyzG9yC+26X4Ubek0bWMa_gxfBc4iQpBGxhbQ5DA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-02-06 2:25 ` Yung-Ching LIN
0 siblings, 0 replies; 3+ messages in thread
From: Yung-Ching LIN @ 2018-02-06 2:25 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Russell King - ARM Linux, linux-kernel, Rob Herring,
Sascha Hauer, Fabio Estevam,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Fabio,
Thank you for your comments.
Will provide the v3 for the fixes
On Mon, Feb 5, 2018 at 4:13 PM, Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi Ken,
>
> On Mon, Feb 5, 2018 at 10:05 PM, Ken Lin <yungching0725-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index ade7a38543dc..585c3da4a47a 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -435,6 +435,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>> imx6q-dfi-fs700-m60.dtb \
>> imx6q-display5-tianma-tm070-1280x768.dtb \
>> imx6q-dmo-edmqmx6.dtb \
>> + imx6q-dms-ba16.dtb \
>> imx6q-evi.dtb \
>> imx6q-gk802.dtb \
>> imx6q-gw51xx.dtb \
>> diff --git a/arch/arm/boot/dts/imx6q-dms-ba16.dts b/arch/arm/boot/dts/imx6q-dms-ba16.dts
>> new file mode 100644
>> index 000000000000..055b88a6096d
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6q-dms-ba16.dts
>> @@ -0,0 +1,146 @@
>> +/*
>> + * Copyright 2018 Advantech Corporation
>> + *
>> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>
> You should put the SPDX line as the first line and it should start with //:
>
> // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>
>> + */
>> +
>> +
>
> No need for two blank lines. One is enough.
>
>> +/dts-v1/;
>> +
> ...
>
>> +&ecspi5 {
>> + num-cs = <1>;
>
> You can remove this property.
>
>
>> + cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_ecspi5>;
>> + status = "okay";
>> +
>> + m25_eeprom: m25p80@0 {
>> + compatible = "atmel,at25";
>
> According to Documentation/devicetree/bindings/eeprom/at25.txt this
> should have the following format:
>
> compatible : Should be "<vendor>,<type>", and generic value "atmel,at25".
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-06 2:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06 0:05 [v2] ARM: dts: imx: Add support for Advantech DMS-BA16 Ken Lin
[not found] ` <20180206000501.14641-1-yungching0725-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-06 0:13 ` Fabio Estevam
[not found] ` <CAOMZO5CzDXxyzG9yC+26X4Ubek0bWMa_gxfBc4iQpBGxhbQ5DA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-06 2:25 ` Yung-Ching LIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).