From: Linus Walleij <linus.walleij@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.org>,
Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-gpio@vger.kernel.org, Michael Zoran <mzoran@crowfest.net>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander
Date: Wed, 7 Feb 2018 10:13:10 +0100 [thread overview]
Message-ID: <CACRpkdYGYtF5iw=ZDF9O5LdwfvktEfDORjYXZDmFNihVSP+c3w@mail.gmail.com> (raw)
In-Reply-To: <20180206162759.awghecpv4ihaatz7@tarshish>
On Tue, Feb 6, 2018 at 5:27 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> On Tue, Feb 06, 2018 at 02:42:48PM +0100, Linus Walleij wrote:
>> On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach <baruch@tkos.co.il> wrote:
>>
>> > The Raspberry Pi 3 has a GPIO expander that controls, among others, the
>> > activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus
>> > that is not directly controlled from the ARM core. The VC4 firmware controls
>> > the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox
>> > interface.
>> >
>> > This series adds support for the RPi3 expander.
>> >
>> > The driver is ported from the downstream kernel at
>> > https://github.com/raspberrypi/linux/, branch rpi-4.9.y.
>> >
>> > Changes in v3:
>> >
>> > * Kconfig tweaks
>> > * Check rpi_exp_gpio_get_polarity() return value
>> > * Redundant header removal
>> > * Redundant platform_set_drvdata() call removal
>> > * Small coding style changes
>>
>> All is looking pretty good. I see Rob had some last minute comments,
>> but please rebase and repost post v4.16-rc1 so we can get this merged,
>> we need to get this upstream.
>
> I was about to send v4 when I saw your email. I based v4 on current LinusT's
> tree as of e237f98a9c. I guess that affected files will not change before
> v4.16-rc1, but I can wait a few more days for -rc1.
It's fine to send if you feel it is ready. I am already queueing
stuff for v4.17.
Yours,
Linus Walleij
next prev parent reply other threads:[~2018-02-07 9:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 12:45 [PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander Baruch Siach
2018-01-16 12:45 ` [PATCH v3 1/4] ARM: bcm2835: sync firmware properties with downstream Baruch Siach
[not found] ` <cover.1516105893.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-16 12:45 ` [PATCH v3 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Baruch Siach
2018-01-29 16:11 ` Rob Herring
2018-01-29 16:30 ` Baruch Siach
2018-02-06 13:42 ` [PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander Linus Walleij
[not found] ` <CACRpkdZAtVfAU-k9EUihH6peY2d1Ntn3jboVMBn9adReNLupow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-06 16:27 ` Baruch Siach
2018-02-07 9:13 ` Linus Walleij [this message]
2018-02-07 9:33 ` Stefan Wahren
[not found] ` <a3e4ba9a-60bf-5038-7385-8cb3d2667ed2-eS4NqCHxEME@public.gmane.org>
2018-02-07 9:38 ` Baruch Siach
2018-02-07 10:20 ` Stefan Wahren
2018-01-16 12:45 ` [PATCH v3 3/4] gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service Baruch Siach
[not found] ` <1a2829a6cb5edc951f9d8f322882916ab9cea67c.1516105893.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2018-01-19 18:50 ` Stefan Wahren
2018-01-16 12:45 ` [PATCH v3 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander Baruch Siach
2018-01-17 8:30 ` Stefan Wahren
[not found] ` <6c07ab6a-a2c6-284e-6205-58d2512d0256-eS4NqCHxEME@public.gmane.org>
2018-01-17 9:39 ` Linus Walleij
2018-01-19 18:52 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYGYtF5iw=ZDF9O5LdwfvktEfDORjYXZDmFNihVSP+c3w@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=baruch@tkos.co.il \
--cc=dave.stevenson@raspberrypi.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mzoran@crowfest.net \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).