From: Linus Walleij <linus.walleij@linaro.org>
To: Iskren Chernev <iskren.chernev@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Sam Ravnborg <sam@ravnborg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
phone-devel@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,"
<~postmarketos/upstreaming@lists.sr.ht>
Subject: Re: [PATCH v3 1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel
Date: Mon, 26 Jul 2021 09:14:57 +0200 [thread overview]
Message-ID: <CACRpkdanNPaBOAo80wSvNU=ynkS5AVc6gV02jTfq-AePye+fGg@mail.gmail.com> (raw)
In-Reply-To: <20210201165307.51443-1-iskren.chernev@gmail.com>
Hi Iskren,
thanks for your patch!
On Mon, Feb 1, 2021 at 5:56 PM Iskren Chernev <iskren.chernev@gmail.com> wrote:
> +required:
> + - compatible
> + - reset-gpios
> + - iovdd-supply
> + - vddr-supply
> + - port
I do not think port should be required because the DSI
framework allows panels to be put as children right inside
the DSI controller node without any port linking the two.
Other than that it looks good!
Yours,
Linus Walleij
prev parent reply other threads:[~2021-07-26 7:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 16:53 [PATCH v3 1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel Iskren Chernev
2021-02-01 16:53 ` [PATCH v3 2/2] drm/panel: Add panel for Samsung Galaxy S5 Iskren Chernev
2021-07-26 7:34 ` Linus Walleij
2021-07-26 7:52 ` Iskren Chernev
2021-02-09 20:55 ` [PATCH v3 1/2] dt-bindings: panel: Add Samsung S6E3FA2 panel Rob Herring
2021-07-26 7:14 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdanNPaBOAo80wSvNU=ynkS5AVc6gV02jTfq-AePye+fGg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=iskren.chernev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).