From: Doug Anderson <dianders@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
Stephen Boyd <swboyd@chromium.org>,
Alan Stern <stern@rowland.harvard.edu>,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Peter Chen <peter.chen@nxp.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: usb: Add binding for discrete onboard USB hubs
Date: Mon, 28 Sep 2020 15:13:26 -0700 [thread overview]
Message-ID: <CAD=FV=XWphkhFmEk6dzGn7h2mY5xBHY554rOfn+bSi5Nci27gA@mail.gmail.com> (raw)
In-Reply-To: <20200928101326.v4.1.I248292623d3d0f6a4f0c5bc58478ca3c0062b49a@changeid>
Hi,
On Mon, Sep 28, 2020 at 10:14 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> +examples:
> + - |
> + usb_hub: usb-hub {
> + compatible = "realtek,rts5411", "onboard-usb-hub";
> + vdd-supply = <&pp3300_hub>;
> + };
> +
> + usb_controller {
Super nitty nit: prefer dashes for node names.
> + dr_mode = "host";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* 2.0 hub on port 1 */
> + hub@1 {
> + compatible = "usbbda,5411";
Presumably we need something in the bindings for "usbbda,5411" ?
> + reg = <1>;
> + hub = <&usb_hub>;
> + };
> +
> + /* 3.0 hub on port 2 */
> + hub@2 {
> + compatible = "usbbda,411";
Presumably we need something in the bindings for "usbbda,411" ?
-Doug
next prev parent reply other threads:[~2020-09-28 23:43 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 17:13 [PATCH v4 1/2] dt-bindings: usb: Add binding for discrete onboard USB hubs Matthias Kaehlcke
2020-09-28 17:13 ` [PATCH v4 2/2] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2020-09-28 18:47 ` Alan Stern
2020-09-29 1:43 ` Matthias Kaehlcke
2020-09-29 16:00 ` Alan Stern
2020-09-29 16:50 ` Matthias Kaehlcke
2020-09-28 22:03 ` Doug Anderson
2020-09-29 1:59 ` Matthias Kaehlcke
2020-09-28 22:13 ` Doug Anderson [this message]
2020-09-29 2:14 ` [PATCH v4 1/2] dt-bindings: usb: Add binding for discrete onboard USB hubs Matthias Kaehlcke
2020-09-29 20:17 ` Rob Herring
2020-09-29 22:09 ` Matthias Kaehlcke
2020-09-30 1:32 ` Alan Stern
2020-09-30 12:49 ` Matthias Kaehlcke
2020-09-30 14:44 ` Rob Herring
2020-09-30 15:28 ` Doug Anderson
2020-09-30 18:00 ` Doug Anderson
2020-09-30 19:19 ` Rob Herring
2020-10-01 21:39 ` Matthias Kaehlcke
2020-09-30 19:19 ` Alan Stern
2020-09-30 20:20 ` Rob Herring
2020-10-01 1:24 ` Alan Stern
2020-10-01 21:54 ` Matthias Kaehlcke
2020-10-02 1:21 ` Alan Stern
2020-10-02 16:08 ` Matthias Kaehlcke
2020-10-02 18:48 ` Alan Stern
2020-10-02 17:08 ` Doug Anderson
2020-10-02 18:36 ` Alan Stern
2020-10-02 22:58 ` Rob Herring
2020-10-03 12:41 ` Alan Stern
2020-10-05 16:06 ` Matthias Kaehlcke
2020-10-05 16:15 ` Alan Stern
2020-10-05 19:18 ` Matthias Kaehlcke
2020-10-05 19:36 ` Alan Stern
2020-10-05 19:59 ` Rob Herring
2020-10-05 23:29 ` Matthias Kaehlcke
2020-10-05 19:36 ` Rob Herring
2020-10-05 19:20 ` Rob Herring
2020-10-02 22:28 ` Rob Herring
2020-10-02 23:09 ` Doug Anderson
2020-10-06 0:45 ` Matthias Kaehlcke
2020-10-06 14:18 ` Alan Stern
2020-10-06 16:59 ` Matthias Kaehlcke
2020-10-06 17:15 ` Alan Stern
2020-10-06 19:25 ` Matthias Kaehlcke
2020-10-07 1:00 ` Alan Stern
2020-10-07 16:03 ` Matthias Kaehlcke
2020-10-07 16:38 ` Alan Stern
2020-10-07 17:28 ` Matthias Kaehlcke
2020-10-07 19:25 ` Alan Stern
2020-10-07 19:42 ` Matthias Kaehlcke
2020-10-07 20:17 ` Alan Stern
2020-10-07 21:42 ` Matthias Kaehlcke
2020-10-08 14:09 ` Alan Stern
2020-10-09 23:13 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XWphkhFmEk6dzGn7h2mY5xBHY554rOfn+bSi5Nci27gA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=peter.chen@nxp.com \
--cc=ravisadineni@chromium.org \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).