* [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG Families USB Glue Bindings
[not found] <20200909160409.8678-1-narmstrong@baylibre.com>
@ 2020-09-09 16:04 ` Neil Armstrong
2020-09-15 17:32 ` [PATCH 2/5] dt-bindings: usb: amlogic, meson-g12a-usb-ctrl: " Rob Herring
2020-09-15 19:56 ` [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: " Martin Blumenstingl
0 siblings, 2 replies; 3+ messages in thread
From: Neil Armstrong @ 2020-09-09 16:04 UTC (permalink / raw)
To: khilman, martin.blumenstingl, devicetree
Cc: linux-amlogic, linux-arm-kernel, linux-kernel, Neil Armstrong, linux-usb
The Amlogic AXG is close from the GXL Glue but with a single OTG PHY.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
.../usb/amlogic,meson-g12a-usb-ctrl.yaml | 22 ++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
index 5b04a7dfa018..c0058332b967 100644
--- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
+++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
@@ -25,13 +25,14 @@ description: |
The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in
host-only mode.
- The Amlogic GXL & GXM SoCs doesn't embed an USB3 PHY.
+ The Amlogic GXL, GXM & AXG SoCs doesn't embed an USB3 PHY.
properties:
compatible:
enum:
- amlogic,meson-gxl-usb-ctrl
- amlogic,meson-gxm-usb-ctrl
+ - amlogic,meson-axg-usb-ctrl
- amlogic,meson-g12a-usb-ctrl
- amlogic,meson-a1-usb-ctrl
@@ -151,6 +152,25 @@ allOf:
required:
- clock-names
+ - if:
+ properties:
+ compatible:
+ enum:
+ - amlogic,meson-axg-usb-ctrl
+
+ then:
+ properties:
+ phy-names:
+ items:
+ - const: usb2-phy1 # USB2 PHY1 if USBOTG_B port is used
+ clocks:
+ minItems: 2
+ clock-names:
+ items:
+ - const: usb_ctrl
+ - const: ddr
+ required:
+ - clock-names
- if:
properties:
compatible:
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] dt-bindings: usb: amlogic, meson-g12a-usb-ctrl: add the Amlogic AXG Families USB Glue Bindings
2020-09-09 16:04 ` [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG Families USB Glue Bindings Neil Armstrong
@ 2020-09-15 17:32 ` Rob Herring
2020-09-15 19:56 ` [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: " Martin Blumenstingl
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-09-15 17:32 UTC (permalink / raw)
To: Neil Armstrong
Cc: martin.blumenstingl, linux-arm-kernel, devicetree, linux-amlogic,
linux-kernel, linux-usb, khilman
On Wed, 09 Sep 2020 18:04:06 +0200, Neil Armstrong wrote:
> The Amlogic AXG is close from the GXL Glue but with a single OTG PHY.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> .../usb/amlogic,meson-g12a-usb-ctrl.yaml | 22 ++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG Families USB Glue Bindings
2020-09-09 16:04 ` [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG Families USB Glue Bindings Neil Armstrong
2020-09-15 17:32 ` [PATCH 2/5] dt-bindings: usb: amlogic, meson-g12a-usb-ctrl: " Rob Herring
@ 2020-09-15 19:56 ` Martin Blumenstingl
1 sibling, 0 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2020-09-15 19:56 UTC (permalink / raw)
To: Neil Armstrong
Cc: khilman, devicetree, linux-amlogic, linux-arm-kernel,
linux-kernel, linux-usb
Hi Neil
On Wed, Sep 9, 2020 at 6:04 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> The Amlogic AXG is close from the GXL Glue but with a single OTG PHY.
nit-pick: I think this should be "close to"
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> .../usb/amlogic,meson-g12a-usb-ctrl.yaml | 22 ++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
> index 5b04a7dfa018..c0058332b967 100644
> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
> @@ -25,13 +25,14 @@ description: |
> The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in
> host-only mode.
>
> - The Amlogic GXL & GXM SoCs doesn't embed an USB3 PHY.
> + The Amlogic GXL, GXM & AXG SoCs doesn't embed an USB3 PHY.
nit-pick: not sure if we need to fix it here: s/doesn't/don't/
(personally I would also put AXG first - in reality it changes nothing though)
Best regards,
Martin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-15 19:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200909160409.8678-1-narmstrong@baylibre.com>
2020-09-09 16:04 ` [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG Families USB Glue Bindings Neil Armstrong
2020-09-15 17:32 ` [PATCH 2/5] dt-bindings: usb: amlogic, meson-g12a-usb-ctrl: " Rob Herring
2020-09-15 19:56 ` [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: " Martin Blumenstingl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).