* [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2
@ 2020-11-25 2:40 Christian Hewitt
2020-11-30 13:25 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christian Hewitt @ 2020-11-25 2:40 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kevin Hilman, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt, Artem Lapkin
From: Artem Lapkin <art@khadas.com>
The max frequency for the w25q32 (VIM v1.2) and w25q128 (VIM v1.4) spifc
chip should be 104Mhz not 30MHz.
Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
Signed-off-by: Artem Lapkin <art@khadas.com>
---
This change was previously submitted as [0] which has style issues and
remains unmerged. It is also part of a two patch series where the other
patch needs further work to convert to newer LED bindings.
[0] https://patchwork.kernel.org/project/linux-amlogic/patch/20200928092613.273998-3-art@khadas.com/
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index 39e6047056b2..079500ed5066 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -391,7 +391,7 @@
#size-cells = <1>;
compatible = "winbond,w25q16", "jedec,spi-nor";
reg = <0>;
- spi-max-frequency = <3000000>;
+ spi-max-frequency = <104000000>;
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2
2020-11-25 2:40 [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2 Christian Hewitt
2020-11-30 13:25 ` Neil Armstrong
@ 2020-11-30 13:25 ` Neil Armstrong
2020-12-05 12:02 ` Martin Blumenstingl
2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2020-11-30 13:25 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Mark Rutland, Kevin Hilman,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Artem Lapkin
On 25/11/2020 03:40, Christian Hewitt wrote:
> From: Artem Lapkin <art@khadas.com>
>
> The max frequency for the w25q32 (VIM v1.2) and w25q128 (VIM v1.4) spifc
> chip should be 104Mhz not 30MHz.
>
> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
> This change was previously submitted as [0] which has style issues and
> remains unmerged. It is also part of a two patch series where the other
> patch needs further work to convert to newer LED bindings.
>
> [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20200928092613.273998-3-art@khadas.com/
>
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index 39e6047056b2..079500ed5066 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -391,7 +391,7 @@
> #size-cells = <1>;
> compatible = "winbond,w25q16", "jedec,spi-nor";
> reg = <0>;
> - spi-max-frequency = <3000000>;
> + spi-max-frequency = <104000000>;
> };
> };
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2
2020-11-25 2:40 [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2 Christian Hewitt
@ 2020-11-30 13:25 ` Neil Armstrong
2020-11-30 13:25 ` Neil Armstrong
2020-12-05 12:02 ` Martin Blumenstingl
2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2020-11-30 13:25 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Mark Rutland, Kevin Hilman,
devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Artem Lapkin
On 25/11/2020 03:40, Christian Hewitt wrote:
> From: Artem Lapkin <art@khadas.com>
>
> The max frequency for the w25q32 (VIM v1.2) and w25q128 (VIM v1.4) spifc
> chip should be 104Mhz not 30MHz.
>
> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
> This change was previously submitted as [0] which has style issues and
> remains unmerged. It is also part of a two patch series where the other
> patch needs further work to convert to newer LED bindings.
>
> [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20200928092613.273998-3-art@khadas.com/
>
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index 39e6047056b2..079500ed5066 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -391,7 +391,7 @@
> #size-cells = <1>;
> compatible = "winbond,w25q16", "jedec,spi-nor";
> reg = <0>;
> - spi-max-frequency = <3000000>;
> + spi-max-frequency = <104000000>;
> };
> };
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2
2020-11-25 2:40 [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2 Christian Hewitt
2020-11-30 13:25 ` Neil Armstrong
2020-11-30 13:25 ` Neil Armstrong
@ 2020-12-05 12:02 ` Martin Blumenstingl
2 siblings, 0 replies; 4+ messages in thread
From: Martin Blumenstingl @ 2020-12-05 12:02 UTC (permalink / raw)
To: Christian Hewitt
Cc: Rob Herring, Mark Rutland, Kevin Hilman, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel, Artem Lapkin
On Wed, Nov 25, 2020 at 3:40 AM Christian Hewitt
<christianshewitt@gmail.com> wrote:
>
> From: Artem Lapkin <art@khadas.com>
>
> The max frequency for the w25q32 (VIM v1.2) and w25q128 (VIM v1.4) spifc
> chip should be 104Mhz not 30MHz.
>
> Fixes: b8b74dda3908 ("ARM64: dts: meson-gxm: Add support for Khadas VIM2")
> Signed-off-by: Artem Lapkin <art@khadas.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-05 18:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-25 2:40 [PATCH] arm64: dts: meson: fix spi-max-frequency on Khadas VIM2 Christian Hewitt
2020-11-30 13:25 ` Neil Armstrong
2020-11-30 13:25 ` Neil Armstrong
2020-12-05 12:02 ` Martin Blumenstingl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).