* [PATCH] arm64: dts: mt8183: Add power-domains properity to mfgcfg
@ 2021-02-24 9:17 Ikjoon Jang
2021-02-24 10:30 ` Enric Balletbo Serra
0 siblings, 1 reply; 3+ messages in thread
From: Ikjoon Jang @ 2021-02-24 9:17 UTC (permalink / raw)
To: devicetree, linux-mediatek, Rob Herring, Matthias Brugger,
linux-arm-kernel, linux-kernel
Cc: Weiyi Lu, Ikjoon Jang
mfgcfg clock is under MFG_ASYNC power domain
Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 5b782a4769e7..3384df5284c0 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -962,6 +962,7 @@ mfgcfg: syscon@13000000 {
compatible = "mediatek,mt8183-mfgcfg", "syscon";
reg = <0 0x13000000 0 0x1000>;
#clock-cells = <1>;
+ power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_ASYNC>;
};
mmsys: syscon@14000000 {
--
2.30.0.617.g56c4b15f3c-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mt8183: Add power-domains properity to mfgcfg
2021-02-24 9:17 [PATCH] arm64: dts: mt8183: Add power-domains properity to mfgcfg Ikjoon Jang
@ 2021-02-24 10:30 ` Enric Balletbo Serra
2021-04-01 9:38 ` Matthias Brugger
0 siblings, 1 reply; 3+ messages in thread
From: Enric Balletbo Serra @ 2021-02-24 10:30 UTC (permalink / raw)
To: Ikjoon Jang
Cc: devicetree, moderated list:ARM/Mediatek SoC support, Rob Herring,
Matthias Brugger, Linux ARM, linux-kernel, Weiyi Lu
Hi Ikjoon,
Thank you for your patch.
Missatge de Ikjoon Jang <ikjn@chromium.org> del dia dc., 24 de febr.
2021 a les 10:21:
>
> mfgcfg clock is under MFG_ASYNC power domain
>
> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 5b782a4769e7..3384df5284c0 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -962,6 +962,7 @@ mfgcfg: syscon@13000000 {
> compatible = "mediatek,mt8183-mfgcfg", "syscon";
> reg = <0 0x13000000 0 0x1000>;
> #clock-cells = <1>;
> + power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_ASYNC>;
I don't think this will work in mainline, at least, the reference name
should be &spm
Thanks,
Enric
> };
>
> mmsys: syscon@14000000 {
> --
> 2.30.0.617.g56c4b15f3c-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mt8183: Add power-domains properity to mfgcfg
2021-02-24 10:30 ` Enric Balletbo Serra
@ 2021-04-01 9:38 ` Matthias Brugger
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2021-04-01 9:38 UTC (permalink / raw)
To: Enric Balletbo Serra, Ikjoon Jang
Cc: devicetree, moderated list:ARM/Mediatek SoC support, Rob Herring,
Linux ARM, linux-kernel, Weiyi Lu
On 24/02/2021 11:30, Enric Balletbo Serra wrote:
> Hi Ikjoon,
>
> Thank you for your patch.
>
> Missatge de Ikjoon Jang <ikjn@chromium.org> del dia dc., 24 de febr.
> 2021 a les 10:21:
>>
>> mfgcfg clock is under MFG_ASYNC power domain
>>
>> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
>> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>> ---
>>
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index 5b782a4769e7..3384df5284c0 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -962,6 +962,7 @@ mfgcfg: syscon@13000000 {
>> compatible = "mediatek,mt8183-mfgcfg", "syscon";
>> reg = <0 0x13000000 0 0x1000>;
>> #clock-cells = <1>;
>> + power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_ASYNC>;
>
> I don't think this will work in mainline, at least, the reference name
> should be &spm
>
Correct. Would you mind to resend with the comment from Enric. Apart from that,
patch looks fine to me.
Regards,
Matthias
> Thanks,
> Enric
>> };
>>
>> mmsys: syscon@14000000 {
>> --
>> 2.30.0.617.g56c4b15f3c-goog
>>
>>
>> _______________________________________________
>> Linux-mediatek mailing list
>> Linux-mediatek@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-01 9:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-24 9:17 [PATCH] arm64: dts: mt8183: Add power-domains properity to mfgcfg Ikjoon Jang
2021-02-24 10:30 ` Enric Balletbo Serra
2021-04-01 9:38 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).