Re: [linux-sunxi] Re: [PATCH v3 5/5] ARM: dts: axp209: Enable usb_power_supply by default

[Chen-Yu Tsai <wens@csie.org>]

On Fri, May 6, 2016 at 1:24 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 05-05-16 12:46, Michael Haas wrote:
>>
>> Hi Hans,
>>
>> On 05/05/2016 12:39 PM, Hans de Goede wrote:
>>>
>>> Hi,
>>>
>>> On 05-05-16 12:35, Michael Haas wrote:
>>>>
>>>> This node should be enabled by default. A device is likely to have an
>>>> USB power
>>>> connection. If USB power is indeed absent, the USB power driver
>>>> will simply report the power input as offline.
>>>
>>>
>>> Nack, as Maxime already said we do not want to enable any optional
>>> features by default. Many top set boxes do not use the usb power supply,
>>> and we don't want some userspace power control panel applet showing
>>> the supply as offline, we want the supply to simply not be there.
>>
>>
>> it was my understanding that Maxime [0] and ChenYu [1] indicated they
>> would prefer it to be enabled globally.
>
>
> I believe you're misreading what Maxime is saying, let me
> pair things up as I believe they are meant to be interpreted:
>
> You say: "do you have any preference for this being in the AXP209 dtsi? ..."
>
> Maxime says: "Yes, I'd prefer that a lot :)"
>
>
> You say: "I've been thinking about it and it makes sense to enable the power
> supply nodes for all devices using the AXP209."
>
> Maxime says: "It avoids enabling it on all the boards."
>
> IOW having the "status = disabled" in the dtsi avoids enabling it on all
> the boards".
>
> I'm pretty sure this is what Maxime's intentions are.
>
>
> It seems that Chen-Yu does agree with you:
>
> "I see no reason why we shouldn't just enable it by default.
> It is almost always going to be used. Same for the VBUS power supply."
>
> Chen-Yu, I disagree with this, IIRC we've had this discussion multiple
> times, and so far the rule has always been that we do not want negatives
> in the per board dts files. IOW we do not want people to have to add
> status = "disabled" to dts files when the usb or ac power supply is not
> used, since they are likely to forgot and it just makes the dts files
> harder to read in general.
>
> And boards without usb-power (many A10 / A20 / A31 set-top boxes), or
> without ac-power (quite a few tablets) are more common then you think.

I see. Both are very valid points. I'll keep that in mind.

Michael, please drop this one and also set status = "disabled" for
the ac power supply in axp209.dtsi.

Sorry for the noise.

ChenYu

>
> Regards,
>
> Hans
>
>
>
>
>
>
>>
>> Best,
>>
>> Michael
>>
>> [0] https://groups.google.com/d/msg/linux-sunxi/cHAlhoIw74g/CbBeoX23AAAJ
>> [1] https://groups.google.com/d/msg/linux-sunxi/Ee7i8DVI4F8/0b0TBrRkAAAJ
>>
>>>>
>>>> Signed-off-by: Michael Haas <haas@computerlinguist.org>
>>>> ---
>>>>  arch/arm/boot/dts/axp209.dtsi | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/axp209.dtsi
>>>> b/arch/arm/boot/dts/axp209.dtsi
>>>> index 7deb7d9..4f16be0 100644
>>>> --- a/arch/arm/boot/dts/axp209.dtsi
>>>> +++ b/arch/arm/boot/dts/axp209.dtsi
>>>> @@ -97,7 +97,7 @@
>>>>
>>>>      usb_power_supply: usb_power_supply {
>>>>          compatible = "x-powers,axp202-usb-power-supply";
>>>> -        status = "disabled";
>>>> +        status = "okay";
>>>>      };
>>>>
>>>>  };
>>>>
>>
>