From: Hans de Goede <hdegoede@redhat.com>
To: Michael Haas <haas@computerlinguist.org>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
maxime.ripard@free-electrons.com, wens@csie.org,
lee.jones@linaro.org, sre@kernel.org, dbaryshkov@gmail.com,
dwmw2@infradead.org
Cc: bonbons@linux-vserver.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, linux@arm.linux.org.uk,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v3 5/5] ARM: dts: axp209: Enable usb_power_supply by default
Date: Thu, 5 May 2016 12:39:48 +0200 [thread overview]
Message-ID: <f672f0c7-495c-de63-6115-68d57500d874@redhat.com> (raw)
In-Reply-To: <1462444508-9363-6-git-send-email-haas@computerlinguist.org>
Hi,
On 05-05-16 12:35, Michael Haas wrote:
> This node should be enabled by default. A device is likely to have an USB power
> connection. If USB power is indeed absent, the USB power driver
> will simply report the power input as offline.
Nack, as Maxime already said we do not want to enable any optional
features by default. Many top set boxes do not use the usb power supply,
and we don't want some userspace power control panel applet showing
the supply as offline, we want the supply to simply not be there.
Regards,
Hans
>
> Signed-off-by: Michael Haas <haas@computerlinguist.org>
> ---
> arch/arm/boot/dts/axp209.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
> index 7deb7d9..4f16be0 100644
> --- a/arch/arm/boot/dts/axp209.dtsi
> +++ b/arch/arm/boot/dts/axp209.dtsi
> @@ -97,7 +97,7 @@
>
> usb_power_supply: usb_power_supply {
> compatible = "x-powers,axp202-usb-power-supply";
> - status = "disabled";
> + status = "okay";
> };
>
> };
>
next prev parent reply other threads:[~2016-05-05 10:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 10:35 [PATCH v3 0/6] Add axp20x-ac power driver Michael Haas
2016-05-05 10:35 ` [PATCH v3 2/5] mfd: axp20x: Add a cell for the ac power_supply part of the axp20x PMICs Michael Haas
2016-05-06 2:48 ` Chen-Yu Tsai
2016-05-05 10:35 ` [PATCH v3 3/5] ARM: dts: Add binding documentation for AXP20x pmic ac power supply Michael Haas
2016-05-05 22:30 ` Rob Herring
2016-05-06 2:33 ` Chen-Yu Tsai
[not found] ` <1462444508-9363-1-git-send-email-haas-bdq14YP6qtSV9CzYT+GlPGD2FQJk+8+b@public.gmane.org>
2016-05-05 10:35 ` [PATCH v3 1/5] power: Add an axp20x-ac-power driver Michael Haas
2016-05-05 10:35 ` [PATCH v3 4/5] ARM: dts: axp209: Add ac_power_supply child node to the ax209 node Michael Haas
[not found] ` <1462444508-9363-5-git-send-email-haas-bdq14YP6qtSV9CzYT+GlPGD2FQJk+8+b@public.gmane.org>
2016-05-05 10:41 ` Hans de Goede
2016-05-05 10:35 ` [PATCH v3 5/5] ARM: dts: axp209: Enable usb_power_supply by default Michael Haas
2016-05-05 10:39 ` Hans de Goede [this message]
[not found] ` <f672f0c7-495c-de63-6115-68d57500d874-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-05 10:46 ` Michael Haas
[not found] ` <3512867a-a82c-6be7-35ff-a4f6fb48a259-bdq14YP6qtSV9CzYT+GlPGD2FQJk+8+b@public.gmane.org>
2016-05-05 17:24 ` [linux-sunxi] " Hans de Goede
2016-05-06 2:48 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f672f0c7-495c-de63-6115-68d57500d874@redhat.com \
--to=hdegoede@redhat.com \
--cc=bonbons@linux-vserver.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=haas@computerlinguist.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).