From: Chen-Yu Tsai <wens@csie.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-sunxi@lists.linux.dev,
linux-kernel <linux-kernel@vger.kernel.org>,
Michael Klein <michael@fossekall.de>
Subject: Re: Re: [PATCH v2] ARM: dts: sun8i: Adjust power key nodes
Date: Tue, 30 Nov 2021 01:35:35 +0800 [thread overview]
Message-ID: <CAGb2v66ZGMxqgU7sGrSrnog3yHZ+Ny_xJdvBFVYZWH2Q5XbiCQ@mail.gmail.com> (raw)
In-Reply-To: <5516984.DvuYhMxLoT@kista>
On Tue, Nov 30, 2021 at 1:29 AM Jernej Škrabec <jernej.skrabec@gmail.com> wrote:
>
> Dne ponedeljek, 29. november 2021 ob 18:16:31 CET je Chen-Yu Tsai napisal(a):
> > On Tue, Nov 30, 2021 at 12:55 AM Jernej Skrabec
> > <jernej.skrabec@gmail.com> wrote:
> > >
> > > Several H3 and one H2+ board have power key nodes, which are slightly
> > > off. Some are missing wakeup-source property and some have BTN_0 code
> > > assigned instead of KEY_POWER.
> >
> > It might have been that after shutdown there was really no way to
> > "power on" the board with these GPIO power keys, so we didn't use
> > KEY_POWER for them?
>
> KEY_POWER is actually processed by userspace, so it would still make sense to
> power down board if power key is pressed. Correct me if I'm wrong, but in
> combination with wfi it could work before SCP FW was available?
I guess it could? But where would it do wfi, and what would execute
after wfi?
IIRC the kernel's halt sequence doesn't really clean up interrupts,
so wfi isn't going to get very far.
> >
> > > Adjust them, so they can function as intended by designer.
> > >
> > > Co-developed-by: Michael Klein <michael@fossekall.de>
> > > Signed-off-by: Michael Klein <michael@fossekall.de>
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> >
> > Acked-by: Chen-Yu Tsai <wens@csie.org>
> >
>
> Thanks!
>
> Best regards,
> Jernej
>
>
next prev parent reply other threads:[~2021-11-29 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 16:55 [PATCH v2] ARM: dts: sun8i: Adjust power key nodes Jernej Skrabec
2021-11-29 17:16 ` Chen-Yu Tsai
2021-11-29 17:29 ` Jernej Škrabec
2021-11-29 17:35 ` Chen-Yu Tsai [this message]
2021-12-01 8:21 ` (subset) " Maxime Ripard
2022-02-15 0:27 ` Guenter Roeck
2022-02-15 20:34 ` Jernej Škrabec
2022-02-15 22:20 ` Guenter Roeck
2022-02-16 4:11 ` Samuel Holland
2022-02-16 4:26 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v66ZGMxqgU7sGrSrnog3yHZ+Ny_xJdvBFVYZWH2Q5XbiCQ@mail.gmail.com \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=michael@fossekall.de \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).