From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Lars Povlsen <lars.povlsen@microchip.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
devicetree <devicetree@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v8 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO
Date: Wed, 11 Nov 2020 13:26:18 +0200 [thread overview]
Message-ID: <CAHp75VfZRJuzvaYs-CKvxitfOxcNc-7j8MZA7FQvN0SQrPK6cw@mail.gmail.com> (raw)
In-Reply-To: <87zh3oe0nr.fsf@microchip.com>
On Wed, Nov 11, 2020 at 10:52 AM Lars Povlsen
<lars.povlsen@microchip.com> wrote:
> Andy Shevchenko writes:
> > On Tue, Nov 10, 2020 at 5:51 PM Lars Povlsen <lars.povlsen@microchip.com> wrote:
> >> > On Mon, Nov 9, 2020 at 3:27 PM Lars Povlsen <lars.povlsen@microchip.com> wrote:
...
> >> >> + return -EOPNOTSUPP;
> >> >
> >> > Are you sure? IIRC internally we are using ENOTSUPP.
> >> >
> >> > Couple of drivers seem to be wrongly using the other one.
> >>
> >> Checkpatch complains about ENOTSUPP:
> >>
> >> # ENOTSUPP is not a standard error code and should be avoided in new patches.
> >> # Folks usually mean EOPNOTSUPP (also called ENOTSUP), when they type ENOTSUPP.
> >
> > checkpatch is wrong if this is internal code and to me sounds like
> > it's not going out of the kernel.
> >
> > ...
>
> As it appears there are different opinions on this I'll let the pinctrl
> maintainer decide.
There are no other opinions.
Read description of struct pinconf_ops and fix the code.
checkpatch is simply wrong here.
> >> >> + err = -EOPNOTSUPP;
> >> >
> >> > Ditto.
> >>
> >> Ditto.
> >
> > Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-11 11:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 13:26 [PATCH v8 0/3] Adding support for Microchip/Microsemi serial GPIO controller Lars Povlsen
2020-11-09 13:26 ` [PATCH v8 1/3] dt-bindings: pinctrl: Add bindings for pinctrl-microchip-sgpio driver Lars Povlsen
2020-11-09 13:26 ` [PATCH v8 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO Lars Povlsen
2020-11-09 14:17 ` Andy Shevchenko
2020-11-09 14:32 ` Alexandre Belloni
2020-11-09 15:16 ` Andy Shevchenko
2020-11-09 15:27 ` Alexandre Belloni
2020-11-09 16:15 ` Andy Shevchenko
2020-11-09 16:22 ` Alexandre Belloni
2020-11-10 15:59 ` Lars Povlsen
2020-11-10 15:51 ` Lars Povlsen
2020-11-10 16:26 ` Andy Shevchenko
2020-11-11 8:51 ` Lars Povlsen
2020-11-11 11:26 ` Andy Shevchenko [this message]
2020-11-11 11:53 ` Lars Povlsen
2020-11-09 13:26 ` [PATCH v8 3/3] arm64: dts: sparx5: Add SGPIO devices Lars Povlsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfZRJuzvaYs-CKvxitfOxcNc-7j8MZA7FQvN0SQrPK6cw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).