[PATCH] arm64: dts: sdm845: Fixup OPP table for all qup devices

[PATCH] arm64: dts: sdm845: Fixup OPP table for all qup devices

[Rajendra Nayak]

This OPP table was based on the clock VDD-FMAX tables seen in
downstream code, however it turns out the downstream clock
driver does update these tables based on later/production
rev of the chip and whats seen in the tables belongs to an
early engineering rev of the SoC.
Fix up the OPP tables such that it now matches with the
production rev of sdm845 SoC.

Fixes: 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup
devices")
Reported-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 2884577..eca81cf 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -1093,8 +1093,8 @@
 		qup_opp_table: qup-opp-table {
 			compatible = "operating-points-v2";
 
-			opp-19200000 {
-				opp-hz = /bits/ 64 <19200000>;
+			opp-50000000 {
+				opp-hz = /bits/ 64 <50000000>;
 				required-opps = <&rpmhpd_opp_min_svs>;
 			};
 
@@ -1107,6 +1107,11 @@
 				opp-hz = /bits/ 64 <100000000>;
 				required-opps = <&rpmhpd_opp_svs>;
 			};
+
+			opp-128000000 {
+				opp-hz = /bits/ 64 <128000000>;
+				required-opps = <&rpmhpd_opp_nom>;
+			};
 		};
 
 		qupv3_id_0: geniqup@8c0000 {
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCH] arm64: dts: sdm845: Fixup OPP table for all qup devices

[Amit Pundir]

On Wed, 12 Aug 2020 at 15:52, Rajendra Nayak <rnayak@codeaurora.org> wrote:
>
> This OPP table was based on the clock VDD-FMAX tables seen in
> downstream code, however it turns out the downstream clock
> driver does update these tables based on later/production
> rev of the chip and whats seen in the tables belongs to an
> early engineering rev of the SoC.
> Fix up the OPP tables such that it now matches with the
> production rev of sdm845 SoC.
>
> Fixes: 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup
> devices")

Fixes BT on Xiaomi Poco F1 phone running AOSP.

Tested-by: Amit Pundir <amit.pundir@linaro.org>

> Reported-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 2884577..eca81cf 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1093,8 +1093,8 @@
>                 qup_opp_table: qup-opp-table {
>                         compatible = "operating-points-v2";
>
> -                       opp-19200000 {
> -                               opp-hz = /bits/ 64 <19200000>;
> +                       opp-50000000 {
> +                               opp-hz = /bits/ 64 <50000000>;
>                                 required-opps = <&rpmhpd_opp_min_svs>;
>                         };
>
> @@ -1107,6 +1107,11 @@
>                                 opp-hz = /bits/ 64 <100000000>;
>                                 required-opps = <&rpmhpd_opp_svs>;
>                         };
> +
> +                       opp-128000000 {
> +                               opp-hz = /bits/ 64 <128000000>;
> +                               required-opps = <&rpmhpd_opp_nom>;
> +                       };
>                 };
>
>                 qupv3_id_0: geniqup@8c0000 {
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>

Re: [PATCH] arm64: dts: sdm845: Fixup OPP table for all qup devices

[John Stultz]

On Wed, Aug 12, 2020 at 3:23 AM Rajendra Nayak <rnayak@codeaurora.org> wrote:
>
> This OPP table was based on the clock VDD-FMAX tables seen in
> downstream code, however it turns out the downstream clock
> driver does update these tables based on later/production
> rev of the chip and whats seen in the tables belongs to an
> early engineering rev of the SoC.
> Fix up the OPP tables such that it now matches with the
> production rev of sdm845 SoC.
>
> Fixes: 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup
> devices")
> Reported-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---

Just wanted to follow up on this, as it's still missing from 5.9-rc3
and is needed to fix a bluetooth regression on db845c from 5.9-rc1.

Amit has already validated it (on PocoF1 as well), but just in case its useful:
Tested-by: John Stultz <john.stultz@linaro.org>

thanks
-john

Re: [PATCH] arm64: dts: sdm845: Fixup OPP table for all qup devices

[John Stultz]

On Mon, Aug 31, 2020 at 9:04 PM John Stultz <john.stultz@linaro.org> wrote:
> On Wed, Aug 12, 2020 at 3:23 AM Rajendra Nayak <rnayak@codeaurora.org> wrote:
> > This OPP table was based on the clock VDD-FMAX tables seen in
> > downstream code, however it turns out the downstream clock
> > driver does update these tables based on later/production
> > rev of the chip and whats seen in the tables belongs to an
> > early engineering rev of the SoC.
> > Fix up the OPP tables such that it now matches with the
> > production rev of sdm845 SoC.
> >
> > Fixes: 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup
> > devices")
> > Reported-by: John Stultz <john.stultz@linaro.org>
> > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> > ---
>
> Just wanted to follow up on this, as it's still missing from 5.9-rc3
> and is needed to fix a bluetooth regression on db845c from 5.9-rc1.
>
> Amit has already validated it (on PocoF1 as well), but just in case its useful:
> Tested-by: John Stultz <john.stultz@linaro.org>

Hey Everyone,
  Just wanted to nag folks on this again as it is still missing from
upstream and resolves a bluetooth regression from 5.9-rc1.

thanks
-john

Re: [PATCH] arm64: dts: sdm845: Fixup OPP table for all qup devices

[John Stultz]

On Mon, Sep 7, 2020 at 1:37 PM John Stultz <john.stultz@linaro.org> wrote:
>
> On Mon, Aug 31, 2020 at 9:04 PM John Stultz <john.stultz@linaro.org> wrote:
> > On Wed, Aug 12, 2020 at 3:23 AM Rajendra Nayak <rnayak@codeaurora.org> wrote:
> > > This OPP table was based on the clock VDD-FMAX tables seen in
> > > downstream code, however it turns out the downstream clock
> > > driver does update these tables based on later/production
> > > rev of the chip and whats seen in the tables belongs to an
> > > early engineering rev of the SoC.
> > > Fix up the OPP tables such that it now matches with the
> > > production rev of sdm845 SoC.
> > >
> > > Fixes: 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup
> > > devices")
> > > Reported-by: John Stultz <john.stultz@linaro.org>
> > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> > > ---
> >
> > Just wanted to follow up on this, as it's still missing from 5.9-rc3
> > and is needed to fix a bluetooth regression on db845c from 5.9-rc1.
> >
> > Amit has already validated it (on PocoF1 as well), but just in case its useful:
> > Tested-by: John Stultz <john.stultz@linaro.org>
>
> Hey Everyone,
>   Just wanted to nag folks on this again as it is still missing from
> upstream and resolves a bluetooth regression from 5.9-rc1.

Hey Everyone,
 Just your weekly nag on this patch that is still missing upstream.
This patch fixes bluetooth regressions that started w/ 5.9-rc1. It
would be great to see it land before 5.9 is finalized.

thanks
-john

Re: [PATCH] arm64: dts: sdm845: Fixup OPP table for all qup devices

[Steev Klimaszewski]

On 9/14/20 4:53 PM, John Stultz wrote:
> On Mon, Sep 7, 2020 at 1:37 PM John Stultz <john.stultz@linaro.org> wrote:
>> On Mon, Aug 31, 2020 at 9:04 PM John Stultz <john.stultz@linaro.org> wrote:
>>> On Wed, Aug 12, 2020 at 3:23 AM Rajendra Nayak <rnayak@codeaurora.org> wrote:
>>>> This OPP table was based on the clock VDD-FMAX tables seen in
>>>> downstream code, however it turns out the downstream clock
>>>> driver does update these tables based on later/production
>>>> rev of the chip and whats seen in the tables belongs to an
>>>> early engineering rev of the SoC.
>>>> Fix up the OPP tables such that it now matches with the
>>>> production rev of sdm845 SoC.
>>>>
>>>> Fixes: 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup
>>>> devices")
>>>> Reported-by: John Stultz <john.stultz@linaro.org>
>>>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>>>> ---
>>> Just wanted to follow up on this, as it's still missing from 5.9-rc3
>>> and is needed to fix a bluetooth regression on db845c from 5.9-rc1.
>>>
>>> Amit has already validated it (on PocoF1 as well), but just in case its useful:
>>> Tested-by: John Stultz <john.stultz@linaro.org>
>> Hey Everyone,
>>   Just wanted to nag folks on this again as it is still missing from
>> upstream and resolves a bluetooth regression from 5.9-rc1.
> Hey Everyone,
>  Just your weekly nag on this patch that is still missing upstream.
> This patch fixes bluetooth regressions that started w/ 5.9-rc1. It
> would be great to see it land before 5.9 is finalized.
>
> thanks
> -john

Also tested that this fixes it for the Lenovo Yoga C630

Tested-By: Steev Klimaszewski <steev@kali.org>