From: Rob Herring <robh@kernel.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-power <linux-power@fi.rohmeurope.com>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 04/15] dt_bindings: bd71828: Add clock output mode
Date: Wed, 13 Jan 2021 09:52:41 -0600 [thread overview]
Message-ID: <CAL_Jsq+N8dw82O-K6O53iogisgK2QZ=TEf7UCbBEbQGi9w4W9Q@mail.gmail.com> (raw)
In-Reply-To: <629dbc81badc9facea538733bfa8ddc0842b1df7.camel@fi.rohmeurope.com>
On Wed, Jan 13, 2021 at 8:52 AM Matti Vaittinen
<matti.vaittinen@fi.rohmeurope.com> wrote:
>
>
> On Wed, 2021-01-13 at 07:52 -0600, Rob Herring wrote:
> > On Fri, Jan 08, 2021 at 03:34:16PM +0200, Matti Vaittinen wrote:
> > > The BD71828 allows configuring the clk32kout pin mode to CMOS or
> > > open-drain. Add device-tree property for specifying the preferred
> > > mode.
> > >
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > ---
> > > .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml | 7
> > > +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-
> > > pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-
> > > pmic.yaml
> > > index 3a6a1a26e2b3..cba085836bc0 100644
> > > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> > > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> > > @@ -44,6 +44,13 @@ properties:
> > > clock-output-names:
> > > const: bd71828-32k-out
> > >
> > > + rohm,clkout-mode:
> > > + description: clk32kout mode. Can be set to "open-drain" or
> > > "cmos".
> > > + $ref: "/schemas/types.yaml#/definitions/string"
> > > + enum:
> > > + - open-drain
> > > + - cmos
> > > +
> >
> > I think a boolean or tristate ((0/1/not present) if you need 'leave
> > default') would be better.
>
> I was thinking of boolean but I hit the exact problem of leaving the
> default. (Booleans are so tempting for a lazy coder like me :] ) Do you
> mean uint with allowed values of 0/1 with the tristated?
Yes.
> I can sure do
> that - but wouldn't open-drain / cmos be more descriptive?
You'd get at least half by naming it 'rohm,clkout-open-drain'. I think
anyone that knows what open-drain means will know what !open-drain
implies.
Rob
next prev parent reply other threads:[~2021-01-13 15:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 13:27 [PATCH 00/15] Support ROHM BD71815 PMIC Matti Vaittinen
2021-01-08 13:32 ` [PATCH 03/15] mfd: bd718x7: simplify by cleaning unnecessary device data Matti Vaittinen
2021-01-08 13:34 ` [PATCH 04/15] dt_bindings: bd71828: Add clock output mode Matti Vaittinen
2021-01-13 13:52 ` Rob Herring
2021-01-13 14:52 ` Matti Vaittinen
2021-01-13 15:52 ` Rob Herring [this message]
2021-01-08 13:34 ` [PATCH 05/15] dt_bindings: mfd: Add ROHM BD71815 PMIC Matti Vaittinen
2021-01-11 19:06 ` Rob Herring
2021-01-12 6:14 ` Vaittinen, Matti
2021-01-08 13:36 ` [PATCH 06/15] dt_bindings: regulator: Add ROHM BD71815 PMIC regulators Matti Vaittinen
2021-01-11 19:09 ` Rob Herring
2021-01-12 6:10 ` Matti Vaittinen
2021-01-13 13:53 ` Rob Herring
2021-01-13 14:23 ` Vaittinen, Matti
2021-01-13 15:47 ` Rob Herring
2021-01-08 13:37 ` [PATCH 07/15] mfd: Add ROHM BD71815 ID Matti Vaittinen
2021-01-08 13:37 ` [PATCH 08/15] mfd: Support for ROHM BD71815 PMIC core Matti Vaittinen
2021-01-08 13:46 ` [PATCH 15/15] MAINTAINERS: Add ROHM BD71815AGW Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+N8dw82O-K6O53iogisgK2QZ=TEf7UCbBEbQGi9w4W9Q@mail.gmail.com' \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).