From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Rob Herring <robh@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-power@fi.rohmeurope.com, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 06/15] dt_bindings: regulator: Add ROHM BD71815 PMIC regulators
Date: Tue, 12 Jan 2021 08:10:14 +0200 [thread overview]
Message-ID: <c953405d630efba5377b89931ae4e0aa1abfa4dd.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20210111190953.GB2890911@robh.at.kernel.org>
On Mon, 2021-01-11 at 13:09 -0600, Rob Herring wrote:
> On Fri, Jan 08, 2021 at 03:36:38PM +0200, Matti Vaittinen wrote:
> > Add binding documentation for regulators on ROHM BD71815 PMIC.
> > 5 bucks, 7 LDOs and a boost for LED.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> > .../regulator/rohm,bd71815-regulator.yaml | 104
> > ++++++++++++++++++
> > 1 file changed, 104 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/regulator/rohm,bd71815-
> > regulator.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/regulator/rohm,bd71815-
> > regulator.yaml
> > b/Documentation/devicetree/bindings/regulator/rohm,bd71815-
> > regulator.yaml
> > new file mode 100644
> > index 000000000000..2aa21603698c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/rohm,bd71815-
> > regulator.yaml
> > @@ -0,0 +1,104 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id:
> > http://devicetree.org/schemas/regulator/rohm,bd71815-regulator.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ROHM BD71815 Power Management Integrated Circuit regulators
> > +
> > +maintainers:
> > + - Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > +
> > +description: |
> > + This module is part of the ROHM BD718215 MFD device. For more
> > details
> > + see Documentation/devicetree/bindings/mfd/rohm,bd71815-
> > pmic.yaml.
> > +
> > + The regulator controller is represented as a sub-node of the
> > PMIC node
> > + on the device tree.
> > +
> > + The valid names for BD71815 regulator nodes are
> > + buck1, buck2, buck3, buck4, buck5,
> > + ldo1, ldo2, ldo3, ldo4, ldo5,
> > + ldodvref, ldolpsr, wled
>
> No schema for the last 3?
Thanks Rob. I'm unsure what I have been thinking of :( I'll fix this
for next version.
>
> > +
> > +patternProperties:
> > + "^(ldo|buck)[1-5]$":
> > + type: object
> > + description:
> > + Properties for single LDO/BUCK regulator.
> > + $ref: regulator.yaml#
> > +
> > + properties:
> > + regulator-name:
> > + pattern: "^(ldo|buck)[1-5]$"
> > + description:
> > + should be "ldo1", ..., "ldo5" and "buck1", ..., "buck5"
> > +
> > + rohm,vsel-gpios:
> > + description:
> > + GPIO used to control ldo4 state (when ldo4 is controlled
> > by GPIO).
> > +
> > + rohm,dvs-run-voltage:
>
> These should have a unit suffix.
I know but these are existing properties. I'd like to re-use them as
they have exported parser helpers - and I am unsure what kind of
breakages changing them would cause. (The BD71837/BD71847 which
introduced these properties are one of the PMICs which are pretty
widely used.)
Best Regards
Matti Vaittinen
next prev parent reply other threads:[~2021-01-12 6:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 13:27 [PATCH 00/15] Support ROHM BD71815 PMIC Matti Vaittinen
2021-01-08 13:32 ` [PATCH 03/15] mfd: bd718x7: simplify by cleaning unnecessary device data Matti Vaittinen
2021-01-08 13:34 ` [PATCH 04/15] dt_bindings: bd71828: Add clock output mode Matti Vaittinen
2021-01-13 13:52 ` Rob Herring
2021-01-13 14:52 ` Matti Vaittinen
2021-01-13 15:52 ` Rob Herring
2021-01-08 13:34 ` [PATCH 05/15] dt_bindings: mfd: Add ROHM BD71815 PMIC Matti Vaittinen
2021-01-11 19:06 ` Rob Herring
2021-01-12 6:14 ` Vaittinen, Matti
2021-01-08 13:36 ` [PATCH 06/15] dt_bindings: regulator: Add ROHM BD71815 PMIC regulators Matti Vaittinen
2021-01-11 19:09 ` Rob Herring
2021-01-12 6:10 ` Matti Vaittinen [this message]
2021-01-13 13:53 ` Rob Herring
2021-01-13 14:23 ` Vaittinen, Matti
2021-01-13 15:47 ` Rob Herring
2021-01-08 13:37 ` [PATCH 07/15] mfd: Add ROHM BD71815 ID Matti Vaittinen
2021-01-08 13:37 ` [PATCH 08/15] mfd: Support for ROHM BD71815 PMIC core Matti Vaittinen
2021-01-08 13:46 ` [PATCH 15/15] MAINTAINERS: Add ROHM BD71815AGW Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c953405d630efba5377b89931ae4e0aa1abfa4dd.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).