devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-4.4-rc3/scripts/dtc/libfdt/fdt.c:88: code that relies on undefined behaviour ?
@ 2015-11-30 18:02 David Binderman
       [not found] ` <DUB128-W60BE88653C27C6610D81059C000-MsuGFMq8XAE@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2015-11-30 18:02 UTC (permalink / raw)
  To: Rob Herring, Frank Rowand, Grant Likely, devicetree

Hello there,

[linux-4.4-rc3/scripts/dtc/libfdt/fdt.c:88]: (warning) Invalid test for overflow 'p+len<p'. Condition is always false unless there is overflow, and overflow is UB.

Source code is

    if (p + len < p)
        return NULL;

Suggest code rework.

Regards

David Binderman

 		 	   		  

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-4.4-rc3/scripts/dtc/libfdt/fdt.c:88: code that relies on undefined behaviour ?
       [not found] ` <DUB128-W60BE88653C27C6610D81059C000-MsuGFMq8XAE@public.gmane.org>
@ 2016-03-17 22:57   ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2016-03-17 22:57 UTC (permalink / raw)
  To: David Binderman
  Cc: Frank Rowand, Grant Likely, devicetree-u79uwXL29TY76Z2rM5mHXA

+devicetree-compiler list

On Mon, Nov 30, 2015 at 12:02 PM, David Binderman <dcb314-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org> wrote:
> Hello there,
>
> [linux-4.4-rc3/scripts/dtc/libfdt/fdt.c:88]: (warning) Invalid test for overflow 'p+len<p'. Condition is always false unless there is overflow, and overflow is UB.

Upstream dtc needs to be fixed first. Patches welcome.

>
> Source code is
>
>     if (p + len < p)
>         return NULL;
>
> Suggest code rework.
>
> Regards
>
> David Binderman
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-17 22:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-30 18:02 linux-4.4-rc3/scripts/dtc/libfdt/fdt.c:88: code that relies on undefined behaviour ? David Binderman
     [not found] ` <DUB128-W60BE88653C27C6610D81059C000-MsuGFMq8XAE@public.gmane.org>
2016-03-17 22:57   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).