From: Rob Herring <robh+dt@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sebastian Reichel <sre@kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Collabora Kernel ML <kernel@collabora.com>
Subject: Re: [PATCH 04/38] dt-bindings: power: supply: bq25890: Convert to DT schema format
Date: Mon, 15 Mar 2021 12:21:34 -0600 [thread overview]
Message-ID: <CAL_JsqKFJPSMyMbcrpnL1WgttHSP+3Q+U8bJ_m5hm=O0gEPe4g@mail.gmail.com> (raw)
In-Reply-To: <20210312154357.1561730-5-sebastian.reichel@collabora.com>
On Fri, Mar 12, 2021 at 8:44 AM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> Convert the binding to DT schema format.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> .../bindings/power/supply/bq25890.txt | 60 ---------
> .../bindings/power/supply/bq25890.yaml | 125 ++++++++++++++++++
> 2 files changed, 125 insertions(+), 60 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/power/supply/bq25890.txt
> create mode 100644 Documentation/devicetree/bindings/power/supply/bq25890.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b/Documentation/devicetree/bindings/power/supply/bq25890.txt
> deleted file mode 100644
> index 805040c6fff9..000000000000
> --- a/Documentation/devicetree/bindings/power/supply/bq25890.txt
> +++ /dev/null
> @@ -1,60 +0,0 @@
> -Binding for TI bq25890 Li-Ion Charger
> -
> -This driver will support the bq25892, the bq25896 and the bq25890. There are
> -other ICs in the same family but those have not been tested.
> -
> -Required properties:
> -- compatible: Should contain one of the following:
> - * "ti,bq25890"
> - * "ti,bq25892"
> - * "ti,bq25895"
> - * "ti,bq25896"
> -- reg: integer, i2c address of the device.
> -- interrupts: interrupt line;
> -- ti,battery-regulation-voltage: integer, maximum charging voltage (in uV);
> -- ti,charge-current: integer, maximum charging current (in uA);
> -- ti,termination-current: integer, charge will be terminated when current in
> - constant-voltage phase drops below this value (in uA);
> -- ti,precharge-current: integer, maximum charge current during precharge
> - phase (in uA);
> -- ti,minimum-sys-voltage: integer, when battery is charging and it is below
> - minimum system voltage, the system will be regulated above
> - minimum-sys-voltage setting (in uV);
> -- ti,boost-voltage: integer, VBUS voltage level in boost mode (in uV);
> -- ti,boost-max-current: integer, maximum allowed current draw in boost mode
> - (in uA).
> -
> -Optional properties:
> -- ti,boost-low-freq: boolean, if present boost mode frequency will be 500kHz,
> - otherwise 1.5MHz;
> -- ti,use-ilim-pin: boolean, if present the ILIM resistor will be used and the
> - input current will be the lower between the resistor setting and the IINLIM
> - register setting;
> -- ti,thermal-regulation-threshold: integer, temperature above which the charge
> - current is lowered, to avoid overheating (in degrees Celsius). If omitted,
> - the default setting will be used (120 degrees);
> -- ti,ibatcomp-micro-ohms: integer, value of a resistor in series with
> - the battery;
> -- ti,ibatcomp-clamp-microvolt: integer, maximum charging voltage adjustment due
> - to expected voltage drop on in-series resistor;
> -
> -Example:
> -
> -bq25890 {
> - compatible = "ti,bq25890";
> - reg = <0x6a>;
> -
> - interrupt-parent = <&gpio1>;
> - interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
> -
> - ti,battery-regulation-voltage = <4200000>;
> - ti,charge-current = <1000000>;
> - ti,termination-current = <50000>;
> - ti,precharge-current = <128000>;
> - ti,minimum-sys-voltage = <3600000>;
> - ti,boost-voltage = <5000000>;
> - ti,boost-max-current = <1000000>;
> -
> - ti,use-ilim-pin;
> - ti,thermal-regulation-threshold = <120>;
> -};
> diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.yaml b/Documentation/devicetree/bindings/power/supply/bq25890.yaml
> new file mode 100644
> index 000000000000..de6e03ec120c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/bq25890.yaml
> @@ -0,0 +1,125 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (C) 2021 Sebastian Reichel
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/bq25890.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Binding for bq25890, bq25892, bq25895 and bq25896 Li-Ion Charger
> +
> +maintainers:
> + - Sebastian Reichel <sre@kernel.org>
> +
> +allOf:
> + - $ref: power-supply.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - ti,bq25890
> + - ti,bq25892
> + - ti,bq25895
> + - ti,bq25896
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + ti,battery-regulation-voltage:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: maximum charging voltage (in uV)
> +
> + ti,charge-current:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: maximum charging current (in uA)
> +
> + ti,termination-current:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + charge will be terminated when current in constant-voltage phase
> + drops below this value (in uA)
> +
> + ti,precharge-current:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: maximum charge current during precharge phase (in uA)
> +
> + ti,minimum-sys-voltage:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + when battery is charging and it is below minimum system voltage,
> + the system will be regulated above minimum-sys-voltage setting (in uV)
> +
> + ti,boost-voltage:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: VBUS voltage level in boost mode (in uV)
> +
> + ti,boost-max-current:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: maximum allowed current draw in boost mode (in uA)
> +
> + ti,boost-low-freq:
> + description: boost mode frequency will be 500kHz, otherwise 1.5MHz
> + type: boolean
> +
> + ti,use-ilim-pin:
> + description: |
> + ILIM resistor will be used and the input current will be the lower
> + between the resistor setting and the IINLIM register setting
> + type: boolean
> +
> + ti,thermal-regulation-threshold:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + temperature above which the charge current is lowered, to avoid overheating
> + (in degrees Celsius). If omitted, the default setting will be used (120 degrees)
> +
> + ti,ibatcomp-micro-ohms:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: value of a resistor in series with the battery (in Micro Ohms)
> +
> + ti,ibatcomp-clamp-microvolt:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: max. charging voltage adjustment due to expected voltage drop on in-series resistor
You don't need a type $ref on properties with a standard unit suffix.
Though it looks like there's some non-standard ones (-microvolts) in
the series.
Rob
next prev parent reply other threads:[~2021-03-15 18:22 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 15:43 [PATCH 00/38] Convert power-supply DT bindings to YAML Sebastian Reichel
2021-03-12 15:43 ` [PATCH 01/38] ARM: dts: motorola-cpcap-mapphone: Prepare for dtbs_check parsing Sebastian Reichel
2021-03-12 15:43 ` [PATCH 02/38] dt-bindings: power: supply: cpcap-battery: Convert to DT schema format Sebastian Reichel
2021-03-12 15:43 ` [PATCH 03/38] dt-bindings: power: supply: cpcap-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 04/38] dt-bindings: power: supply: bq25890: " Sebastian Reichel
2021-03-15 18:21 ` Rob Herring [this message]
2021-03-16 16:46 ` Sebastian Reichel
2021-03-16 17:50 ` Rob Herring
2021-03-12 15:43 ` [PATCH 05/38] dt-bindings: power: supply: bq24257: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 06/38] dt-bindings: power: supply: bq24190: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 07/38] dt-bindings: power: supply: bq2415x: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 08/38] dt-bindings: power: supply: bq24735: " Sebastian Reichel
2021-03-15 18:24 ` Rob Herring
2021-03-16 16:22 ` Sebastian Reichel
2021-03-16 17:45 ` Rob Herring
2021-03-12 15:43 ` [PATCH 09/38] dt-bindings: power: supply: isp1704: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 10/38] dt-bindings: power: supply: sbs-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 11/38] dt-bindings: power: supply: sbs-manager: " Sebastian Reichel
2021-03-15 18:27 ` Rob Herring
2021-03-12 15:43 ` [PATCH 12/38] dt-bindings: power: supply: ds2760: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 13/38] dt-bindings: power: supply: sc27xx-fg: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 14/38] dt-bindings: power: supply: sc2731-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 15/38] dt-bindings: power: supply: tps65090: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 16/38] dt-bindings: power: supply: tps65217: " Sebastian Reichel
2021-03-15 18:33 ` Rob Herring
2021-03-16 16:20 ` Sebastian Reichel
2021-03-16 17:52 ` Rob Herring
2021-03-12 15:43 ` [PATCH 17/38] dt-bindings: power: supply: twl4030: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 18/38] dt-bindings: power: supply: n900-battery: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 19/38] dt-bindings: power: supply: lego-ev3-battery: " Sebastian Reichel
2021-03-12 16:04 ` David Lechner
2021-03-12 15:43 ` [PATCH 20/38] dt-bindings: power: supply: max17040: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 21/38] dt-bindings: power: supply: max14656: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 22/38] dt-bindings: power: supply: max17042: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 23/38] dt-bindings: power: supply: max8903: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 24/38] dt-bindings: power: supply: ucs1002: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 25/38] dt-bindings: power: supply: pm8941-charger: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 26/38] dt-bindings: power: supply: pm8941-coincell: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 27/38] dt-bindings: power: supply: act8945a: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 28/38] dt-bindings: power: supply: axp20x: " Sebastian Reichel
2021-03-24 3:02 ` Chen-Yu Tsai
2021-03-12 15:43 ` [PATCH 29/38] dt-bindings: power: supply: da9150: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 30/38] dt-bindings: power: supply: lp8727: " Sebastian Reichel
2021-03-15 18:37 ` Rob Herring
2021-03-12 15:43 ` [PATCH 31/38] dt-bindings: power: supply: lt3651: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 32/38] dt-bindings: power: supply: ltc294x: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 33/38] dt-bindings: power: supply: rt9455: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 34/38] dt-bindings: power: supply: olpc-battery: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 35/38] dt-bindings: power: supply: ab8500: " Sebastian Reichel
2021-03-12 15:43 ` [PATCH 36/38] dt-bindings: power: supply: sbs-battery: Fix dtbs_check Sebastian Reichel
2021-03-12 15:43 ` [PATCH 37/38] dt-bindings: power: supply: Fix remaining battery.txt links Sebastian Reichel
2021-03-12 15:43 ` [PATCH 38/38] dt-bindings: power: supply: Drop power_supply.txt Sebastian Reichel
2021-03-15 19:44 ` [PATCH 00/38] Convert power-supply DT bindings to YAML Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKFJPSMyMbcrpnL1WgttHSP+3Q+U8bJ_m5hm=O0gEPe4g@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).