* audio-graph-port.yaml doesn't work ?
@ 2021-05-25 5:50 Kuninori Morimoto
2021-07-15 18:12 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2021-05-25 5:50 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree
Hi Rob
I noticed that it seems "$ref: audio-graph-port.yaml#" is not working.
For example, below is under "renesas,rcar.yaml" control which
is using "$ref: audio-graph-port.yaml#" for ports/port and endpoint.
"audio-graph-port.yaml" has "endpoint" properties,
and below are not allowed by it.
But there is no warning/error by
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
Am I misunderstanding ?
--------
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 1f177af3eb9d..f40ec421b45a 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -410,8 +410,8 @@ rsnd_port0: port@0 {
rsnd_for_ak4613: endpoint {
remote-endpoint = <&ak4613_endpoint>;
- dai-format = "left_j";
+ dai-format = "foo-bar";
- bitclock-master = <&rsnd_for_ak4613>;
+ bitclock-master = <1>;
frame-master = <&rsnd_for_ak4613>;
playback = <&ssi0>, <&src0>, <&dvc0>;
------
Thank you for your help !!
Best regards
---
Kuninori Morimoto
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: audio-graph-port.yaml doesn't work ?
2021-05-25 5:50 audio-graph-port.yaml doesn't work ? Kuninori Morimoto
@ 2021-07-15 18:12 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-07-15 18:12 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: devicetree
On Mon, May 24, 2021 at 11:50 PM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
>
> Hi Rob
>
> I noticed that it seems "$ref: audio-graph-port.yaml#" is not working.
> For example, below is under "renesas,rcar.yaml" control which
> is using "$ref: audio-graph-port.yaml#" for ports/port and endpoint.
>
> "audio-graph-port.yaml" has "endpoint" properties,
> and below are not allowed by it.
> But there is no warning/error by
>
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
>
> Am I misunderstanding ?
Sorry, I missed this. Independently, with some meta-schema
improvements I think I found the issue:
ports:
$ref: /schemas/graph.yaml#/properties/ports
properties:
port(@[0-9a-f]+)?:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
The problem is you have a regex under 'properties' so it's treated as
a fixed string.
Will send out a patch shortly.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-15 18:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 5:50 audio-graph-port.yaml doesn't work ? Kuninori Morimoto
2021-07-15 18:12 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).