devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB
@ 2020-05-27 13:29 Lad Prabhakar
  2020-06-05 12:27 ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Lad Prabhakar @ 2020-05-27 13:29 UTC (permalink / raw)
  To: Geert Uytterhoeven, Rob Herring, Magnus Damm
  Cc: devicetree, linux-kernel, linux-renesas-soc, Prabhakar, Lad Prabhakar

Add support for the camera daughter board which is connected to
iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
ethernet1 interfaces.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
---
 arch/arm/boot/dts/Makefile                      |  1 +
 arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts | 94 +++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ed3376c..118e35c 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -918,6 +918,7 @@ dtb-$(CONFIG_ARCH_RENESAS) += \
 	r8a73a4-ape6evm.dtb \
 	r8a7740-armadillo800eva.dtb \
 	r8a7742-iwg21d-q7.dtb \
+	r8a7742-iwg21d-q7-dbcm-ca.dtb \
 	r8a7743-iwg20d-q7.dtb \
 	r8a7743-iwg20d-q7-dbcm-ca.dtb \
 	r8a7743-sk-rzg1m.dtb \
diff --git a/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
new file mode 100644
index 0000000..857aab5
--- /dev/null
+++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
@@ -0,0 +1,94 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree Source for the iWave-RZ/G1H Qseven board development
+ * platform with camera daughter board
+ *
+ * Copyright (C) 2020 Renesas Electronics Corp.
+ */
+
+/dts-v1/;
+#include "r8a7742-iwg21d-q7.dts"
+
+/ {
+	model = "iWave Systems RZ/G1H Qseven development platform with camera add-on";
+	compatible = "iwave,g21d", "iwave,g21m", "renesas,r8a7742";
+
+	aliases {
+		serial0 = &scif0;
+		serial1 = &scif1;
+		serial3 = &scifb1;
+		serial5 = &hscif0;
+		ethernet1 = &ether;
+	};
+};
+
+&avb {
+	/* Pins shared with VIN0, keep status disabled */
+	status = "disabled";
+};
+
+&ether {
+	pinctrl-0 = <&ether_pins>;
+	pinctrl-names = "default";
+
+	phy-handle = <&phy1>;
+	renesas,ether-link-active-low;
+	status = "okay";
+
+	phy1: ethernet-phy@1 {
+		reg = <1>;
+		micrel,led-mode = <1>;
+	};
+};
+
+&hscif0 {
+	pinctrl-0 = <&hscif0_pins>;
+	pinctrl-names = "default";
+	uart-has-rtscts;
+	status = "okay";
+};
+
+&pfc {
+	ether_pins: ether {
+		groups = "eth_mdio", "eth_rmii";
+		function = "eth";
+	};
+
+	hscif0_pins: hscif0 {
+		groups = "hscif0_data", "hscif0_ctrl";
+		function = "hscif0";
+	};
+
+	scif0_pins: scif0 {
+		groups = "scif0_data";
+		function = "scif0";
+	};
+
+	scif1_pins: scif1 {
+		groups = "scif1_data";
+		function = "scif1";
+	};
+
+	scifb1_pins: scifb1 {
+		groups = "scifb1_data";
+		function = "scifb1";
+	};
+};
+
+&scif0 {
+	pinctrl-0 = <&scif0_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&scif1 {
+	pinctrl-0 = <&scif1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&scifb1 {
+	pinctrl-0 = <&scifb1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB
  2020-05-27 13:29 [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB Lad Prabhakar
@ 2020-06-05 12:27 ` Geert Uytterhoeven
  2020-06-07 16:18   ` Lad, Prabhakar
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-06-05 12:27 UTC (permalink / raw)
  To: Lad Prabhakar
  Cc: Rob Herring, Magnus Damm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Linux-Renesas, Prabhakar

Hi Prabhakar,

On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Add support for the camera daughter board which is connected to
> iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
> ethernet1 interfaces.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- /dev/null
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts

> +&scifb1 {
> +       pinctrl-0 = <&scifb1_pins>;
> +       pinctrl-names = "default";
> +       status = "okay";

Before I queue this in renesas-devel for v5.9, I have on question:
As this port carries RTS/CTS signals, perhaps you want to add

    rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>;
    cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;

?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB
  2020-06-05 12:27 ` Geert Uytterhoeven
@ 2020-06-07 16:18   ` Lad, Prabhakar
  2020-06-07 17:41     ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Lad, Prabhakar @ 2020-06-07 16:18 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Lad Prabhakar, Rob Herring, Magnus Damm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Linux-Renesas

Hi Geert,

Thank you for the review.

On Fri, Jun 5, 2020 at 1:27 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > Add support for the camera daughter board which is connected to
> > iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
> > ethernet1 interfaces.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
>
> > +&scifb1 {
> > +       pinctrl-0 = <&scifb1_pins>;
> > +       pinctrl-names = "default";
> > +       status = "okay";
>
> Before I queue this in renesas-devel for v5.9, I have on question:
> As this port carries RTS/CTS signals, perhaps you want to add
>
>     rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>;
>     cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
>
Aaha the user manual mentioned RTS/CTS wasn't connected, but I tested
this with the above which disproves the Doc. Shall I post it as a
separate patch or post a v2 including it.

Cheers,
--Prabhakar

> ?
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB
  2020-06-07 16:18   ` Lad, Prabhakar
@ 2020-06-07 17:41     ` Geert Uytterhoeven
  2020-06-07 17:48       ` Prabhakar Mahadev Lad
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-06-07 17:41 UTC (permalink / raw)
  To: Lad, Prabhakar
  Cc: Lad Prabhakar, Rob Herring, Magnus Damm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Linux-Renesas

Hi Prabhakar,

On Sun, Jun 7, 2020 at 6:19 PM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Fri, Jun 5, 2020 at 1:27 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > Add support for the camera daughter board which is connected to
> > > iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
> > > ethernet1 interfaces.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> >
> > > +&scifb1 {
> > > +       pinctrl-0 = <&scifb1_pins>;
> > > +       pinctrl-names = "default";
> > > +       status = "okay";
> >
> > Before I queue this in renesas-devel for v5.9, I have on question:
> > As this port carries RTS/CTS signals, perhaps you want to add
> >
> >     rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>;
> >     cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> >
> Aaha the user manual mentioned RTS/CTS wasn't connected, but I tested
> this with the above which disproves the Doc. Shall I post it as a

RTS/CTS are indeed not connected to the dedicated RTS/CTS pins of
SCIFB1, so the documentation is right.
However, the pins on the serial port connector can be used as GPIOs,
hence they can be used with software-controlled RTS/CTS.

> separate patch or post a v2 including it.

Up to you, I can handle both.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB
  2020-06-07 17:41     ` Geert Uytterhoeven
@ 2020-06-07 17:48       ` Prabhakar Mahadev Lad
  0 siblings, 0 replies; 5+ messages in thread
From: Prabhakar Mahadev Lad @ 2020-06-07 17:48 UTC (permalink / raw)
  To: Geert Uytterhoeven, Lad, Prabhakar
  Cc: Rob Herring, Magnus Damm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List, Linux-Renesas

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 07 June 2020 18:42
> To: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; Magnus Damm
> <magnus.damm@gmail.com>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Linux
> Kernel Mailing List <linux-kernel@vger.kernel.org>; Linux-Renesas <linux-renesas-soc@vger.kernel.org>
> Subject: Re: [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB
>
> Hi Prabhakar,
>
> On Sun, Jun 7, 2020 at 6:19 PM Lad, Prabhakar
> <prabhakar.csengg@gmail.com> wrote:
> > On Fri, Jun 5, 2020 at 1:27 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar
> > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > > Add support for the camera daughter board which is connected to
> > > > iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and
> > > > ethernet1 interfaces.
> > > >
> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > > --- /dev/null
> > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts
> > >
> > > > +&scifb1 {
> > > > +       pinctrl-0 = <&scifb1_pins>;
> > > > +       pinctrl-names = "default";
> > > > +       status = "okay";
> > >
> > > Before I queue this in renesas-devel for v5.9, I have on question:
> > > As this port carries RTS/CTS signals, perhaps you want to add
> > >
> > >     rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>;
> > >     cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> > >
> > Aaha the user manual mentioned RTS/CTS wasn't connected, but I tested
> > this with the above which disproves the Doc. Shall I post it as a
>
> RTS/CTS are indeed not connected to the dedicated RTS/CTS pins of
> SCIFB1, so the documentation is right.
> However, the pins on the serial port connector can be used as GPIOs,
> hence they can be used with software-controlled RTS/CTS.
>
> > separate patch or post a v2 including it.
>
> Up to you, I can handle both.
>
I shall post a v2.

Cheers,
--Prabhakar

> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-06-07 17:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 13:29 [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB Lad Prabhakar
2020-06-05 12:27 ` Geert Uytterhoeven
2020-06-07 16:18   ` Lad, Prabhakar
2020-06-07 17:41     ` Geert Uytterhoeven
2020-06-07 17:48       ` Prabhakar Mahadev Lad

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).