From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting
Date: Wed, 5 Aug 2020 13:41:40 +0200 [thread overview]
Message-ID: <CAMuHMdXPRsB3N=sfL0VgvAxxHLNCHhotsc501kG9-KMDoYXRJA@mail.gmail.com> (raw)
In-Reply-To: <20200729122602.9561-1-biju.das.jz@bp.renesas.com>
Hi Biju,
On Wed, Jul 29, 2020 at 2:26 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Some device nodes in the r8a7745-iwg22d-sodimm.dts are not sorted
> alphabetically. This patch fixes the sorting of nodes and also fixes a
> typo in the stmpe node.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> @@ -53,6 +53,25 @@
> clock-frequency = <26000000>;
> };
>
> + backlight_lcd: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&tpu 3 5000000 PWM_POLARITY_INVERTED>;
> + brightness-levels = <0 4 8 16 32 64 128 255>;
> + default-brightness-level = <7>;
> + };
> +
> + lcd_panel: lcd {
> + compatible = "edt,etm043080dh6gp";
> + power-supply = <&vccq_panel>;
> + backlight = <&backlight_lcd>;
> +
> + port {
> + lcd_in: endpoint {
> + remote-endpoint = <&du_out_rgb0>;
> + };
> + };
> + };
> +
> rsnd_sgtl5000: sound {
Shouldn't the sound node be moved below the regulator nodes?
> compatible = "simple-audio-card";
> simple-audio-card,format = "i2s";
> @@ -68,18 +87,6 @@
> };
> };
>
> - vccq_sdhi0: regulator-vccq-sdhi0 {
> - compatible = "regulator-gpio";
> -
> - regulator-name = "SDHI0 VccQ";
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <3300000>;
> -
> - gpios = <&gpio0 20 GPIO_ACTIVE_LOW>;
> - gpios-states = <1>;
> - states = <3300000 1>, <1800000 0>;
> - };
> -
> vccq_panel: regulator-vccq-panel {
> compatible = "regulator-fixed";
> regulator-name = "Panel VccQ";
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-08-05 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 12:26 [PATCH] ARM: dts: iwg22d-sodimm: Fix dt nodes sorting Biju Das
2020-07-29 20:38 ` Lad, Prabhakar
2020-08-05 11:41 ` Geert Uytterhoeven [this message]
2020-08-05 12:16 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXPRsB3N=sfL0VgvAxxHLNCHhotsc501kG9-KMDoYXRJA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).