* [PATCH] dt-bindings: mmc: Correct the type of the clk phase properties
@ 2019-11-22 7:15 Manish Narani
2019-11-22 7:44 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Manish Narani @ 2019-11-22 7:15 UTC (permalink / raw)
To: ulf.hansson, robh+dt, mark.rutland
Cc: linux-mmc, devicetree, linux-kernel, git, Manish Narani
The clock phase properties are having two uint32 values. The minItems
and maxItems are set to 2 for the same. So the property type should be
'uint32-array' and not 'uint32'. Modify it to correct the same.
Reported-by: Rob Herring <robh@kernel.org>
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
---
.../devicetree/bindings/mmc/mmc-controller.yaml | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index 305b2016bc17..b130450c3b34 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -334,16 +334,17 @@ patternProperties:
- reg
"^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)|uhs-(sdr(12|25|50|104)|ddr50))$":
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32-array
minItems: 2
maxItems: 2
- allOf:
- - $ref: /schemas/types.yaml#/definitions/uint32
- - minimum: 0
- maximum: 359
- description:
- Set the clock (phase) delays which are to be configured in the
- controller while switching to particular speed mode. These values
- are in pair of degrees.
+ items:
+ minimum: 0
+ maximum: 359
+ description:
+ Set the clock (phase) delays which are to be configured in the
+ controller while switching to particular speed mode. These values
+ are in pair of degrees.
dependencies:
cd-debounce-delay-ms: [ cd-gpios ]
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: mmc: Correct the type of the clk phase properties
2019-11-22 7:15 [PATCH] dt-bindings: mmc: Correct the type of the clk phase properties Manish Narani
@ 2019-11-22 7:44 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2019-11-22 7:44 UTC (permalink / raw)
To: Manish Narani
Cc: Rob Herring, Mark Rutland, linux-mmc, DTML,
Linux Kernel Mailing List, git
On Fri, 22 Nov 2019 at 08:16, Manish Narani <manish.narani@xilinx.com> wrote:
>
> The clock phase properties are having two uint32 values. The minItems
> and maxItems are set to 2 for the same. So the property type should be
> 'uint32-array' and not 'uint32'. Modify it to correct the same.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> .../devicetree/bindings/mmc/mmc-controller.yaml | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 305b2016bc17..b130450c3b34 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -334,16 +334,17 @@ patternProperties:
> - reg
>
> "^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)|uhs-(sdr(12|25|50|104)|ddr50))$":
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32-array
> minItems: 2
> maxItems: 2
> - allOf:
> - - $ref: /schemas/types.yaml#/definitions/uint32
> - - minimum: 0
> - maximum: 359
> - description:
> - Set the clock (phase) delays which are to be configured in the
> - controller while switching to particular speed mode. These values
> - are in pair of degrees.
> + items:
> + minimum: 0
> + maximum: 359
> + description:
> + Set the clock (phase) delays which are to be configured in the
> + controller while switching to particular speed mode. These values
> + are in pair of degrees.
>
> dependencies:
> cd-debounce-delay-ms: [ cd-gpios ]
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-22 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 7:15 [PATCH] dt-bindings: mmc: Correct the type of the clk phase properties Manish Narani
2019-11-22 7:44 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).