* [PATCH v2] arm64: dts: exynosautov9: convert serial_0 for USI
[not found] <CGME20211208092527epcas2p28f6688d5a2742c03cf474d8b2fa773cd@epcas2p2.samsung.com>
@ 2021-12-08 9:18 ` Chanho Park
2021-12-08 10:45 ` Sam Protsenko
2021-12-13 11:11 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Chanho Park @ 2021-12-08 9:18 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, Chanho Park,
Sam Protsenko
According to USI v2 driver change[1], serial_0 node should be converted to
use the USI node hierarchy. syscon_peric0 will be used as a syscon node
to control the USI00_USI_SW_CONF register.
This also changes the serial node name from uart@ to serial@.
[1]: https://lore.kernel.org/linux-samsung-soc/20211204195757.8600-2-semen.protsenko@linaro.org/
Cc: Sam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
Change from v1:
- Put usi_0 node alphabetically in sadk.dts
.../boot/dts/exynos/exynosautov9-sadk.dts | 4 +++
arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 36 ++++++++++++++-----
2 files changed, 32 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
index ef46d7aa6e28..57518cb5e8c4 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
+++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
@@ -54,3 +54,7 @@ &ufs_0 {
vcc-supply = <&ufs_0_fixed_vcc_reg>;
vcc-fixed-regulator;
};
+
+&usi_0 {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
index a960c0bc2dba..de8fcb82eaec 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
@@ -7,6 +7,7 @@
*/
#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/soc/samsung,exynos-usi.h>
/ {
compatible = "samsung,exynosautov9";
@@ -256,16 +257,35 @@ syscon_fsys2: syscon@17c20000 {
reg = <0x17c20000 0x1000>;
};
- /* USI: UART */
- serial_0: uart@10300000 {
- compatible = "samsung,exynos850-uart";
- reg = <0x10300000 0x100>;
- interrupts = <GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH>;
- pinctrl-names = "default";
- pinctrl-0 = <&uart0_bus_dual>;
+ syscon_peric0: syscon@10220000 {
+ compatible = "samsung,exynosautov9-sysreg", "syscon";
+ reg = <0x10220000 0x2000>;
+ };
+
+ usi_0: usi@103000c0 {
+ compatible = "samsung,exynos850-usi";
+ reg = <0x103000c0 0x20>;
+ samsung,sysreg = <&syscon_peric0 0x1000>;
+ samsung,mode = <USI_V2_UART>;
+ samsung,clkreq-on; /* needed for UART mode */
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
clocks = <&uart_clock>, <&uart_clock>;
- clock-names = "uart", "clk_uart_baud0";
+ clock-names = "pclk", "ipclk";
status = "disabled";
+
+ /* USI: UART */
+ serial_0: serial@10300000 {
+ compatible = "samsung,exynos850-uart";
+ reg = <0x10300000 0xc0>;
+ interrupts = <GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart0_bus_dual>;
+ clocks = <&uart_clock>, <&uart_clock>;
+ clock-names = "uart", "clk_uart_baud0";
+ status = "disabled";
+ };
};
ufs_0_phy: ufs0-phy@17e04000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: exynosautov9: convert serial_0 for USI
2021-12-08 9:18 ` [PATCH v2] arm64: dts: exynosautov9: convert serial_0 for USI Chanho Park
@ 2021-12-08 10:45 ` Sam Protsenko
2021-12-13 11:11 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Sam Protsenko @ 2021-12-08 10:45 UTC (permalink / raw)
To: Chanho Park
Cc: Rob Herring, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc
On Wed, 8 Dec 2021 at 11:25, Chanho Park <chanho61.park@samsung.com> wrote:
>
> According to USI v2 driver change[1], serial_0 node should be converted to
> use the USI node hierarchy. syscon_peric0 will be used as a syscon node
> to control the USI00_USI_SW_CONF register.
> This also changes the serial node name from uart@ to serial@.
>
> [1]: https://lore.kernel.org/linux-samsung-soc/20211204195757.8600-2-semen.protsenko@linaro.org/
>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
Thanks for helping us out!
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Change from v1:
> - Put usi_0 node alphabetically in sadk.dts
>
> .../boot/dts/exynos/exynosautov9-sadk.dts | 4 +++
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 36 ++++++++++++++-----
> 2 files changed, 32 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> index ef46d7aa6e28..57518cb5e8c4 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> @@ -54,3 +54,7 @@ &ufs_0 {
> vcc-supply = <&ufs_0_fixed_vcc_reg>;
> vcc-fixed-regulator;
> };
> +
> +&usi_0 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> index a960c0bc2dba..de8fcb82eaec 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> @@ -7,6 +7,7 @@
> */
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/soc/samsung,exynos-usi.h>
>
> / {
> compatible = "samsung,exynosautov9";
> @@ -256,16 +257,35 @@ syscon_fsys2: syscon@17c20000 {
> reg = <0x17c20000 0x1000>;
> };
>
> - /* USI: UART */
> - serial_0: uart@10300000 {
> - compatible = "samsung,exynos850-uart";
> - reg = <0x10300000 0x100>;
> - interrupts = <GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&uart0_bus_dual>;
> + syscon_peric0: syscon@10220000 {
> + compatible = "samsung,exynosautov9-sysreg", "syscon";
> + reg = <0x10220000 0x2000>;
> + };
> +
> + usi_0: usi@103000c0 {
> + compatible = "samsung,exynos850-usi";
> + reg = <0x103000c0 0x20>;
> + samsung,sysreg = <&syscon_peric0 0x1000>;
> + samsung,mode = <USI_V2_UART>;
> + samsung,clkreq-on; /* needed for UART mode */
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> clocks = <&uart_clock>, <&uart_clock>;
> - clock-names = "uart", "clk_uart_baud0";
> + clock-names = "pclk", "ipclk";
> status = "disabled";
> +
> + /* USI: UART */
> + serial_0: serial@10300000 {
> + compatible = "samsung,exynos850-uart";
> + reg = <0x10300000 0xc0>;
> + interrupts = <GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_bus_dual>;
> + clocks = <&uart_clock>, <&uart_clock>;
> + clock-names = "uart", "clk_uart_baud0";
> + status = "disabled";
> + };
> };
>
> ufs_0_phy: ufs0-phy@17e04000 {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: exynosautov9: convert serial_0 for USI
2021-12-08 9:18 ` [PATCH v2] arm64: dts: exynosautov9: convert serial_0 for USI Chanho Park
2021-12-08 10:45 ` Sam Protsenko
@ 2021-12-13 11:11 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-12-13 11:11 UTC (permalink / raw)
To: Rob Herring, Chanho Park
Cc: Krzysztof Kozlowski, linux-samsung-soc, Sam Protsenko,
linux-arm-kernel, devicetree
On Wed, 8 Dec 2021 18:18:53 +0900, Chanho Park wrote:
> According to USI v2 driver change[1], serial_0 node should be converted to
> use the USI node hierarchy. syscon_peric0 will be used as a syscon node
> to control the USI00_USI_SW_CONF register.
> This also changes the serial node name from uart@ to serial@.
>
> [1]: https://lore.kernel.org/linux-samsung-soc/20211204195757.8600-2-semen.protsenko@linaro.org/
>
> [...]
Applied, thanks!
[1/1] arm64: dts: exynosautov9: convert serial_0 for USI
commit: 7836149e155bd3c554571f135619f95932c841fc
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-13 11:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20211208092527epcas2p28f6688d5a2742c03cf474d8b2fa773cd@epcas2p2.samsung.com>
2021-12-08 9:18 ` [PATCH v2] arm64: dts: exynosautov9: convert serial_0 for USI Chanho Park
2021-12-08 10:45 ` Sam Protsenko
2021-12-13 11:11 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).