* [PATCH] ahci: qoriq: added ls2088a platforms support
@ 2017-01-17 6:12 yuantian.tang
2017-01-18 19:21 ` Tejun Heo
2017-01-18 19:53 ` Tejun Heo
0 siblings, 2 replies; 4+ messages in thread
From: yuantian.tang @ 2017-01-17 6:12 UTC (permalink / raw)
To: tj
Cc: robh+dt, mark.rutland, linux-ide, devicetree, linux-kernel,
linux-arm-kernel, Tang Yuantian, Tang Yuantian
From: Tang Yuantian <Yuantian.Tang@nxp.com>
Ls2088a is new introduced arm-based soc with sata support with
following features:
1. Complies with the serial ATA 3.0 specification and the AHCI 1.3.1
specification
2. Contains a high-speed descriptor-based DMA controller
3. Supports the following:
a. Speeds of 1.5 Gb/s (first-generation SATA), 3 Gb/s
(second-generation SATA), and 6 Gb/s (third-generation SATA)
b. FIS-based switching
c. Native command queuing (NCQ) commands
d. Port multiplier operation
e. Asynchronous notification
f. SATA BIST mode
Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
---
Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt | 2 +-
drivers/ata/ahci_qoriq.c | 9 +++++++++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
index fc33ca0..ed87c6f 100644
--- a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
+++ b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
@@ -3,7 +3,7 @@ Binding for Freescale QorIQ AHCI SATA Controller
Required properties:
- reg: Physical base address and size of the controller's register area.
- compatible: Compatibility string. Must be 'fsl,<chip>-ahci', where
- chip could be ls1021a, ls1043a, ls1046a, ls2080a etc.
+ chip could be ls1021a, ls1043a, ls1046a, ls2080a, ls2088a etc.
- clocks: Input clock specifier. Refer to common clock bindings.
- interrupts: Interrupt specifier. Refer to interrupt binding.
diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c
index 66eb4b5..912fe32 100644
--- a/drivers/ata/ahci_qoriq.c
+++ b/drivers/ata/ahci_qoriq.c
@@ -53,6 +53,7 @@ enum ahci_qoriq_type {
AHCI_LS1043A,
AHCI_LS2080A,
AHCI_LS1046A,
+ AHCI_LS2088A,
};
struct ahci_qoriq_priv {
@@ -67,6 +68,7 @@ static const struct of_device_id ahci_qoriq_of_match[] = {
{ .compatible = "fsl,ls1043a-ahci", .data = (void *)AHCI_LS1043A},
{ .compatible = "fsl,ls2080a-ahci", .data = (void *)AHCI_LS2080A},
{ .compatible = "fsl,ls1046a-ahci", .data = (void *)AHCI_LS1046A},
+ { .compatible = "fsl,ls2088a-ahci", .data = (void *)AHCI_LS2088A},
{},
};
MODULE_DEVICE_TABLE(of, ahci_qoriq_of_match);
@@ -193,6 +195,13 @@ static int ahci_qoriq_phy_init(struct ahci_host_priv *hpriv)
if (qpriv->is_dmacoherent)
writel(AHCI_PORT_AXICC_CFG, reg_base + PORT_AXICC);
break;
+
+ case AHCI_LS2088A:
+ writel(AHCI_PORT_PHY_1_CFG, reg_base + PORT_PHY1);
+ writel(AHCI_PORT_TRANS_CFG, reg_base + PORT_TRANS);
+ if (qpriv->is_dmacoherent)
+ writel(AHCI_PORT_AXICC_CFG, reg_base + PORT_AXICC);
+ break;
}
return 0;
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ahci: qoriq: added ls2088a platforms support
2017-01-17 6:12 [PATCH] ahci: qoriq: added ls2088a platforms support yuantian.tang
@ 2017-01-18 19:21 ` Tejun Heo
2017-01-18 19:53 ` Tejun Heo
1 sibling, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2017-01-18 19:21 UTC (permalink / raw)
To: yuantian.tang
Cc: mark.rutland, devicetree, linux-kernel, linux-ide, robh+dt,
linux-arm-kernel
On Tue, Jan 17, 2017 at 02:12:01PM +0800, yuantian.tang@nxp.com wrote:
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
>
> Ls2088a is new introduced arm-based soc with sata support with
> following features:
> 1. Complies with the serial ATA 3.0 specification and the AHCI 1.3.1
> specification
> 2. Contains a high-speed descriptor-based DMA controller
> 3. Supports the following:
> a. Speeds of 1.5 Gb/s (first-generation SATA), 3 Gb/s
> (second-generation SATA), and 6 Gb/s (third-generation SATA)
> b. FIS-based switching
> c. Native command queuing (NCQ) commands
> d. Port multiplier operation
> e. Asynchronous notification
> f. SATA BIST mode
>
> Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
Applied to libata/for-4.11.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ahci: qoriq: added ls2088a platforms support
2017-01-17 6:12 [PATCH] ahci: qoriq: added ls2088a platforms support yuantian.tang
2017-01-18 19:21 ` Tejun Heo
@ 2017-01-18 19:53 ` Tejun Heo
[not found] ` <20170118195351.GD9171-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
1 sibling, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2017-01-18 19:53 UTC (permalink / raw)
To: yuantian.tang
Cc: robh+dt, mark.rutland, linux-ide, devicetree, linux-kernel,
linux-arm-kernel
On Tue, Jan 17, 2017 at 02:12:01PM +0800, yuantian.tang@nxp.com wrote:
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
>
> Ls2088a is new introduced arm-based soc with sata support with
> following features:
> 1. Complies with the serial ATA 3.0 specification and the AHCI 1.3.1
> specification
> 2. Contains a high-speed descriptor-based DMA controller
> 3. Supports the following:
> a. Speeds of 1.5 Gb/s (first-generation SATA), 3 Gb/s
> (second-generation SATA), and 6 Gb/s (third-generation SATA)
> b. FIS-based switching
> c. Native command queuing (NCQ) commands
> d. Port multiplier operation
> e. Asynchronous notification
> f. SATA BIST mode
>
> Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
Reverted due to build failure. Did you even try to compile it before
submission? We all make mistakes and that's fine but this one seems a
bit too careless. Please don't do this.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ahci: qoriq: added ls2088a platforms support
[not found] ` <20170118195351.GD9171-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
@ 2017-01-20 3:05 ` Y.T. Tang
0 siblings, 0 replies; 4+ messages in thread
From: Y.T. Tang @ 2017-01-20 3:05 UTC (permalink / raw)
To: Tejun Heo
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
linux-ide-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
> -----Original Message-----
> From: Tejun Heo [mailto:htejun-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org] On Behalf Of Tejun Heo
> Sent: Thursday, January 19, 2017 3:54 AM
> To: Y.T. Tang <yuantian.tang-3arQi8VN3Tc@public.gmane.org>
> Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org; linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-
> kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Subject: Re: [PATCH] ahci: qoriq: added ls2088a platforms support
>
> On Tue, Jan 17, 2017 at 02:12:01PM +0800, yuantian.tang-3arQi8VN3Tc@public.gmane.org wrote:
> > From: Tang Yuantian <Yuantian.Tang-3arQi8VN3Tc@public.gmane.org>
> >
> > Ls2088a is new introduced arm-based soc with sata support with
> > following features:
> > 1. Complies with the serial ATA 3.0 specification and the AHCI 1.3.1
> > specification
> > 2. Contains a high-speed descriptor-based DMA controller 3. Supports
> > the following:
> > a. Speeds of 1.5 Gb/s (first-generation SATA), 3 Gb/s
> > (second-generation SATA), and 6 Gb/s (third-generation SATA)
> > b. FIS-based switching
> > c. Native command queuing (NCQ) commands
> > d. Port multiplier operation
> > e. Asynchronous notification
> > f. SATA BIST mode
> >
> > Signed-off-by: Tang Yuantian <yuantian.tang-3arQi8VN3Tc@public.gmane.org>
>
> Reverted due to build failure. Did you even try to compile it before
> submission? We all make mistakes and that's fine but this one seems a bit
> too careless. Please don't do this.
>
Sorry for the trouble.
I never send a patch without testing. This patch depends on other two patches which I sent a long time ago which I thought they were merged.
Anyway, my mistake.
I will resend all the patches with correct order.
Regards,
Yuantian
> Thanks.
>
> --
> tejun
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-20 3:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-17 6:12 [PATCH] ahci: qoriq: added ls2088a platforms support yuantian.tang
2017-01-18 19:21 ` Tejun Heo
2017-01-18 19:53 ` Tejun Heo
[not found] ` <20170118195351.GD9171-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2017-01-20 3:05 ` Y.T. Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).