* [PATCH v2] Documentation: devicetree: Clean up gpio-keys example
@ 2016-03-16 11:53 Andreas Färber
2016-03-16 14:47 ` Javier Martinez Canillas
2016-04-19 22:13 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Andreas Färber @ 2016-03-16 11:53 UTC (permalink / raw)
To: linux-input
Cc: Heiko Stuebner, linux-arm-kernel, linux-kernel,
Andreas Färber, Julien Chauveau, Javier Martinez Canillas,
Geert Uytterhoeven, Dmitry Torokhov, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Drop #address-cells and #size-cells, which are not required by the
gpio-keys binding documentation, as button sub-nodes are not devices.
Rename sub-nodes to avoid new dtc unit address warnings when copied.
While at it, adopt the dashes convention for the node name.
Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
Cc: Julien Chauveau <chauveau.julien@gmail.com>
Cc: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
v1 -> v2:
* Changed node name from underscore to dash
* Inserted white lines
* Renamed sub-nodes (Geert, Julien)
Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
index 21641236c095..a94940481e55 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.txt
+++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
@@ -32,17 +32,17 @@ Optional subnode-properties:
Example nodes:
- gpio_keys {
+ gpio-keys {
compatible = "gpio-keys";
- #address-cells = <1>;
- #size-cells = <0>;
autorepeat;
- button@21 {
+
+ up {
label = "GPIO Key UP";
linux,code = <103>;
gpios = <&gpio1 0 1>;
};
- button@22 {
+
+ down {
label = "GPIO Key DOWN";
linux,code = <108>;
interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
--
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example
2016-03-16 11:53 [PATCH v2] Documentation: devicetree: Clean up gpio-keys example Andreas Färber
@ 2016-03-16 14:47 ` Javier Martinez Canillas
2016-03-16 21:55 ` Julien Chauveau
2016-04-19 22:13 ` Rob Herring
1 sibling, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-03-16 14:47 UTC (permalink / raw)
To: Andreas Färber
Cc: linux-input, Heiko Stuebner, linux-arm-kernel, Linux Kernel,
Julien Chauveau, Geert Uytterhoeven, Dmitry Torokhov,
Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hello Andreas,
On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote:
> Drop #address-cells and #size-cells, which are not required by the
> gpio-keys binding documentation, as button sub-nodes are not devices.
>
> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>
> While at it, adopt the dashes convention for the node name.
>
> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example
2016-03-16 14:47 ` Javier Martinez Canillas
@ 2016-03-16 21:55 ` Julien Chauveau
2016-03-31 20:09 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Julien Chauveau @ 2016-03-16 21:55 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Andreas Färber, linux-input, Heiko Stuebner,
linux-arm-kernel, Linux Kernel, Geert Uytterhoeven,
Dmitry Torokhov, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> Le 16 mars 2016 à 15:47, Javier Martinez Canillas <javier@dowhile0.org> a écrit :
>
> Hello Andreas,
>
> On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>>
>> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>>
>> While at it, adopt the dashes convention for the node name.
>>
>> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
>> Cc: Julien Chauveau <chauveau.julien@gmail.com>
>> Cc: Javier Martinez Canillas <javier@dowhile0.org>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>
> Patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
I agree.
Reviewed-by: Julien Chauveau <chauveau.julien@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example
2016-03-16 21:55 ` Julien Chauveau
@ 2016-03-31 20:09 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2016-03-31 20:09 UTC (permalink / raw)
To: Julien Chauveau
Cc: Javier Martinez Canillas, Andreas Färber, linux-input,
Heiko Stuebner, linux-arm-kernel, Linux Kernel,
Geert Uytterhoeven, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Wed, Mar 16, 2016 at 10:55:53PM +0100, Julien Chauveau wrote:
>
> > Le 16 mars 2016 à 15:47, Javier Martinez Canillas <javier@dowhile0.org> a écrit :
> >
> > Hello Andreas,
> >
> > On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote:
> >> Drop #address-cells and #size-cells, which are not required by the
> >> gpio-keys binding documentation, as button sub-nodes are not devices.
> >>
> >> Rename sub-nodes to avoid new dtc unit address warnings when copied.
> >>
> >> While at it, adopt the dashes convention for the node name.
> >>
> >> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
> >> Cc: Julien Chauveau <chauveau.julien@gmail.com>
> >> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> >> Signed-off-by: Andreas Färber <afaerber@suse.de>
> >> ---
> >
> > Patch looks good to me.
> >
> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> I agree.
>
> Reviewed-by: Julien Chauveau <chauveau.julien@gmail.com>
Applied, thank you.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example
2016-03-16 11:53 [PATCH v2] Documentation: devicetree: Clean up gpio-keys example Andreas Färber
2016-03-16 14:47 ` Javier Martinez Canillas
@ 2016-04-19 22:13 ` Rob Herring
2016-04-19 22:16 ` Javier Martinez Canillas
1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2016-04-19 22:13 UTC (permalink / raw)
To: Andreas Färber
Cc: linux-input, Heiko Stuebner, linux-arm-kernel, linux-kernel,
Julien Chauveau, Javier Martinez Canillas, Geert Uytterhoeven,
Dmitry Torokhov, Pawel Moll, Mark Rutland, Ian Campbell,
Kumar Gala,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Wed, Mar 16, 2016 at 12:53:29PM +0100, Andreas Färber wrote:
> Drop #address-cells and #size-cells, which are not required by the
> gpio-keys binding documentation, as button sub-nodes are not devices.
>
> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>
> While at it, adopt the dashes convention for the node name.
>
> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Applied, thanks.
Rob
> ---
> v1 -> v2:
> * Changed node name from underscore to dash
> * Inserted white lines
> * Renamed sub-nodes (Geert, Julien)
>
> Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
> index 21641236c095..a94940481e55 100644
> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
> @@ -32,17 +32,17 @@ Optional subnode-properties:
>
> Example nodes:
>
> - gpio_keys {
> + gpio-keys {
> compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
> autorepeat;
> - button@21 {
> +
> + up {
> label = "GPIO Key UP";
> linux,code = <103>;
> gpios = <&gpio1 0 1>;
> };
> - button@22 {
> +
> + down {
> label = "GPIO Key DOWN";
> linux,code = <108>;
> interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> --
> 2.6.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example
2016-04-19 22:13 ` Rob Herring
@ 2016-04-19 22:16 ` Javier Martinez Canillas
0 siblings, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-04-19 22:16 UTC (permalink / raw)
To: Rob Herring
Cc: Andreas Färber, linux-input-u79uwXL29TY76Z2rM5mHXA,
Heiko Stuebner,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Linux Kernel,
Julien Chauveau, Geert Uytterhoeven, Dmitry Torokhov, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hello Rob,
On Tue, Apr 19, 2016 at 6:13 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Wed, Mar 16, 2016 at 12:53:29PM +0100, Andreas Färber wrote:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>>
>> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>>
>> While at it, adopt the dashes convention for the node name.
>>
>> Reported-by: Julien Chauveau <chauveau.julien-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Cc: Julien Chauveau <chauveau.julien-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Cc: Javier Martinez Canillas <javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
>> Cc: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
>> Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org>
>
> Applied, thanks.
>
Dmitry already applied this patch in the input tree.
> Rob
>
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-19 22:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-16 11:53 [PATCH v2] Documentation: devicetree: Clean up gpio-keys example Andreas Färber
2016-03-16 14:47 ` Javier Martinez Canillas
2016-03-16 21:55 ` Julien Chauveau
2016-03-31 20:09 ` Dmitry Torokhov
2016-04-19 22:13 ` Rob Herring
2016-04-19 22:16 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).