* [PATCH v2 0/3] usb: renesas_usbhs: Add RZ/A1 support
@ 2018-01-05 18:46 Chris Brandt
[not found] ` <20180105184609.24106-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Chris Brandt @ 2018-01-05 18:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Simon Horman
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven,
Sergei Shtylyov, Chris Brandt
This series adds RZ/A1 gadget support to the renesas_usbhs driver.
Basically, it's almost the same HW as the R-Car (and SH) parts.
The only real difference is the some extra registers for the PHY.
This was tested on an RSK board by connecting to a PC as an
Ethernet CDC gadget.
v2:
* Node name is now generic 'usb@'
* GIC_SPI (73-32) is now just GIC_SPI 41
* All hex number are lower case
* Added Reviewed-by
Chris Brandt (3):
usb: renesas_usbhs: Add support for RZ/A1
dt-bindings: usb: renesas_usbhs: Add support for RZ/A1
ARM: dts: r7s72100: add USB device to device tree
.../devicetree/bindings/usb/renesas_usbhs.txt | 2 +
arch/arm/boot/dts/r7s72100.dtsi | 20 +++++++++
drivers/usb/renesas_usbhs/Makefile | 2 +-
drivers/usb/renesas_usbhs/common.c | 17 +++++++
drivers/usb/renesas_usbhs/common.h | 6 +++
drivers/usb/renesas_usbhs/rza.c | 52 ++++++++++++++++++++++
drivers/usb/renesas_usbhs/rza.h | 4 ++
include/linux/usb/renesas_usbhs.h | 1 +
8 files changed, 103 insertions(+), 1 deletion(-)
create mode 100644 drivers/usb/renesas_usbhs/rza.c
create mode 100644 drivers/usb/renesas_usbhs/rza.h
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/3] usb: renesas_usbhs: Add support for RZ/A1
[not found] ` <20180105184609.24106-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2018-01-05 18:46 ` Chris Brandt
[not found] ` <20180105184609.24106-2-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2018-01-05 18:46 ` [PATCH v2 2/3] dt-bindings: " Chris Brandt
2018-01-05 18:46 ` [PATCH v2 3/3] ARM: dts: r7s72100: add USB device to device tree Chris Brandt
2 siblings, 1 reply; 7+ messages in thread
From: Chris Brandt @ 2018-01-05 18:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Simon Horman
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven,
Sergei Shtylyov, Chris Brandt
This patch adds the capability to support RZ/A1 SoCs.
Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
drivers/usb/renesas_usbhs/Makefile | 2 +-
drivers/usb/renesas_usbhs/common.c | 17 +++++++++++++
drivers/usb/renesas_usbhs/common.h | 6 +++++
drivers/usb/renesas_usbhs/rza.c | 52 ++++++++++++++++++++++++++++++++++++++
drivers/usb/renesas_usbhs/rza.h | 4 +++
include/linux/usb/renesas_usbhs.h | 1 +
6 files changed, 81 insertions(+), 1 deletion(-)
create mode 100644 drivers/usb/renesas_usbhs/rza.c
create mode 100644 drivers/usb/renesas_usbhs/rza.h
diff --git a/drivers/usb/renesas_usbhs/Makefile b/drivers/usb/renesas_usbhs/Makefile
index fac147a3ad23..5c5b51bb48ef 100644
--- a/drivers/usb/renesas_usbhs/Makefile
+++ b/drivers/usb/renesas_usbhs/Makefile
@@ -5,7 +5,7 @@
obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs.o
-renesas_usbhs-y := common.o mod.o pipe.o fifo.o rcar2.o rcar3.o
+renesas_usbhs-y := common.o mod.o pipe.o fifo.o rcar2.o rcar3.o rza.o
ifneq ($(CONFIG_USB_RENESAS_USBHS_HCD),)
renesas_usbhs-y += mod_host.o
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index c5289b3ecf8d..2abefd3d6050 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -17,6 +17,7 @@
#include "common.h"
#include "rcar2.h"
#include "rcar3.h"
+#include "rza.h"
/*
* image of renesas_usbhs
@@ -480,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = {
.compatible = "renesas,usbhs-r8a77995",
.data = (void *)USBHS_TYPE_RCAR_GEN3_WITH_PLL,
},
+ {
+ .compatible = "renesas,usbhs-r7s72100",
+ .data = (void *)USBHS_TYPE_RZA1,
+ },
{
.compatible = "renesas,rcar-gen2-usbhs",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
@@ -488,6 +493,10 @@ static const struct of_device_id usbhs_of_match[] = {
.compatible = "renesas,rcar-gen3-usbhs",
.data = (void *)USBHS_TYPE_RCAR_GEN3,
},
+ {
+ .compatible = "renesas,rza1-usbhs",
+ .data = (void *)USBHS_TYPE_RZA1,
+ },
{ },
};
MODULE_DEVICE_TABLE(of, usbhs_of_match);
@@ -520,6 +529,11 @@ static struct renesas_usbhs_platform_info *usbhs_parse_dt(struct device *dev)
dparam->pipe_size = ARRAY_SIZE(usbhsc_new_pipe);
}
+ if (dparam->type == USBHS_TYPE_RZA1) {
+ dparam->pipe_configs = usbhsc_new_pipe;
+ dparam->pipe_size = ARRAY_SIZE(usbhsc_new_pipe);
+ }
+
return info;
}
@@ -591,6 +605,9 @@ static int usbhs_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "no notifier registered\n");
}
break;
+ case USBHS_TYPE_RZA1:
+ priv->pfunc = usbhs_rza1_ops;
+ break;
default:
if (!info->platform_callback.get_id) {
dev_err(&pdev->dev, "no platform callbacks");
diff --git a/drivers/usb/renesas_usbhs/common.h b/drivers/usb/renesas_usbhs/common.h
index c9747f064601..f619afeae2b8 100644
--- a/drivers/usb/renesas_usbhs/common.h
+++ b/drivers/usb/renesas_usbhs/common.h
@@ -98,6 +98,7 @@ struct usbhs_priv;
#define D2FIFOCTR 0x00F2 /* for R-Car Gen2 */
#define D3FIFOSEL 0x00F4 /* for R-Car Gen2 */
#define D3FIFOCTR 0x00F6 /* for R-Car Gen2 */
+#define SUSPMODE 0x0102 /* for RZ/A */
/* SYSCFG */
#define SCKE (1 << 10) /* USB Module Clock Enable */
@@ -106,6 +107,8 @@ struct usbhs_priv;
#define DRPD (1 << 5) /* D+ Line/D- Line Resistance Control */
#define DPRPU (1 << 4) /* D+ Line Resistance Control */
#define USBE (1 << 0) /* USB Module Operation Enable */
+#define UCKSEL (1 << 2) /* Clock Select for RZ/A1 */
+#define UPLLE (1 << 1) /* USB PLL Enable for RZ/A1 */
/* DVSTCTR */
#define EXTLP (1 << 10) /* Controls the EXTLP pin output state */
@@ -233,6 +236,9 @@ struct usbhs_priv;
#define USBSPD_SPEED_FULL 0x2
#define USBSPD_SPEED_HIGH 0x3
+/* SUSPMODE */
+#define SUSPM (1 << 14) /* SuspendM Control */
+
/*
* struct
*/
diff --git a/drivers/usb/renesas_usbhs/rza.c b/drivers/usb/renesas_usbhs/rza.c
new file mode 100644
index 000000000000..b76e836d2c3d
--- /dev/null
+++ b/drivers/usb/renesas_usbhs/rza.c
@@ -0,0 +1,52 @@
+// SPDX-License-Identifier: GPL-1.0+
+/*
+ * Renesas USB driver RZ/A initialization and power control
+ *
+ * Copyright (C) 2018 Chris Brandt
+ * Copyright (C) 2018 Renesas Electronics Corporation
+ */
+
+#include <linux/delay.h>
+#include <linux/io.h>
+#include <linux/of_device.h>
+#include "common.h"
+#include "rza.h"
+
+static int usbhs_rza1_hardware_init(struct platform_device *pdev)
+{
+ struct usbhs_priv *priv = usbhs_pdev_to_priv(pdev);
+ struct device_node *usb_x1_clk, *extal_clk;
+ u32 freq_usb = 0, freq_extal = 0;
+
+ /* Input Clock Selection (NOTE: ch0 controls both ch0 and ch1) */
+ usb_x1_clk = of_find_node_by_name(NULL, "usb_x1");
+ extal_clk = of_find_node_by_name(NULL, "extal");
+ of_property_read_u32(usb_x1_clk, "clock-frequency", &freq_usb);
+ of_property_read_u32(extal_clk, "clock-frequency", &freq_extal);
+ if (freq_usb == 0) {
+ if (freq_extal == 12000000) {
+ /* Select 12MHz XTAL */
+ usbhs_bset(priv, SYSCFG, UCKSEL, UCKSEL);
+ } else {
+ dev_err(usbhs_priv_to_dev(priv), "A 48MHz USB clock or 12MHz main clock is required.\n");
+ return -EIO;
+ }
+ }
+
+ /* Enable USB PLL (NOTE: ch0 controls both ch0 and ch1) */
+ usbhs_bset(priv, SYSCFG, UPLLE, UPLLE);
+ udelay(1000);
+ usbhs_bset(priv, SUSPMODE, SUSPM, SUSPM);
+
+ return 0;
+}
+
+static int usbhs_rza_get_id(struct platform_device *pdev)
+{
+ return USBHS_GADGET;
+}
+
+const struct renesas_usbhs_platform_callback usbhs_rza1_ops = {
+ .hardware_init = usbhs_rza1_hardware_init,
+ .get_id = usbhs_rza_get_id,
+};
diff --git a/drivers/usb/renesas_usbhs/rza.h b/drivers/usb/renesas_usbhs/rza.h
new file mode 100644
index 000000000000..ca917ca54f6d
--- /dev/null
+++ b/drivers/usb/renesas_usbhs/rza.h
@@ -0,0 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
+#include "common.h"
+
+extern const struct renesas_usbhs_platform_callback usbhs_rza1_ops;
diff --git a/include/linux/usb/renesas_usbhs.h b/include/linux/usb/renesas_usbhs.h
index 9482735d4ca5..53924f8e840c 100644
--- a/include/linux/usb/renesas_usbhs.h
+++ b/include/linux/usb/renesas_usbhs.h
@@ -195,6 +195,7 @@ struct renesas_usbhs_driver_param {
#define USBHS_TYPE_RCAR_GEN2 1
#define USBHS_TYPE_RCAR_GEN3 2
#define USBHS_TYPE_RCAR_GEN3_WITH_PLL 3
+#define USBHS_TYPE_RZA1 4
/*
* option:
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/3] dt-bindings: usb: renesas_usbhs: Add support for RZ/A1
[not found] ` <20180105184609.24106-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2018-01-05 18:46 ` [PATCH v2 1/3] usb: renesas_usbhs: Add support for RZ/A1 Chris Brandt
@ 2018-01-05 18:46 ` Chris Brandt
2018-01-05 18:46 ` [PATCH v2 3/3] ARM: dts: r7s72100: add USB device to device tree Chris Brandt
2 siblings, 0 replies; 7+ messages in thread
From: Chris Brandt @ 2018-01-05 18:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Simon Horman
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven,
Sergei Shtylyov, Chris Brandt
Document support for RZ/A1 SoCs
Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
v2:
* Added Reviewed-by
---
Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 47394ab788e3..d060172f1529 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -13,8 +13,10 @@ Required properties:
- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
- "renesas,usbhs-r8a7796" for r8a7796 (R-Car M3-W) compatible device
- "renesas,usbhs-r8a77995" for r8a77995 (R-Car D3) compatible device
+ - "renesas,usbhs-r7s72100" for r7s72100 (RZ/A1) compatible device
- "renesas,rcar-gen2-usbhs" for R-Car Gen2 or RZ/G1 compatible devices
- "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
+ - "renesas,rza1-usbhs" for RZ/A1 compatible device
When compatible with the generic version, nodes must list the
SoC-specific version corresponding to the platform first followed
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/3] ARM: dts: r7s72100: add USB device to device tree
[not found] ` <20180105184609.24106-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2018-01-05 18:46 ` [PATCH v2 1/3] usb: renesas_usbhs: Add support for RZ/A1 Chris Brandt
2018-01-05 18:46 ` [PATCH v2 2/3] dt-bindings: " Chris Brandt
@ 2018-01-05 18:46 ` Chris Brandt
[not found] ` <20180105184609.24106-4-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2 siblings, 1 reply; 7+ messages in thread
From: Chris Brandt @ 2018-01-05 18:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Simon Horman
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven,
Sergei Shtylyov, Chris Brandt
Add USB device support.
Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
v2:
* Node name is now generic 'usb@'
* GIC_SPI (73-32) is now just GIC_SPI 41
* All hex number are lower case
* Added Reviewed-by
---
arch/arm/boot/dts/r7s72100.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index ab9645a42eca..f863f74b1b30 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -667,4 +667,24 @@
power-domains = <&cpg_clocks>;
status = "disabled";
};
+
+ usbhs0: usb@e8010000 {
+ compatible = "renesas,usbhs-r7s72100";
+ reg = <0xe8010000 0x1a0>;
+ interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp7_clks R7S72100_CLK_USB0>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
+
+ usbhs1: usb@e8207000 {
+ compatible = "renesas,usbhs-r7s72100";
+ reg = <0xe8207000 0x1a0>;
+ interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp7_clks R7S72100_CLK_USB1>;
+ renesas,buswait = <4>;
+ power-domains = <&cpg_clocks>;
+ status = "disabled";
+ };
};
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 3/3] ARM: dts: r7s72100: add USB device to device tree
[not found] ` <20180105184609.24106-4-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2018-01-05 20:17 ` Geert Uytterhoeven
0 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2018-01-05 20:17 UTC (permalink / raw)
To: Chris Brandt
Cc: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Simon Horman,
USB list, Linux-Renesas, devicetree-u79uwXL29TY76Z2rM5mHXA,
Sergei Shtylyov
On Fri, Jan 5, 2018 at 7:46 PM, Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote:
> Add USB device support.
>
> Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -667,4 +667,24 @@
> power-domains = <&cpg_clocks>;
> status = "disabled";
> };
> +
> + usbhs0: usb@e8010000 {
> + compatible = "renesas,usbhs-r7s72100";
+ "renesas,rza1-usbhs"
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/3] usb: renesas_usbhs: Add support for RZ/A1
[not found] ` <20180105184609.24106-2-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2018-01-05 20:18 ` Geert Uytterhoeven
2018-01-05 20:26 ` Chris Brandt
0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2018-01-05 20:18 UTC (permalink / raw)
To: Chris Brandt
Cc: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Simon Horman,
USB list, Linux-Renesas, devicetree-u79uwXL29TY76Z2rM5mHXA,
Sergei Shtylyov
Hi Chris,
On Fri, Jan 5, 2018 at 7:46 PM, Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote:
> This patch adds the capability to support RZ/A1 SoCs.
>
> Signed-off-by: Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Thanks for your patch!
> index c5289b3ecf8d..2abefd3d6050 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -480,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = {
> .compatible = "renesas,usbhs-r8a77995",
> .data = (void *)USBHS_TYPE_RCAR_GEN3_WITH_PLL,
> },
> + {
> + .compatible = "renesas,usbhs-r7s72100",
> + .data = (void *)USBHS_TYPE_RZA1,
> + },
I think it suffices to drop the part above...
> {
> .compatible = "renesas,rcar-gen2-usbhs",
> .data = (void *)USBHS_TYPE_RCAR_GEN2,
> @@ -488,6 +493,10 @@ static const struct of_device_id usbhs_of_match[] = {
> .compatible = "renesas,rcar-gen3-usbhs",
> .data = (void *)USBHS_TYPE_RCAR_GEN3,
> },
> + {
> + .compatible = "renesas,rza1-usbhs",
> + .data = (void *)USBHS_TYPE_RZA1,
> + },
... and just let the driver match against the generic compatible value.
But then you have to add "renesas,rza1-usbhs" to the DTS, too.
> --- /dev/null
> +++ b/drivers/usb/renesas_usbhs/rza.c
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: GPL-1.0+
Not GPL-2.0?
> +++ b/drivers/usb/renesas_usbhs/rza.h
> @@ -0,0 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
like here?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2 1/3] usb: renesas_usbhs: Add support for RZ/A1
2018-01-05 20:18 ` Geert Uytterhoeven
@ 2018-01-05 20:26 ` Chris Brandt
0 siblings, 0 replies; 7+ messages in thread
From: Chris Brandt @ 2018-01-05 20:26 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Simon Horman,
USB list, Linux-Renesas, devicetree, Sergei Shtylyov
Hi Geert,
On Friday, January 05, 2018, Geert Uytterhoeven wrote:
> > + {
> > + .compatible = "renesas,usbhs-r7s72100",
> > + .data = (void *)USBHS_TYPE_RZA1,
> > + },
>
> I think it suffices to drop the part above...
>
> > {
> > .compatible = "renesas,rcar-gen2-usbhs",
> > .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > @@ -488,6 +493,10 @@ static const struct of_device_id usbhs_of_match[] =
> {
> > .compatible = "renesas,rcar-gen3-usbhs",
> > .data = (void *)USBHS_TYPE_RCAR_GEN3,
> > },
> > + {
> > + .compatible = "renesas,rza1-usbhs",
> > + .data = (void *)USBHS_TYPE_RZA1,
> > + },
>
> ... and just let the driver match against the generic compatible value.
> But then you have to add "renesas,rza1-usbhs" to the DTS, too.
OK. I can do that.
I keep forgetting all the new/old DT rules.
I thought there was something about you always need a generic name and
also a device specific name.
I'm happy with just "renesas,rza1-usbhs".
> > --- /dev/null
> > +++ b/drivers/usb/renesas_usbhs/rza.c
> > @@ -0,0 +1,52 @@
> > +// SPDX-License-Identifier: GPL-1.0+
>
> Not GPL-2.0?
Oops. Copy/paste error.
I'll submit a V3 of the series.
Thanks!
Chris
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-01-05 20:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-05 18:46 [PATCH v2 0/3] usb: renesas_usbhs: Add RZ/A1 support Chris Brandt
[not found] ` <20180105184609.24106-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2018-01-05 18:46 ` [PATCH v2 1/3] usb: renesas_usbhs: Add support for RZ/A1 Chris Brandt
[not found] ` <20180105184609.24106-2-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2018-01-05 20:18 ` Geert Uytterhoeven
2018-01-05 20:26 ` Chris Brandt
2018-01-05 18:46 ` [PATCH v2 2/3] dt-bindings: " Chris Brandt
2018-01-05 18:46 ` [PATCH v2 3/3] ARM: dts: r7s72100: add USB device to device tree Chris Brandt
[not found] ` <20180105184609.24106-4-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2018-01-05 20:17 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).