RE: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
To: Simon Horman <horms@verge.net.au>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support
Date: Wed, 13 Dec 2017 09:50:16 +0000	[thread overview]
Message-ID: <TY1PR06MB0895BBA53926995AE47757A9C0350@TY1PR06MB0895.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20171213084048.jxofa3hinb6gm2ax@verge.net.au>

Hello Simon,

thank you for the feedback.
I'll apply your comments to V2, but I'll wait for your reply on the CMT "enable by default" issue.

Thanks,
Fab

> Subject: Re: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support
>
> On Tue, Dec 12, 2017 at 06:49:37PM +0000, Fabrizio Castro wrote:
> > Document SoC specific compatible strings for r8a7743 and r8a7745.
> > No driver change is needed as the fallback strings will activate
> > the right code.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/timer/renesas,cmt.txt | 12 +++++++++---
> >  1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> b/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> > index d740989..1e4fe98 100644
> > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> > @@ -22,6 +22,10 @@ Required Properties:
> >
> >      - "renesas,r8a73a4-cmt0" for the 32-bit CMT0 device included in r8a73a4.
> >      - "renesas,r8a73a4-cmt1" for the 48-bit CMT1 device included in r8a73a4.
> > +    - "renesas,r8a7743-cmt0" for the 32-bit CMT0 device included in r8a7743.
> > +    - "renesas,r8a7743-cmt1" for the 48-bit CMT1 device included in r8a7743.
> > +    - "renesas,r8a7745-cmt0" for the 32-bit CMT0 device included in r8a7745.
> > +    - "renesas,r8a7745-cmt1" for the 48-bit CMT1 device included in r8a7745.
> >      - "renesas,r8a7790-cmt0" for the 32-bit CMT0 device included in r8a7790.
> >      - "renesas,r8a7790-cmt1" for the 48-bit CMT1 device included in r8a7790.
> >      - "renesas,r8a7791-cmt0" for the 32-bit CMT0 device included in r8a7791.
> > @@ -31,9 +35,11 @@ Required Properties:
> >      - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794.
> >      - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794.
> >
> > -    - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2.
> > -    - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2.
> > -These are fallbacks for r8a73a4 and all the R-Car Gen2
> > +    - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2 or
>
> nit: or -> and ?
>
> > +RZ/G1.
> > +    - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2 or
> > +RZ/G1.
> > +These are fallbacks for r8a73a4, all the R-Car Gen2 and RZ/G1
> >  entrieslisted above.
>
> nit: all the R-Car -> R-Car
>
> >    - reg: base address and length of the registers block for the timer module.

[https://www2.renesas.eu/media/email/unicef_2017.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.

Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.