* [PATCH 0/3] Add CMT support to r8a774[35] @ 2017-12-12 18:49 Fabrizio Castro 2017-12-12 18:49 ` [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support Fabrizio Castro ` (2 more replies) 0 siblings, 3 replies; 15+ messages in thread From: Fabrizio Castro @ 2017-12-12 18:49 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Fabrizio Castro, Daniel Lezcano, Thomas Gleixner, Simon Horman, Magnus Damm, Geert Uytterhoeven, Chris Paterson, Biju Das, devicetree, linux-renesas-soc, linux-arm-kernel This series adds CMT support for r8a7743 and r8a7745. Thanks, Fabrizio Castro (3): dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support ARM: dts: r8a7743: Add CMT SoC specific support ARM: dts: r8a7745: Add CMT SoC specific support .../devicetree/bindings/timer/renesas,cmt.txt | 12 ++++++--- arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++ arch/arm/boot/dts/r8a7745.dtsi | 30 ++++++++++++++++++++++ 3 files changed, 69 insertions(+), 3 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support 2017-12-12 18:49 [PATCH 0/3] Add CMT support to r8a774[35] Fabrizio Castro @ 2017-12-12 18:49 ` Fabrizio Castro 2017-12-13 8:40 ` Simon Horman ` (2 more replies) 2017-12-12 18:49 ` [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support Fabrizio Castro 2017-12-12 18:49 ` [PATCH 3/3] ARM: dts: r8a7745: " Fabrizio Castro 2 siblings, 3 replies; 15+ messages in thread From: Fabrizio Castro @ 2017-12-12 18:49 UTC (permalink / raw) To: Rob Herring, Mark Rutland Cc: Fabrizio Castro, linux-renesas-soc, Daniel Lezcano, Thomas Gleixner, Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das, devicetree Document SoC specific compatible strings for r8a7743 and r8a7745. No driver change is needed as the fallback strings will activate the right code. Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Biju Das <biju.das@bp.renesas.com> --- Documentation/devicetree/bindings/timer/renesas,cmt.txt | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt b/Documentation/devicetree/bindings/timer/renesas,cmt.txt index d740989..1e4fe98 100644 --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt @@ -22,6 +22,10 @@ Required Properties: - "renesas,r8a73a4-cmt0" for the 32-bit CMT0 device included in r8a73a4. - "renesas,r8a73a4-cmt1" for the 48-bit CMT1 device included in r8a73a4. + - "renesas,r8a7743-cmt0" for the 32-bit CMT0 device included in r8a7743. + - "renesas,r8a7743-cmt1" for the 48-bit CMT1 device included in r8a7743. + - "renesas,r8a7745-cmt0" for the 32-bit CMT0 device included in r8a7745. + - "renesas,r8a7745-cmt1" for the 48-bit CMT1 device included in r8a7745. - "renesas,r8a7790-cmt0" for the 32-bit CMT0 device included in r8a7790. - "renesas,r8a7790-cmt1" for the 48-bit CMT1 device included in r8a7790. - "renesas,r8a7791-cmt0" for the 32-bit CMT0 device included in r8a7791. @@ -31,9 +35,11 @@ Required Properties: - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794. - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794. - - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2. - - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2. - These are fallbacks for r8a73a4 and all the R-Car Gen2 + - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2 or + RZ/G1. + - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2 or + RZ/G1. + These are fallbacks for r8a73a4, all the R-Car Gen2 and RZ/G1 entries listed above. - reg: base address and length of the registers block for the timer module. -- 2.7.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support 2017-12-12 18:49 ` [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support Fabrizio Castro @ 2017-12-13 8:40 ` Simon Horman 2017-12-13 9:50 ` Fabrizio Castro 2017-12-13 9:59 ` Geert Uytterhoeven 2017-12-15 22:51 ` Rob Herring 2 siblings, 1 reply; 15+ messages in thread From: Simon Horman @ 2017-12-13 8:40 UTC (permalink / raw) To: Fabrizio Castro Cc: Rob Herring, Mark Rutland, linux-renesas-soc, Daniel Lezcano, Thomas Gleixner, Geert Uytterhoeven, Chris Paterson, Biju Das, devicetree On Tue, Dec 12, 2017 at 06:49:37PM +0000, Fabrizio Castro wrote: > Document SoC specific compatible strings for r8a7743 and r8a7745. > No driver change is needed as the fallback strings will activate > the right code. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > Documentation/devicetree/bindings/timer/renesas,cmt.txt | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > index d740989..1e4fe98 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > @@ -22,6 +22,10 @@ Required Properties: > > - "renesas,r8a73a4-cmt0" for the 32-bit CMT0 device included in r8a73a4. > - "renesas,r8a73a4-cmt1" for the 48-bit CMT1 device included in r8a73a4. > + - "renesas,r8a7743-cmt0" for the 32-bit CMT0 device included in r8a7743. > + - "renesas,r8a7743-cmt1" for the 48-bit CMT1 device included in r8a7743. > + - "renesas,r8a7745-cmt0" for the 32-bit CMT0 device included in r8a7745. > + - "renesas,r8a7745-cmt1" for the 48-bit CMT1 device included in r8a7745. > - "renesas,r8a7790-cmt0" for the 32-bit CMT0 device included in r8a7790. > - "renesas,r8a7790-cmt1" for the 48-bit CMT1 device included in r8a7790. > - "renesas,r8a7791-cmt0" for the 32-bit CMT0 device included in r8a7791. > @@ -31,9 +35,11 @@ Required Properties: > - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794. > - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794. > > - - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2. > - - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2. > - These are fallbacks for r8a73a4 and all the R-Car Gen2 > + - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2 or nit: or -> and ? > + RZ/G1. > + - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2 or > + RZ/G1. > + These are fallbacks for r8a73a4, all the R-Car Gen2 and RZ/G1 > entries listed above. nit: all the R-Car -> R-Car > - reg: base address and length of the registers block for the timer module. ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support 2017-12-13 8:40 ` Simon Horman @ 2017-12-13 9:50 ` Fabrizio Castro 0 siblings, 0 replies; 15+ messages in thread From: Fabrizio Castro @ 2017-12-13 9:50 UTC (permalink / raw) To: Simon Horman Cc: Rob Herring, Mark Rutland, linux-renesas-soc, Daniel Lezcano, Thomas Gleixner, Geert Uytterhoeven, Chris Paterson, Biju Das, devicetree Hello Simon, thank you for the feedback. I'll apply your comments to V2, but I'll wait for your reply on the CMT "enable by default" issue. Thanks, Fab > Subject: Re: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support > > On Tue, Dec 12, 2017 at 06:49:37PM +0000, Fabrizio Castro wrote: > > Document SoC specific compatible strings for r8a7743 and r8a7745. > > No driver change is needed as the fallback strings will activate > > the right code. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/timer/renesas,cmt.txt | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > > index d740989..1e4fe98 100644 > > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > > @@ -22,6 +22,10 @@ Required Properties: > > > > - "renesas,r8a73a4-cmt0" for the 32-bit CMT0 device included in r8a73a4. > > - "renesas,r8a73a4-cmt1" for the 48-bit CMT1 device included in r8a73a4. > > + - "renesas,r8a7743-cmt0" for the 32-bit CMT0 device included in r8a7743. > > + - "renesas,r8a7743-cmt1" for the 48-bit CMT1 device included in r8a7743. > > + - "renesas,r8a7745-cmt0" for the 32-bit CMT0 device included in r8a7745. > > + - "renesas,r8a7745-cmt1" for the 48-bit CMT1 device included in r8a7745. > > - "renesas,r8a7790-cmt0" for the 32-bit CMT0 device included in r8a7790. > > - "renesas,r8a7790-cmt1" for the 48-bit CMT1 device included in r8a7790. > > - "renesas,r8a7791-cmt0" for the 32-bit CMT0 device included in r8a7791. > > @@ -31,9 +35,11 @@ Required Properties: > > - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794. > > - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794. > > > > - - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2. > > - - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2. > > -These are fallbacks for r8a73a4 and all the R-Car Gen2 > > + - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2 or > > nit: or -> and ? > > > +RZ/G1. > > + - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2 or > > +RZ/G1. > > +These are fallbacks for r8a73a4, all the R-Car Gen2 and RZ/G1 > > entrieslisted above. > > nit: all the R-Car -> R-Car > > > - reg: base address and length of the registers block for the timer module. [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support 2017-12-12 18:49 ` [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support Fabrizio Castro 2017-12-13 8:40 ` Simon Horman @ 2017-12-13 9:59 ` Geert Uytterhoeven 2017-12-15 22:51 ` Rob Herring 2 siblings, 0 replies; 15+ messages in thread From: Geert Uytterhoeven @ 2017-12-13 9:59 UTC (permalink / raw) To: Fabrizio Castro Cc: Rob Herring, Mark Rutland, Linux-Renesas, Daniel Lezcano, Thomas Gleixner, Simon Horman, Chris Paterson, Biju Das, devicetree Hi Fabrizio, On Tue, Dec 12, 2017 at 7:49 PM, Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > Document SoC specific compatible strings for r8a7743 and r8a7745. > No driver change is needed as the fallback strings will activate > the right code. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> With the issues pointed out by Simon fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support 2017-12-12 18:49 ` [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support Fabrizio Castro 2017-12-13 8:40 ` Simon Horman 2017-12-13 9:59 ` Geert Uytterhoeven @ 2017-12-15 22:51 ` Rob Herring 2 siblings, 0 replies; 15+ messages in thread From: Rob Herring @ 2017-12-15 22:51 UTC (permalink / raw) To: Fabrizio Castro Cc: Mark Rutland, linux-renesas-soc, Daniel Lezcano, Thomas Gleixner, Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das, devicetree On Tue, Dec 12, 2017 at 06:49:37PM +0000, Fabrizio Castro wrote: > Document SoC specific compatible strings for r8a7743 and r8a7745. > No driver change is needed as the fallback strings will activate > the right code. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > Documentation/devicetree/bindings/timer/renesas,cmt.txt | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support 2017-12-12 18:49 [PATCH 0/3] Add CMT support to r8a774[35] Fabrizio Castro 2017-12-12 18:49 ` [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support Fabrizio Castro @ 2017-12-12 18:49 ` Fabrizio Castro 2017-12-13 8:38 ` Simon Horman 2017-12-12 18:49 ` [PATCH 3/3] ARM: dts: r8a7745: " Fabrizio Castro 2 siblings, 1 reply; 15+ messages in thread From: Fabrizio Castro @ 2017-12-12 18:49 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Fabrizio Castro, Simon Horman, Magnus Damm, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc, devicetree, linux-arm-kernel Add CMT[01] support to SoC DT. Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Biju Das <biju.das@bp.renesas.com> --- arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 59860c8..0e2834a 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -262,6 +262,36 @@ IRQ_TYPE_LEVEL_LOW)>; }; + cmt0: timer@ffca0000 { + compatible = "renesas,r8a7743-cmt0", + "renesas,rcar-gen2-cmt0"; + reg = <0 0xffca0000 0 0x1004>; + interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 124>; + clock-names = "fck"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 124>; + }; + + cmt1: timer@e6130000 { + compatible = "renesas,r8a7743-cmt1", + "renesas,rcar-gen2-cmt1"; + reg = <0 0xe6130000 0 0x1004>; + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 329>; + clock-names = "fck"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 329>; + }; + cpg: clock-controller@e6150000 { compatible = "renesas,r8a7743-cpg-mssr"; reg = <0 0xe6150000 0 0x1000>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support 2017-12-12 18:49 ` [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support Fabrizio Castro @ 2017-12-13 8:38 ` Simon Horman 2017-12-13 9:42 ` Fabrizio Castro 0 siblings, 1 reply; 15+ messages in thread From: Simon Horman @ 2017-12-13 8:38 UTC (permalink / raw) To: Fabrizio Castro Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc, devicetree, linux-arm-kernel On Tue, Dec 12, 2017 at 06:49:38PM +0000, Fabrizio Castro wrote: > Add CMT[01] support to SoC DT. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) I was expecting the cmt nodes to be "disabled" in the SoC file and then enabled selectively in board files. Am I missing something? Otherwise this patch looks good to me. > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index 59860c8..0e2834a 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -262,6 +262,36 @@ > IRQ_TYPE_LEVEL_LOW)>; > }; > > + cmt0: timer@ffca0000 { > + compatible = "renesas,r8a7743-cmt0", > + "renesas,rcar-gen2-cmt0"; > + reg = <0 0xffca0000 0 0x1004>; > + interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 124>; > + clock-names = "fck"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 124>; > + }; > + > + cmt1: timer@e6130000 { > + compatible = "renesas,r8a7743-cmt1", > + "renesas,rcar-gen2-cmt1"; > + reg = <0 0xe6130000 0 0x1004>; > + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 329>; > + clock-names = "fck"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 329>; > + }; > + > cpg: clock-controller@e6150000 { > compatible = "renesas,r8a7743-cpg-mssr"; > reg = <0 0xe6150000 0 0x1000>; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support 2017-12-13 8:38 ` Simon Horman @ 2017-12-13 9:42 ` Fabrizio Castro [not found] ` <TY1PR06MB0895B34EFC2A48F49AFF0694C0350-/PRLmSCtZ16EeHdvShrxA20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Fabrizio Castro @ 2017-12-13 9:42 UTC (permalink / raw) To: Simon Horman Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc, devicetree, linux-arm-kernel Hello Simon, thank you for your feedback. > On Tue, Dec 12, 2017 at 06:49:38PM +0000, Fabrizio Castro wrote: > > Add CMT[01] support to SoC DT. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > --- > > arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > I was expecting the cmt nodes to be "disabled" in the SoC file > and then enabled selectively in board files. Am I missing something? Since this component is just a compare and match timer, I thought there was no harm in enabling it by default in the SoC specific DT. The system will park it and leave its clock disabled until actually needed for something. The user can still disable it in the board specific DT if he/she doesn't mean to even have the option to use it. Do you prefer I left it disabled by default? Thanks, Fab > > Otherwise this patch looks good to me. > > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > > index 59860c8..0e2834a 100644 > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > @@ -262,6 +262,36 @@ > > IRQ_TYPE_LEVEL_LOW)>; > > }; > > > > +cmt0: timer@ffca0000 { > > +compatible = "renesas,r8a7743-cmt0", > > + "renesas,rcar-gen2-cmt0"; > > +reg = <0 0xffca0000 0 0x1004>; > > +interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 124>; > > +clock-names = "fck"; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg 124>; > > +}; > > + > > +cmt1: timer@e6130000 { > > +compatible = "renesas,r8a7743-cmt1", > > + "renesas,rcar-gen2-cmt1"; > > +reg = <0 0xe6130000 0 0x1004>; > > +interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 329>; > > +clock-names = "fck"; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg 329>; > > +}; > > + > > cpg: clock-controller@e6150000 { > > compatible = "renesas,r8a7743-cpg-mssr"; > > reg = <0 0xe6150000 0 0x1000>; > > -- > > 2.7.4 > > [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <TY1PR06MB0895B34EFC2A48F49AFF0694C0350-/PRLmSCtZ16EeHdvShrxA20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support [not found] ` <TY1PR06MB0895B34EFC2A48F49AFF0694C0350-/PRLmSCtZ16EeHdvShrxA20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-12-13 10:05 ` Geert Uytterhoeven 2017-12-13 10:15 ` Fabrizio Castro 0 siblings, 1 reply; 15+ messages in thread From: Geert Uytterhoeven @ 2017-12-13 10:05 UTC (permalink / raw) To: Fabrizio Castro Cc: Simon Horman, Rob Herring, Mark Rutland, Russell King, Magnus Damm, Chris Paterson, Biju Das, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Hi Fabrizio, On Wed, Dec 13, 2017 at 10:42 AM, Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> wrote: >> On Tue, Dec 12, 2017 at 06:49:38PM +0000, Fabrizio Castro wrote: >> > Add CMT[01] support to SoC DT. >> > Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> >> > Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> >> > --- >> > arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++++++++++ >> > 1 file changed, 30 insertions(+) >> >> I was expecting the cmt nodes to be "disabled" in the SoC file >> and then enabled selectively in board files. Am I missing something? > > Since this component is just a compare and match timer, I thought there was no harm in enabling it by default in the SoC specific DT. The system will park it and leave its clock disabled until actually needed for something. > The user can still disable it in the board specific DT if he/she doesn't mean to even have the option to use it. Do you prefer I left it disabled by default? It's debatable (thus up to Simon the maintainer ;-). For I/O devices, we disable them in the SoC .dtsi file. For core infrastructure like interrupt, DMA, and GPIO controllers, we keep them enabled. Timers are core functionality, but who's actually using these timers? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support 2017-12-13 10:05 ` Geert Uytterhoeven @ 2017-12-13 10:15 ` Fabrizio Castro 2017-12-18 11:18 ` Simon Horman 0 siblings, 1 reply; 15+ messages in thread From: Fabrizio Castro @ 2017-12-13 10:15 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Simon Horman, Rob Herring, Mark Rutland, Russell King, Magnus Damm, Chris Paterson, Biju Das, linux-renesas-soc, devicetree, linux-arm-kernel Hello Geert, thank you for your feedback. > Hi Fabrizio, > > On Wed, Dec 13, 2017 at 10:42 AM, Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > >> On Tue, Dec 12, 2017 at 06:49:38PM +0000, Fabrizio Castro wrote: > >> > Add CMT[01] support to SoC DT. > >> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > >> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > >> > --- > >> > arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++++++++++ > >> > 1 file changed, 30 insertions(+) > >> > >> I was expecting the cmt nodes to be "disabled" in the SoC file > >> and then enabled selectively in board files. Am I missing something? > > > > Since this component is just a compare and match timer, I thought there was no harm in enabling it by default in the SoC specific DT. > > The system will park it and leave its clock disabled until actually needed for something. > > The user can still disable it in the board specific DT if he/she doesn't mean to even have the option to use it. Do you prefer I left it > disabled by default? > > It's debatable (thus up to Simon the maintainer ;-). > For I/O devices, we disable them in the SoC .dtsi file. > For core infrastructure like interrupt, DMA, and GPIO controllers, we keep > them enabled. > > Timers are core functionality, but who's actually using these timers? I don't have a use case in mind unfortunately, but it's still core functionality and pretty harmless as far as I can tell. Let's see what Simon thinks about this. Thanks, Fab > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support 2017-12-13 10:15 ` Fabrizio Castro @ 2017-12-18 11:18 ` Simon Horman [not found] ` <20171218111819.nsu4dd6wacdud3lc-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Simon Horman @ 2017-12-18 11:18 UTC (permalink / raw) To: Fabrizio Castro Cc: Geert Uytterhoeven, Rob Herring, Mark Rutland, Russell King, Magnus Damm, Chris Paterson, Biju Das, linux-renesas-soc, devicetree, linux-arm-kernel On Wed, Dec 13, 2017 at 10:15:39AM +0000, Fabrizio Castro wrote: > Hello Geert, > > thank you for your feedback. > > > Hi Fabrizio, > > > > On Wed, Dec 13, 2017 at 10:42 AM, Fabrizio Castro > > <fabrizio.castro@bp.renesas.com> wrote: > > >> On Tue, Dec 12, 2017 at 06:49:38PM +0000, Fabrizio Castro wrote: > > >> > Add CMT[01] support to SoC DT. > > >> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > >> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > >> > --- > > >> > arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++++++++++ > > >> > 1 file changed, 30 insertions(+) > > >> > > >> I was expecting the cmt nodes to be "disabled" in the SoC file > > >> and then enabled selectively in board files. Am I missing something? > > > > > > Since this component is just a compare and match timer, I thought there was no harm in enabling it by default in the SoC specific DT. > > > The system will park it and leave its clock disabled until actually needed for something. > > > The user can still disable it in the board specific DT if he/she doesn't mean to even have the option to use it. Do you prefer I left it > > disabled by default? > > > > It's debatable (thus up to Simon the maintainer ;-). > > For I/O devices, we disable them in the SoC .dtsi file. > > For core infrastructure like interrupt, DMA, and GPIO controllers, we keep > > them enabled. > > > > Timers are core functionality, but who's actually using these timers? > > I don't have a use case in mind unfortunately, but it's still core > functionality and pretty harmless as far as I can tell. Let's see what > Simon thinks about this. On Renesas SoCs we have a bit more flexibility with timers than might be the case on other SoCs. Thus I'd like to keep with the scheme of disabling them in .dtsi and enabling them when they are needed. Please update the patches. ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <20171218111819.nsu4dd6wacdud3lc-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* RE: [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support [not found] ` <20171218111819.nsu4dd6wacdud3lc-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2017-12-18 15:41 ` Fabrizio Castro 0 siblings, 0 replies; 15+ messages in thread From: Fabrizio Castro @ 2017-12-18 15:41 UTC (permalink / raw) To: Simon Horman Cc: Geert Uytterhoeven, Rob Herring, Mark Rutland, Russell King, Magnus Damm, Chris Paterson, Biju Das, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Hello Simon, > > Hello Geert, > > > > thank you for your feedback. > > > > > Hi Fabrizio, > > > > > > On Wed, Dec 13, 2017 at 10:42 AM, Fabrizio Castro > > > <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> wrote: > > > >> On Tue, Dec 12, 2017 at 06:49:38PM +0000, Fabrizio Castro wrote: > > > >> > Add CMT[01] support to SoC DT. > > > >> > Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > > > >> > Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > > > >> > --- > > > >> > arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++++++++++ > > > >> > 1 file changed, 30 insertions(+) > > > >> > > > >> I was expecting the cmt nodes to be "disabled" in the SoC file > > > >> and then enabled selectively in board files. Am I missing something? > > > > > > > > Since this component is just a compare and match timer, I thought there was no harm in enabling it by default in the SoC specific > DT. > > > > The system will park it and leave its clock disabled until actually needed for something. > > > > The user can still disable it in the board specific DT if he/she doesn't mean to even have the option to use it. Do you prefer I left it > > > disabled by default? > > > > > > It's debatable (thus up to Simon the maintainer ;-). > > > For I/O devices, we disable them in the SoC .dtsi file. > > > For core infrastructure like interrupt, DMA, and GPIO controllers, we keep > > > them enabled. > > > > > > Timers are core functionality, but who's actually using these timers? > > > > I don't have a use case in mind unfortunately, but it's still core > > functionality and pretty harmless as far as I can tell. Let's see what > > Simon thinks about this. > > On Renesas SoCs we have a bit more flexibility with timers than might > be the case on other SoCs. Thus I'd like to keep with the scheme of > disabling them in .dtsi and enabling them when they are needed. > > Please update the patches. Ok, I'll send a v2. Thanks, Fab [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 3/3] ARM: dts: r8a7745: Add CMT SoC specific support 2017-12-12 18:49 [PATCH 0/3] Add CMT support to r8a774[35] Fabrizio Castro 2017-12-12 18:49 ` [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support Fabrizio Castro 2017-12-12 18:49 ` [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support Fabrizio Castro @ 2017-12-12 18:49 ` Fabrizio Castro 2017-12-13 8:42 ` Simon Horman 2 siblings, 1 reply; 15+ messages in thread From: Fabrizio Castro @ 2017-12-12 18:49 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Fabrizio Castro, Simon Horman, Magnus Damm, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc, devicetree, linux-arm-kernel Add CMT[01] support to SoC DT. Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Biju Das <biju.das@bp.renesas.com> --- arch/arm/boot/dts/r8a7745.dtsi | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi index 0fa7861..765a80d 100644 --- a/arch/arm/boot/dts/r8a7745.dtsi +++ b/arch/arm/boot/dts/r8a7745.dtsi @@ -235,6 +235,36 @@ IRQ_TYPE_LEVEL_LOW)>; }; + cmt0: timer@ffca0000 { + compatible = "renesas,r8a7745-cmt0", + "renesas,rcar-gen2-cmt0"; + reg = <0 0xffca0000 0 0x1004>; + interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 124>; + clock-names = "fck"; + power-domains = <&sysc R8A7745_PD_ALWAYS_ON>; + resets = <&cpg 124>; + }; + + cmt1: timer@e6130000 { + compatible = "renesas,r8a7745-cmt1", + "renesas,rcar-gen2-cmt1"; + reg = <0 0xe6130000 0 0x1004>; + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 329>; + clock-names = "fck"; + power-domains = <&sysc R8A7745_PD_ALWAYS_ON>; + resets = <&cpg 329>; + }; + cpg: clock-controller@e6150000 { compatible = "renesas,r8a7745-cpg-mssr"; reg = <0 0xe6150000 0 0x1000>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 3/3] ARM: dts: r8a7745: Add CMT SoC specific support 2017-12-12 18:49 ` [PATCH 3/3] ARM: dts: r8a7745: " Fabrizio Castro @ 2017-12-13 8:42 ` Simon Horman 0 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2017-12-13 8:42 UTC (permalink / raw) To: Fabrizio Castro Cc: Rob Herring, Mark Rutland, Russell King, Magnus Damm, Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc, devicetree, linux-arm-kernel On Tue, Dec 12, 2017 at 06:49:39PM +0000, Fabrizio Castro wrote: > Add CMT[01] support to SoC DT. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > arch/arm/boot/dts/r8a7745.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) Please see my review of the r8a7743 patch in this series. ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-12-18 15:41 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-12-12 18:49 [PATCH 0/3] Add CMT support to r8a774[35] Fabrizio Castro 2017-12-12 18:49 ` [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support Fabrizio Castro 2017-12-13 8:40 ` Simon Horman 2017-12-13 9:50 ` Fabrizio Castro 2017-12-13 9:59 ` Geert Uytterhoeven 2017-12-15 22:51 ` Rob Herring 2017-12-12 18:49 ` [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support Fabrizio Castro 2017-12-13 8:38 ` Simon Horman 2017-12-13 9:42 ` Fabrizio Castro [not found] ` <TY1PR06MB0895B34EFC2A48F49AFF0694C0350-/PRLmSCtZ16EeHdvShrxA20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-12-13 10:05 ` Geert Uytterhoeven 2017-12-13 10:15 ` Fabrizio Castro 2017-12-18 11:18 ` Simon Horman [not found] ` <20171218111819.nsu4dd6wacdud3lc-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2017-12-18 15:41 ` Fabrizio Castro 2017-12-12 18:49 ` [PATCH 3/3] ARM: dts: r8a7745: " Fabrizio Castro 2017-12-13 8:42 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).