From: Stefan-gabriel Mirea <stefan-gabriel.mirea@nxp.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Eddy Petrisor <eddy.petrisor@nxp.com>,
"will@kernel.org" <will@kernel.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jslaby@suse.com" <jslaby@suse.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leo Li <leoyang.li@nxp.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB board
Date: Sat, 3 Aug 2019 08:00:31 +0000 [thread overview]
Message-ID: <VI1PR0402MB28635B9758CBF72504191693DFD80@VI1PR0402MB2863.eurprd04.prod.outlook.com> (raw)
In-Reply-To: CAL_JsqL++GZBxczxePni9ysNq06kObB4EzJEi1e4M=PurPZFgQ@mail.gmail.com
Hello Rob,
On 8/3/2019 1:38 AM, Rob Herring wrote:
> On Fri, Aug 2, 2019 at 1:47 PM Stefan-gabriel Mirea
> <stefan-gabriel.mirea@nxp.com> wrote:
>> + - description: S32V234 Customer Evaluation Board
>
> Most of the entries in this file are for all the boards for an SoC.
>
>> + items:
>> + - enum:
>> + - fsl,s32v234-evb
>
> If that's not going to be the case here, you can use 'const' here.
We also intend to submit patches for the SBC-S32V234[1] board in the
future and I believe that its 'compatible' should share this entry.
Would it therefore be preferable to update the description at this
moment and add a comment, like:
- description: S32V234 based Boards
items:
- enum:
- fsl,s32v234-evb # S32V234-EVB2 Customer Evaluation Board
- const: fsl,s32v234
or just replace the single-value 'enum' with a 'const' for now?
Regards,
Stefan
[1] https://www.nxp.com/design/development-boards/automotive-development-platforms/s32v-mpus-platforms/s32v-vision-and-sensor-fusion-evaluation-board:SBC-S32V234
next prev parent reply other threads:[~2019-08-03 8:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 19:47 [PATCH 0/6] Add initial support for S32V234-EVB Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB board Stefan-gabriel Mirea
2019-08-02 22:38 ` Rob Herring
2019-08-03 8:00 ` Stefan-gabriel Mirea [this message]
2019-08-02 19:47 ` [PATCH 2/6] arm64: Introduce config for S32 Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 3/6] arm64: dts: fsl: Add device tree for S32V234-EVB Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 4/6] dt-bindings: serial: Document Freescale LINFlex UART Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234 Stefan-gabriel Mirea
2019-08-05 15:31 ` gregkh
2019-08-06 17:11 ` Stefan-gabriel Mirea
2019-08-06 18:40 ` gregkh
2019-08-07 16:42 ` Stefan-gabriel Mirea
2019-08-07 16:56 ` gregkh
2019-08-07 17:05 ` Stefan-gabriel Mirea
2019-08-08 8:08 ` Will Deacon
2019-08-08 12:47 ` Stefan-gabriel Mirea
2019-08-08 17:17 ` Will Deacon
2019-08-09 9:45 ` Stefan-gabriel Mirea
2019-08-09 9:53 ` Will Deacon
2019-08-09 9:57 ` Stefan-gabriel Mirea
2019-08-02 19:47 ` [PATCH 6/6] arm64: defconfig: Enable configs " Stefan-gabriel Mirea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB28635B9758CBF72504191693DFD80@VI1PR0402MB2863.eurprd04.prod.outlook.com \
--to=stefan-gabriel.mirea@nxp.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=eddy.petrisor@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).