Re: [PATCH RFC v6 5/9] interconnect: imx: Add platform driver for imx8mm

[Leonard Crestez <leonard.crestez@nxp.com>]

On 12.12.2019 09:35, Georgi Djakov wrote:
> Hi Leonard,
> 
> On 11/14/19 22:09, Leonard Crestez wrote:
>> Add a platform driver for the i.MX8MM SoC describing bus topology.
>>
>> Bandwidth adjustments is currently only supported on the DDRC and main
>> NOC. Scaling for the vpu/gpu/display NICs could be added in the future.
>>
>> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
>> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>> ---
>>   drivers/interconnect/imx/Kconfig          |   4 +
>>   drivers/interconnect/imx/Makefile         |   1 +
>>   drivers/interconnect/imx/imx8mm.c         | 105 ++++++++++++++++++++++
>>   include/dt-bindings/interconnect/imx8mm.h |  49 ++++++++++
>>   4 files changed, 159 insertions(+)
>>   create mode 100644 drivers/interconnect/imx/imx8mm.c
>>   create mode 100644 include/dt-bindings/interconnect/imx8mm.h
>>
>> diff --git a/drivers/interconnect/imx/Kconfig b/drivers/interconnect/imx/Kconfig
>> index 7d81d3c83a61..15671fe7f600 100644
>> --- a/drivers/interconnect/imx/Kconfig
>> +++ b/drivers/interconnect/imx/Kconfig
>> @@ -1,5 +1,9 @@
>>   config INTERCONNECT_IMX
>>   	bool "i.MX interconnect drivers"
>>   	depends on ARCH_MXC || COMPILE_TEST
>>   	help
>>   	  Generic interconnect driver for i.MX SOCs
>> +
>> +config INTERCONNECT_IMX8MM
>> +	def_bool y
> 
> Can this be a module?

Yes. I'll turn this into a tristate; at the very least it would be 
useful to check modprobe cycling.

By default imx boots with bus frequency set to "high" so there are no 
hard dependencies on interconnect.

Historically in our vendor tree we had boot drivers which made bus 
scaling requests (like sdcard and ethernet) but I'm not sure this is 
strictly required.

>> +	depends on INTERCONNECT_IMX
>> diff --git a/drivers/interconnect/imx/Makefile b/drivers/interconnect/imx/Makefile
>> index bb92fd9fe4a5..5f658c1608a6 100644
>> --- a/drivers/interconnect/imx/Makefile
>> +++ b/drivers/interconnect/imx/Makefile
>> @@ -1 +1,2 @@
>>   obj-$(CONFIG_INTERCONNECT_IMX) += imx.o
>> +obj-$(CONFIG_INTERCONNECT_IMX8MM) += imx8mm.o
>> diff --git a/drivers/interconnect/imx/imx8mm.c b/drivers/interconnect/imx/imx8mm.c
>> new file mode 100644
>> index 000000000000..acc002153729
>> --- /dev/null
> 
> Thanks,
> Georgi
>