From: Angus Ainslie <angus@akkea.ca>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: "Georgi Djakov" <georgi.djakov@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Artur Świgoń" <a.swigon@partner.samsung.com>,
"Alexandre Bailon" <abailon@baylibre.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Jacky Bai" <ping.bai@nxp.com>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Abel Vesa" <abel.vesa@nxp.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Saravana Kannan" <saravanak@google.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Matthias Kaehlcke" <mka@chromium.org>,
"Martin Kepplinger" <martink@posteo.de>,
"Silvano di Ninno" <silvano.dininno@nxp.com>,
linux-pm@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC v6 2/9] PM / devfreq: Add generic imx bus scaling driver
Date: Wed, 20 Nov 2019 06:08:35 -0800 [thread overview]
Message-ID: <e311a376e6aec0c380686a7e307d2c07@akkea.ca> (raw)
In-Reply-To: <f329e715898a6b9fd0cee707a93fb1e144e31bd4.1573761527.git.leonard.crestez@nxp.com>
Hi Leonard,
On 2019-11-14 12:09, Leonard Crestez wrote:
> Add initial support for dynamic frequency switching on pieces of the
> imx
> interconnect fabric.
>
> All this driver does is set a clk rate based on an opp table, it does
> not map register areas.
>
Is this working with mainline ATF or does it still need to be used with
your modified ATF code ?
Thanks
Angus
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> drivers/devfreq/Kconfig | 9 ++
> drivers/devfreq/Makefile | 1 +
> drivers/devfreq/imx-devfreq.c | 150 ++++++++++++++++++++++++++++++++++
> 3 files changed, 160 insertions(+)
> create mode 100644 drivers/devfreq/imx-devfreq.c
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 923a6132e741..fef5ce831e90 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -98,10 +98,19 @@ config ARM_IMX8M_DDRC_DEVFREQ
> select DEVFREQ_GOV_USERSPACE
> help
> This adds the DEVFREQ driver for the i.MX8M DDR Controller. It
> allows
> adjusting DRAM frequency.
>
> +config ARM_IMX_DEVFREQ
> + tristate "i.MX Generic DEVFREQ Driver"
> + depends on ARCH_MXC || COMPILE_TEST
> + select DEVFREQ_GOV_PASSIVE
> + select DEVFREQ_GOV_USERSPACE
> + help
> + This adds the generic DEVFREQ driver for i.MX interconnects. It
> + allows adjusting NIC/NOC frequency.
> +
> config ARM_TEGRA_DEVFREQ
> tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
> depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
> ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
> ARCH_TEGRA_210_SOC || \
> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile
> index 3eb4d5e6635c..61d0edee16f7 100644
> --- a/drivers/devfreq/Makefile
> +++ b/drivers/devfreq/Makefile
> @@ -8,10 +8,11 @@ obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) +=
> governor_userspace.o
> obj-$(CONFIG_DEVFREQ_GOV_PASSIVE) += governor_passive.o
>
> # DEVFREQ Drivers
> obj-$(CONFIG_ARM_EXYNOS_BUS_DEVFREQ) += exynos-bus.o
> obj-$(CONFIG_ARM_IMX8M_DDRC_DEVFREQ) += imx8m-ddrc.o
> +obj-$(CONFIG_ARM_IMX_DEVFREQ) += imx-devfreq.o
> obj-$(CONFIG_ARM_RK3399_DMC_DEVFREQ) += rk3399_dmc.o
> obj-$(CONFIG_ARM_TEGRA_DEVFREQ) += tegra30-devfreq.o
> obj-$(CONFIG_ARM_TEGRA20_DEVFREQ) += tegra20-devfreq.o
>
> # DEVFREQ Event Drivers
> diff --git a/drivers/devfreq/imx-devfreq.c
> b/drivers/devfreq/imx-devfreq.c
> new file mode 100644
> index 000000000000..620b344e87aa
> --- /dev/null
> +++ b/drivers/devfreq/imx-devfreq.c
> @@ -0,0 +1,150 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright 2019 NXP
> + */
> +
> +#include <linux/clk.h>
> +#include <linux/devfreq.h>
> +#include <linux/device.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/pm_opp.h>
> +#include <linux/platform_device.h>
> +#include <linux/slab.h>
> +
> +struct imx_devfreq {
> + struct devfreq_dev_profile profile;
> + struct devfreq *devfreq;
> + struct clk *clk;
> + struct devfreq_passive_data passive_data;
> +};
> +
> +static int imx_devfreq_target(struct device *dev,
> + unsigned long *freq, u32 flags)
> +{
> + struct imx_devfreq *priv = dev_get_drvdata(dev);
> + struct dev_pm_opp *new_opp;
> + unsigned long new_freq;
> + int ret;
> +
> + new_opp = devfreq_recommended_opp(dev, freq, flags);
> + if (IS_ERR(new_opp)) {
> + ret = PTR_ERR(new_opp);
> + dev_err(dev, "failed to get recommended opp: %d\n", ret);
> + return ret;
> + }
> + new_freq = dev_pm_opp_get_freq(new_opp);
> + dev_pm_opp_put(new_opp);
> +
> + return clk_set_rate(priv->clk, new_freq);
> +}
> +
> +static int imx_devfreq_get_cur_freq(struct device *dev, unsigned long
> *freq)
> +{
> + struct imx_devfreq *priv = dev_get_drvdata(dev);
> +
> + *freq = clk_get_rate(priv->clk);
> +
> + return 0;
> +}
> +
> +static int imx_devfreq_get_dev_status(struct device *dev,
> + struct devfreq_dev_status *stat)
> +{
> + struct imx_devfreq *priv = dev_get_drvdata(dev);
> +
> + stat->busy_time = 0;
> + stat->total_time = 0;
> + stat->current_frequency = clk_get_rate(priv->clk);
> +
> + return 0;
> +}
> +
> +static void imx_devfreq_exit(struct device *dev)
> +{
> + dev_pm_opp_of_remove_table(dev);
> +}
> +
> +static int imx_devfreq_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct imx_devfreq *priv;
> + const char *gov = DEVFREQ_GOV_USERSPACE;
> + void *govdata = NULL;
> + int ret;
> +
> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> + if (!priv)
> + return -ENOMEM;
> +
> + priv->clk = devm_clk_get(dev, NULL);
> + if (IS_ERR(priv->clk)) {
> + ret = PTR_ERR(priv->clk);
> + dev_err(dev, "failed to fetch clk: %d\n", ret);
> + return ret;
> + }
> + platform_set_drvdata(pdev, priv);
> +
> + ret = dev_pm_opp_of_add_table(dev);
> + if (ret < 0) {
> + dev_err(dev, "failed to get OPP table\n");
> + return ret;
> + }
> +
> + priv->profile.polling_ms = 1000;
> + priv->profile.target = imx_devfreq_target;
> + priv->profile.get_dev_status = imx_devfreq_get_dev_status;
> + priv->profile.exit = imx_devfreq_exit;
> + priv->profile.get_cur_freq = imx_devfreq_get_cur_freq;
> + priv->profile.initial_freq = clk_get_rate(priv->clk);
> +
> + /* Handle passive devfreq parent link */
> + priv->passive_data.parent = devfreq_get_devfreq_by_phandle(dev, 0);
> + if (!IS_ERR(priv->passive_data.parent)) {
> + dev_info(dev, "setup passive link to %s\n",
> + dev_name(priv->passive_data.parent->dev.parent));
> + gov = DEVFREQ_GOV_PASSIVE;
> + govdata = &priv->passive_data;
> + } else if (priv->passive_data.parent != ERR_PTR(-ENODEV)) {
> + // -ENODEV means no parent: not an error.
> + ret = PTR_ERR(priv->passive_data.parent);
> + if (ret != -EPROBE_DEFER)
> + dev_warn(dev, "failed to get initialize passive parent: %d\n",
> + ret);
> + goto err;
> + }
> +
> + priv->devfreq = devm_devfreq_add_device(dev, &priv->profile,
> + gov, govdata);
> + if (IS_ERR(priv->devfreq)) {
> + ret = PTR_ERR(priv->devfreq);
> + dev_err(dev, "failed to add devfreq device: %d\n", ret);
> + goto err;
> + }
> +
> + return 0;
> +
> +err:
> + dev_pm_opp_of_remove_table(dev);
> + return ret;
> +}
> +
> +static const struct of_device_id imx_devfreq_of_match[] = {
> + { .compatible = "fsl,imx8m-noc", },
> + { .compatible = "fsl,imx8m-nic", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, imx_devfreq_of_match);
> +
> +static struct platform_driver imx_devfreq_platdrv = {
> + .probe = imx_devfreq_probe,
> + .driver = {
> + .name = "imx-devfreq",
> + .of_match_table = of_match_ptr(imx_devfreq_of_match),
> + },
> +};
> +module_platform_driver(imx_devfreq_platdrv);
> +
> +MODULE_DESCRIPTION("Generic i.MX bus frequency driver");
> +MODULE_AUTHOR("Leonard Crestez <leonard.crestez@nxp.com>");
> +MODULE_LICENSE("GPL v2");
next prev parent reply other threads:[~2019-11-20 14:08 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 20:09 [PATCH RFC v6 0/9] interconnect: Add imx support via devfreq Leonard Crestez
2019-11-14 20:09 ` [PATCH RFC v6 1/9] dt-bindings: interconnect: Add bindings for imx8m noc Leonard Crestez
2019-12-16 1:12 ` Chanwoo Choi
2019-12-16 3:25 ` Chanwoo Choi
2019-12-16 15:09 ` Leonard Crestez
2019-12-17 0:15 ` Chanwoo Choi
2019-12-19 14:31 ` Leonard Crestez
2019-12-19 15:55 ` Chanwoo Choi
2019-12-19 19:11 ` Leonard Crestez
2019-11-14 20:09 ` [PATCH RFC v6 2/9] PM / devfreq: Add generic imx bus scaling driver Leonard Crestez
2019-11-20 14:08 ` Angus Ainslie [this message]
2019-11-20 15:04 ` Leonard Crestez
2019-11-20 15:29 ` Marco Felsch
2019-11-20 15:41 ` Angus Ainslie
2019-11-20 16:30 ` Leonard Crestez
2019-11-20 16:38 ` Angus Ainslie
2019-11-20 18:02 ` Leonard Crestez
2020-02-04 9:45 ` Martin Kepplinger
2020-02-13 10:53 ` Martin Kepplinger
2019-12-13 1:30 ` Chanwoo Choi
2019-12-13 1:51 ` Chanwoo Choi
2019-12-16 1:06 ` Chanwoo Choi
2019-12-16 14:57 ` Leonard Crestez
2019-12-17 0:41 ` Chanwoo Choi
2019-12-17 21:05 ` Leonard Crestez
2019-12-18 3:15 ` Chanwoo Choi
2019-12-18 10:10 ` Leonard Crestez
2019-12-18 10:46 ` Chanwoo Choi
2019-12-18 17:06 ` Chanwoo Choi
2019-11-14 20:09 ` [PATCH RFC v6 3/9] PM / devfreq: imx: Register interconnect device Leonard Crestez
2019-12-13 4:28 ` Chanwoo Choi
2019-12-16 15:00 ` Leonard Crestez
2019-12-17 1:02 ` Chanwoo Choi
2019-12-18 10:13 ` Leonard Crestez
2019-12-18 11:05 ` Chanwoo Choi
2019-12-18 17:13 ` Leonard Crestez
2019-12-19 7:07 ` Chanwoo Choi
2019-11-14 20:09 ` [PATCH RFC v6 4/9] interconnect: Add imx core driver Leonard Crestez
2019-12-12 7:29 ` Georgi Djakov
2019-12-19 0:18 ` Leonard Crestez
2019-11-14 20:09 ` [PATCH RFC v6 5/9] interconnect: imx: Add platform driver for imx8mm Leonard Crestez
2019-12-12 7:35 ` Georgi Djakov
2019-12-16 14:35 ` Leonard Crestez
2019-11-14 20:09 ` [PATCH RFC v6 6/9] interconnect: imx: Add platform driver for imx8mq Leonard Crestez
2019-11-14 20:09 ` [PATCH RFC v6 7/9] interconnect: imx: Add platform driver for imx8mn Leonard Crestez
2019-11-14 20:09 ` [PATCH RFC v6 8/9] arm64: dts: imx8m: Add NOC nodes Leonard Crestez
2019-11-14 20:09 ` [PATCH RFC v6 9/9] arm64: dts: imx8m: Add interconnect provider properties Leonard Crestez
2019-12-11 9:53 ` [PATCH RFC v6 0/9] interconnect: Add imx support via devfreq Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e311a376e6aec0c380686a7e307d2c07@akkea.ca \
--to=angus@akkea.ca \
--cc=Anson.Huang@nxp.com \
--cc=a.swigon@partner.samsung.com \
--cc=abailon@baylibre.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=georgi.djakov@linaro.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martink@posteo.de \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=ping.bai@nxp.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=silvano.dininno@nxp.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).