From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml
Date: Thu, 3 Dec 2020 18:32:50 -0600 [thread overview]
Message-ID: <X8mDsrkG7cY2nPC8@builder.lan> (raw)
In-Reply-To: <20201203191335.927001-1-dmitry.baryshkov@linaro.org>
On Thu 03 Dec 13:13 CST 2020, Dmitry Baryshkov wrote:
[..]
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
> new file mode 100644
> index 000000000000..1ddeb25cbdc1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/qcom/qcom,smem.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm Shared Memory Manager binding
> +
> +maintainers:
> + - Andy Gross <agross@kernel.org>
> + - Bjorn Andersson <bjorn.andersson@linaro.org>
> +
> +description: |
> + This binding describes the Qualcomm Shared Memory Manager, used to share data
> + between various subsystems and OSes in Qualcomm platforms.
> +
> +properties:
> + compatible:
y/-/,/ in that compatible, and we only have one. So I think you should
instead do:
const: "qcom,smem"
Apart from that I think the binding looks good.
Regards,
Bjorn
> + enum:
> + - "qcom-smem"
> +
prev parent reply other threads:[~2020-12-04 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 19:13 [PATCH 1/2] dt-bindings: soc: qcom: convert qcom,smem bindings to yaml Dmitry Baryshkov
2020-12-03 19:13 ` [PATCH 2/2] arm64: dts: qcom: sm8250: rename smem device node to follow schema Dmitry Baryshkov
2020-12-04 0:33 ` Bjorn Andersson
2020-12-04 0:32 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8mDsrkG7cY2nPC8@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).